fix: Add missing aws_ecr_lifecycle_policy tagPatternList change detection

[acwwat]

Description

This PR is to fix change detection issues (specifically the lack of it) with the tagPatternList attribute in the ECR lifecycle policy JSON for the aws_ecr_lifecycle_policy resource.

Relations

Closes #35184

References

Lifecycle policies provides more details on the syntax of the policy JSON.

Output from Acceptance Testing

Note: TestAccECRLifecyclePolicy_detectTagPatternListDiff is a new test case.

$ make testacc TESTS=TestAccECRLifecyclePolicy_ PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRLifecyclePolicy_'  -timeout 360m
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== PAUSE TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== CONT  TestAccECRLifecyclePolicy_basic
=== CONT  TestAccECRLifecyclePolicy_detectDiff
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
=== CONT  TestAccECRLifecyclePolicy_detectTagPatternListDiff
--- PASS: TestAccECRLifecyclePolicy_basic (80.98s)
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (101.03s)
--- PASS: TestAccECRLifecyclePolicy_detectDiff (101.06s)
--- PASS: TestAccECRLifecyclePolicy_detectTagPatternListDiff (101.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        101.351s
$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.
This work has been rolled into #36493.

[Luis-3M]

🚀

[github-actions]

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.