Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_rds_certificate #35003

Merged
merged 29 commits into from
Jul 12, 2024
Merged

Conversation

obounaim
Copy link
Contributor

@obounaim obounaim commented Dec 20, 2023

Description

Provides a resource to override the system-default Secure Sockets Layer/Transport Layer Security (SSL/TLS) certificate for Amazon RDS for new DB instances in the current AWS region.

Relations

Closes #33196

References

AWS RDS CA

Output from Acceptance Testing

make testacc TESTS=TestAccRDSCertificate_Basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCertificate_Basic'  -timeout 360m
=== RUN   TestAccRDSCertificate_Basic
=== PAUSE TestAccRDSCertificate_Basic
=== CONT  TestAccRDSCertificate_Basic
--- PASS: TestAccRDSCertificate_Basic (15.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	15.981s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. generators Relates to code generators. labels Dec 20, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 20, 2023
@obounaim obounaim changed the title [New Resource][WIP]: aws_rds_certificate [New Resource]: aws_rds_certificate Dec 24, 2023
@obounaim obounaim marked this pull request as ready for review December 24, 2023 11:11
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 8, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner July 12, 2024 14:45
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCertificate_serial' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCertificate_serial -timeout 360m
=== RUN   TestAccRDSCertificate_serial
=== PAUSE TestAccRDSCertificate_serial
=== CONT  TestAccRDSCertificate_serial
=== RUN   TestAccRDSCertificate_serial/basic
=== RUN   TestAccRDSCertificate_serial/disappears
--- PASS: TestAccRDSCertificate_serial (26.48s)
    --- PASS: TestAccRDSCertificate_serial/basic (17.61s)
    --- PASS: TestAccRDSCertificate_serial/disappears (8.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	31.485s

@ewbankkit
Copy link
Contributor

@obounaim Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit dd0dfa0 into hashicorp:main Jul 12, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 12, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws rds modify-certificates
4 participants