-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat aws_batch_job_definition
: include arn_prefix
and scheduling_priority
#34997
Feat aws_batch_job_definition
: include arn_prefix
and scheduling_priority
#34997
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBatchJobDefinition_' PKG=batch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 2 -run=TestAccBatchJobDefinition_ -timeout 360m
=== RUN TestAccBatchJobDefinition_basic
=== PAUSE TestAccBatchJobDefinition_basic
=== RUN TestAccBatchJobDefinition_disappears
=== PAUSE TestAccBatchJobDefinition_disappears
=== RUN TestAccBatchJobDefinition_PlatformCapabilities_ec2
=== PAUSE TestAccBatchJobDefinition_PlatformCapabilities_ec2
=== RUN TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
=== PAUSE TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
=== RUN TestAccBatchJobDefinition_PlatformCapabilities_fargate
=== PAUSE TestAccBatchJobDefinition_PlatformCapabilities_fargate
=== RUN TestAccBatchJobDefinition_ContainerProperties_advanced
=== PAUSE TestAccBatchJobDefinition_ContainerProperties_advanced
=== RUN TestAccBatchJobDefinition_updateForcesNewResource
=== PAUSE TestAccBatchJobDefinition_updateForcesNewResource
=== RUN TestAccBatchJobDefinition_tags
=== PAUSE TestAccBatchJobDefinition_tags
=== RUN TestAccBatchJobDefinition_propagateTags
=== PAUSE TestAccBatchJobDefinition_propagateTags
=== RUN TestAccBatchJobDefinition_ContainerProperties_EmptyField
=== PAUSE TestAccBatchJobDefinition_ContainerProperties_EmptyField
=== RUN TestAccBatchJobDefinition_NodeProperties_basic
=== PAUSE TestAccBatchJobDefinition_NodeProperties_basic
=== RUN TestAccBatchJobDefinition_NodePropertiesupdateForcesNewResource
=== PAUSE TestAccBatchJobDefinition_NodePropertiesupdateForcesNewResource
=== RUN TestAccBatchJobDefinition_EKSProperties_basic
=== PAUSE TestAccBatchJobDefinition_EKSProperties_basic
=== RUN TestAccBatchJobDefinition_EKSProperties_update
=== PAUSE TestAccBatchJobDefinition_EKSProperties_update
=== RUN TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
=== PAUSE TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
=== RUN TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
=== PAUSE TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
=== RUN TestAccBatchJobDefinition_schedulingPriority
=== PAUSE TestAccBatchJobDefinition_schedulingPriority
=== CONT TestAccBatchJobDefinition_basic
=== CONT TestAccBatchJobDefinition_ContainerProperties_EmptyField
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (20.98s)
=== CONT TestAccBatchJobDefinition_ContainerProperties_advanced
--- PASS: TestAccBatchJobDefinition_basic (21.00s)
=== CONT TestAccBatchJobDefinition_propagateTags
--- PASS: TestAccBatchJobDefinition_propagateTags (15.30s)
=== CONT TestAccBatchJobDefinition_tags
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (18.74s)
=== CONT TestAccBatchJobDefinition_updateForcesNewResource
--- PASS: TestAccBatchJobDefinition_updateForcesNewResource (31.47s)
=== CONT TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
--- PASS: TestAccBatchJobDefinition_tags (43.03s)
=== CONT TestAccBatchJobDefinition_PlatformCapabilities_fargate
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (19.74s)
=== CONT TestAccBatchJobDefinition_PlatformCapabilities_ec2
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (20.09s)
=== CONT TestAccBatchJobDefinition_EKSProperties_update
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (19.61s)
=== CONT TestAccBatchJobDefinition_schedulingPriority
--- PASS: TestAccBatchJobDefinition_schedulingPriority (23.23s)
=== CONT TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (35.44s)
=== CONT TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (5.47s)
=== CONT TestAccBatchJobDefinition_NodePropertiesupdateForcesNewResource
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (5.29s)
=== CONT TestAccBatchJobDefinition_EKSProperties_basic
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (18.13s)
=== CONT TestAccBatchJobDefinition_NodeProperties_basic
--- PASS: TestAccBatchJobDefinition_NodePropertiesupdateForcesNewResource (32.67s)
=== CONT TestAccBatchJobDefinition_disappears
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (19.39s)
--- PASS: TestAccBatchJobDefinition_disappears (16.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 194.096s
@drewmullen Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #18111
Closes #31226
Relates #34281
References
Output from Acceptance Testing