Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): add port parameter in aws_redshiftserverless_workgroup #34925

Merged
merged 3 commits into from
Dec 29, 2023
Merged

(feat): add port parameter in aws_redshiftserverless_workgroup #34925

merged 3 commits into from
Dec 29, 2023

Conversation

EttoreFoti
Copy link

Description

This adds the capability to define a custom port when creating a redshift workgroup.
The data is then taken from endpoint["port"] as reference.

Relations

Closes #32249

References

Resolve enhancement request #32249

Output from Acceptance Testing

make testacc TESTARGS="-run=TestAccRedshiftServerlessWorkgroup_port\|TestAccRedshiftServerlessWorkgroupDataSource_basic" PKG=redshiftserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20  -run=TestAccRedshiftServerlessWorkgroup_port\|TestAccRedshiftServerlessWorkgroupDataSource_basic -timeout 360m
=== RUN   TestAccRedshiftServerlessWorkgroupDataSource_basic
=== PAUSE TestAccRedshiftServerlessWorkgroupDataSource_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_port
=== PAUSE TestAccRedshiftServerlessWorkgroup_port
=== CONT  TestAccRedshiftServerlessWorkgroupDataSource_basic
=== CONT  TestAccRedshiftServerlessWorkgroup_port
--- PASS: TestAccRedshiftServerlessWorkgroup_port (464.81s)
--- PASS: TestAccRedshiftServerlessWorkgroupDataSource_basic (595.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 597.797s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. labels Dec 14, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 14, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @EttoreFoti 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2023
@nam054
Copy link
Contributor

nam054 commented Dec 29, 2023

LGTM! 🚀 @EttoreFoti Thank you for your contribution!

> make testacc TESTARGS="-run=TestAccRedshiftServerlessWorkgroup_port\|TestAccRedshiftServerlessWorkgroupDataSource_basic" PKG=redshiftserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20  -run=TestAccRedshiftServerlessWorkgroup_port\|TestAccRedshiftServerlessWorkgroupDataSource_basic -timeout 360m
=== RUN   TestAccRedshiftServerlessWorkgroupDataSource_basic
=== PAUSE TestAccRedshiftServerlessWorkgroupDataSource_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_port
=== PAUSE TestAccRedshiftServerlessWorkgroup_port
=== CONT  TestAccRedshiftServerlessWorkgroupDataSource_basic
=== CONT  TestAccRedshiftServerlessWorkgroup_port
--- PASS: TestAccRedshiftServerlessWorkgroup_port (258.70s)
--- PASS: TestAccRedshiftServerlessWorkgroupDataSource_basic (265.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 269.503s

@nam054 nam054 merged commit b3c1440 into hashicorp:main Dec 29, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 29, 2023
@EttoreFoti EttoreFoti deleted the e-redhisft_serverless_custom_ports branch December 29, 2023 11:20
ewbankkit added a commit that referenced this pull request Jan 2, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support custom ports for Redshift Serverless
3 participants