-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_lb: Enable ALB connection logs #34864
Conversation
Community NoteVoting for Prioritization
For Submitters
|
129355c
to
ac57c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccELBV2LoadBalancerDataSource_backwardsCompatibility\|TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs\|TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_LoadBalancerType_gateway' PKG=elbv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2 -run=TestAccELBV2LoadBalancerDataSource_backwardsCompatibility\|TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs\|TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_LoadBalancerType_gateway -timeout 360m
=== RUN TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== RUN TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix
=== CONT TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== CONT TestAccELBV2LoadBalancer_LoadBalancerType_gateway
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (190.93s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (224.84s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix (323.72s)
=== CONT TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs (353.88s)
=== CONT TestAccELBV2LoadBalancer_ALB_basic
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (222.00s)
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (207.84s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 793.371s
@dpirotte Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds Terraform support for Application Load Balancer "Connection Logs", which AWS released alongside mutual TLS support.
Relations
Closes #34668.
References
Output from Acceptance Testing