Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_db_instance add support for Db2 #34834

Merged
merged 24 commits into from
Dec 12, 2023
Merged

Conversation

AdamTylerLynch
Copy link
Collaborator

Description

Adding support for Db2 engine.

Relations

Closes #34688

References

Output from Acceptance Testing

% make testacc PKG=rds TESTS=TestAccRDSInstance_Db2_basic ACCTEST_PARALLELISM=1

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 1 -run='TestAccRDSInstance_Db2_basic'  -timeout 360m
=== RUN   TestAccRDSInstance_Db2_basic
=== PAUSE TestAccRDSInstance_Db2_basic
=== CONT  TestAccRDSInstance_Db2_basic
--- PASS: TestAccRDSInstance_Db2_basic (757.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	760.700s
% make testacc PKG=rds TESTS=TestAccRDSInstance_basic ACCTEST_PARALLELISM=1    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 1 -run='TestAccRDSInstance_basic'  -timeout 360m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (480.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	483.949s

Copy link

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the partner Contribution from a partner. label Dec 8, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_DB2_basic\|TestAccRDSInstance_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSInstance_DB2_basic\|TestAccRDSInstance_basic -timeout 360m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_DB2_basic
    instance_test.go:640: Environment variables RDS_DB2_CUSTOMER_ID and RDS_DB2_SITE_ID are not set
--- SKIP: TestAccRDSInstance_DB2_basic (0.00s)
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (558.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	564.184s

@ewbankkit
Copy link
Contributor

@AdamTylerLynch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 06fdc3e into hashicorp:main Dec 12, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.31.0 milestone Dec 12, 2023
@ewbankkit ewbankkit mentioned this pull request Dec 12, 2023
Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
@justinretzolk justinretzolk added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: RDS IBM Db2 Support
4 participants