-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/aws_db_instance add support for Db2 #34834
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSInstance_DB2_basic\|TestAccRDSInstance_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSInstance_DB2_basic\|TestAccRDSInstance_basic -timeout 360m
=== RUN TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN TestAccRDSInstance_DB2_basic
instance_test.go:640: Environment variables RDS_DB2_CUSTOMER_ID and RDS_DB2_SITE_ID are not set
--- SKIP: TestAccRDSInstance_DB2_basic (0.00s)
=== CONT TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (558.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 564.184s
@AdamTylerLynch Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding support for Db2 engine.
Relations
Closes #34688
References
Output from Acceptance Testing