-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_ssoadmin_application: new resource #34723
Conversation
Community NoteVoting for Prioritization
For Submitters
|
701b6d0
to
ac0a252
Compare
ac0a252
to
11fa7f0
Compare
Hi @jar-b , will your PR include also https://docs.aws.amazon.com/singlesignon/latest/APIReference/API_CreateApplicationAssignment.html ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSSOAdminApplication_' PKG=ssoadmin ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 2 -run=TestAccSSOAdminApplication_ -timeout 360m
=== RUN TestAccSSOAdminApplication_basic
=== PAUSE TestAccSSOAdminApplication_basic
=== RUN TestAccSSOAdminApplication_disappears
=== PAUSE TestAccSSOAdminApplication_disappears
=== RUN TestAccSSOAdminApplication_description
=== PAUSE TestAccSSOAdminApplication_description
=== RUN TestAccSSOAdminApplication_portalOptions
=== PAUSE TestAccSSOAdminApplication_portalOptions
=== RUN TestAccSSOAdminApplication_status
=== PAUSE TestAccSSOAdminApplication_status
=== RUN TestAccSSOAdminApplication_tags
=== PAUSE TestAccSSOAdminApplication_tags
=== CONT TestAccSSOAdminApplication_basic
=== CONT TestAccSSOAdminApplication_portalOptions
--- PASS: TestAccSSOAdminApplication_basic (24.22s)
=== CONT TestAccSSOAdminApplication_tags
--- PASS: TestAccSSOAdminApplication_portalOptions (37.85s)
=== CONT TestAccSSOAdminApplication_description
--- PASS: TestAccSSOAdminApplication_description (35.34s)
=== CONT TestAccSSOAdminApplication_disappears
--- PASS: TestAccSSOAdminApplication_tags (49.39s)
=== CONT TestAccSSOAdminApplication_status
--- PASS: TestAccSSOAdminApplication_disappears (20.41s)
--- PASS: TestAccSSOAdminApplication_status (49.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin 128.783s
@oleksandrsv - Application assignment will be implemented in a separate follow-up PR. |
This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The
aws_ssoadmin_application
resource will allow practitioners to manage customer managed SSO applications with Terraform.Relations
Closes #27853
Relates #28633
References
Output from Acceptance Testing