-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudwatch Logs log classes argument #34679
Add Cloudwatch Logs log classes argument #34679
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLogsGroup_' PKG=logs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2 -run=TestAccLogsGroup_ -timeout 360m
=== RUN TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN TestAccLogsGroup_logGroupClass
=== PAUSE TestAccLogsGroup_logGroupClass
=== RUN TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== CONT TestAccLogsGroup_basic
=== CONT TestAccLogsGroup_kmsKey
--- PASS: TestAccLogsGroup_basic (24.90s)
=== CONT TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (20.81s)
=== CONT TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_skipDestroy (20.23s)
=== CONT TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_kmsKey (66.02s)
=== CONT TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_disappears (18.17s)
=== CONT TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_tags (57.62s)
=== CONT TestAccLogsGroup_logGroupClass
--- PASS: TestAccLogsGroup_retentionPolicy (57.22s)
=== CONT TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroup_logGroupClass (20.25s)
=== CONT TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_namePrefix (24.28s)
--- PASS: TestAccLogsGroup_nameGenerate (23.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 172.689s
@kylewintaur Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the recently announced Cloudwatch Log Group log classes (
STANDARD
orINFREQUENT_ACCESS
).Closes: #34570
References
https://aws.amazon.com/blogs/aws/new-amazon-cloudwatch-log-class-for-infrequent-access-logs-at-a-reduced-price
https://github.com/aws/aws-sdk-go/releases/tag/v1.48.4
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CloudWatch_Logs_Log_Classes.html
Output from Acceptance Testing