S3 Express post-release fixes

[ewbankkit]

Description

Addresses some issues and bugs found during and post release of the Amazon S3 Express functionality.

Relations

Closes #34643.
Relates #34621.
Closes #34659.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3DirectoryBucket_\|TestAccS3Bucket_Basic_basic\|TestAccS3Bucket_disappears' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3DirectoryBucket_\|TestAccS3Bucket_Basic_basic\|TestAccS3Bucket_disappears -timeout 360m
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_disappears
=== PAUSE TestAccS3Bucket_disappears
=== RUN   TestAccS3DirectoryBucket_basic
=== PAUSE TestAccS3DirectoryBucket_basic
=== RUN   TestAccS3DirectoryBucket_disappears
=== PAUSE TestAccS3DirectoryBucket_disappears
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3DirectoryBucket_basic
--- PASS: TestAccS3DirectoryBucket_basic (28.73s)
=== CONT  TestAccS3Bucket_disappears
--- PASS: TestAccS3Bucket_Basic_basic (30.10s)
=== CONT  TestAccS3DirectoryBucket_disappears
--- PASS: TestAccS3DirectoryBucket_disappears (21.94s)
--- PASS: TestAccS3Bucket_disappears (35.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	69.358s

% make testacc TESTARGS='-run=TestAccS3Object_disappears' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3Object_disappears -timeout 360m
=== RUN   TestAccS3Object_disappears
=== PAUSE TestAccS3Object_disappears
=== CONT  TestAccS3Object_disappears
--- PASS: TestAccS3Object_disappears (23.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	28.906s

% make testacc TESTARGS='-run=TestAccS3Object_DirectoryBucket_disappears' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3Object_DirectoryBucket_disappears -timeout 360m
=== RUN   TestAccS3Object_DirectoryBucket_disappears
=== PAUSE TestAccS3Object_DirectoryBucket_disappears
=== CONT  TestAccS3Object_DirectoryBucket_disappears
--- PASS: TestAccS3Object_DirectoryBucket_disappears (24.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	29.402s

% make testacc TESTARGS='-run=TestAccS3Object_Disappears_bucket' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3Object_Disappears_bucket -timeout 360m
=== RUN   TestAccS3Object_Disappears_bucket
=== PAUSE TestAccS3Object_Disappears_bucket
=== CONT  TestAccS3Object_Disappears_bucket
--- PASS: TestAccS3Object_Disappears_bucket (36.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	41.758s

% make testacc TESTARGS='-run=TestAccS3DirectoryBucket_forceDestroy' PKG=s3                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3DirectoryBucket_forceDestroy -timeout 360m
=== RUN   TestAccS3DirectoryBucket_forceDestroy
=== PAUSE TestAccS3DirectoryBucket_forceDestroy
=== CONT  TestAccS3DirectoryBucket_forceDestroy
--- PASS: TestAccS3DirectoryBucket_forceDestroy (25.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	31.574s

% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_forceDestroy' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3Bucket_Basic_forceDestroy -timeout 360m
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroy
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Basic_forceDestroy (41.88s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (46.02s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (39.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	87.302s

% make sweep SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_s3_directory_bucket
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -sweep=us-west-2 -sweep-run=aws_s3_directory_bucket -timeout 360m
2023/11/30 11:45:10 [DEBUG] Running Sweepers for region (us-west-2):
2023/11/30 11:45:10 [DEBUG] Sweeper (aws_s3_directory_bucket) has dependency (aws_s3_object), running..
2023/11/30 11:45:10 [DEBUG] Running Sweeper (aws_s3_object) in region (us-west-2)
2023/11/30 11:45:10 [DEBUG] sweeper: Configuring Terraform AWS Provider: sweeper_region=us-west-2
2023-11-30T11:45:10.447-0500 [DEBUG] sweeper.aws-base: Resolving credentials provider: sweeper_region=us-west-2
2023-11-30T11:45:10.447-0500 [DEBUG] sweeper.aws-base: Loading configuration: sweeper_region=us-west-2
2023-11-30T11:45:10.448-0500 [DEBUG] sweeper.aws-base: Retrieving credentials: sweeper_region=us-west-2
2023-11-30T11:45:10.448-0500 [INFO]  sweeper.aws-base: Retrieved credentials: sweeper_region=us-west-2 tf_aws.credentials_source=EnvConfigCredentials
2023-11-30T11:45:10.448-0500 [DEBUG] sweeper.aws-base: Loading configuration: sweeper_region=us-west-2
2023/11/30 11:45:10 [DEBUG] sweeper: Creating AWS SDK v1 session: sweeper_region=us-west-2
2023/11/30 11:45:10 [DEBUG] sweeper: Retrieving AWS account details: sweeper_region=us-west-2
2023-11-30T11:45:10.448-0500 [DEBUG] sweeper.aws-base: Retrieving caller identity from STS: sweeper_region=us-west-2
2023-11-30T11:45:10.828-0500 [INFO]  sweeper.aws-base: Retrieved caller identity from STS: sweeper_region=us-west-2
...
2023/11/30 11:45:20 [DEBUG] Completed Sweeper (aws_s3_object) in region (us-west-2) in 9.974931386s
2023/11/30 11:45:20 [DEBUG] Running Sweeper (aws_s3_directory_bucket) in region (us-west-2)
2023/11/30 11:45:20 [INFO]  sweeper: Sweeping resource: resource_type=aws_s3_directory_bucket id=tf-acc-002--usw2-az3--x-s3 sweeper_region=us-west-2
2023/11/30 11:45:20 [DEBUG] Waiting for state to become: [success]
2023/11/30 11:45:20 [DEBUG] Completed Sweeper (aws_s3_directory_bucket) in region (us-west-2) in 300.058325ms
2023/11/30 11:45:20 [DEBUG] Sweeper (aws_s3_object) already ran in region (us-west-2)
2023/11/30 11:45:20 Completed Sweepers for region (us-west-2) in 10.2752346s
2023/11/30 11:45:20 Sweeper Tests for region (us-west-2) ran successfully:
2023/11/30 11:45:20 	- aws_s3_object
2023/11/30 11:45:20 	- aws_s3_directory_bucket
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	16.220s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[github-actions]

This functionality has been released in v5.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.