-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lexv2models_bot: support explicit type argument on create and update #34524
Conversation
…pdate Previously, explicitly configured values for the type argument were not sent during create or update operations, resulting in the default `Bot` type in all cases. These operations will now send the type value when set.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLexV2ModelsBot_' PKG=lexv2models ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 2 -run=TestAccLexV2ModelsBot_ -timeout 360m
=== RUN TestAccLexV2ModelsBot_basic
=== PAUSE TestAccLexV2ModelsBot_basic
=== RUN TestAccLexV2ModelsBot_tags
=== PAUSE TestAccLexV2ModelsBot_tags
=== RUN TestAccLexV2ModelsBot_disappears
=== PAUSE TestAccLexV2ModelsBot_disappears
=== RUN TestAccLexV2ModelsBot_type
=== PAUSE TestAccLexV2ModelsBot_type
=== CONT TestAccLexV2ModelsBot_basic
=== CONT TestAccLexV2ModelsBot_disappears
--- PASS: TestAccLexV2ModelsBot_disappears (27.35s)
=== CONT TestAccLexV2ModelsBot_tags
--- PASS: TestAccLexV2ModelsBot_basic (30.22s)
=== CONT TestAccLexV2ModelsBot_type
--- PASS: TestAccLexV2ModelsBot_type (30.27s)
--- PASS: TestAccLexV2ModelsBot_tags (62.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models 95.052s
This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Previously, explicitly configured values for the
type
argument were not sent during create or update operations, resulting in the defaultBot
type in all cases. These operations will now send thetype
value when set.Note: An acceptance test using the
BotNetwork
bot type could not be written at this time, as it is dependent on theaws_lexv2models_bot_alias
resource which is not yet available.Relations
Relates #33475
References
Output from Acceptance Testing