Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate aws_s3_bucket_lifecycle_configuration and aws_s3_bucket_replication_configuration to AWS SDK for Go v2 #34504

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 21, 2023

Description

Following the resolution of aws/aws-sdk-go-v2#2162 we can now migrate aws_s3_bucket_lifecycle_configuration and aws_s3_bucket_replication_configuration to AWS SDK for Go v2.
Migration of aws_s3_bucket will be done after re:Invent.

Relations

Relates #33654.
Relates #32976.
Closes #34518.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3BucketLifecycleConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketLifecycleConfiguration_ -timeout 360m
=== RUN   TestAccS3BucketLifecycleConfiguration_basic
=== PAUSE TestAccS3BucketLifecycleConfiguration_basic
=== RUN   TestAccS3BucketLifecycleConfiguration_disappears
=== PAUSE TestAccS3BucketLifecycleConfiguration_disappears
=== RUN   TestAccS3BucketLifecycleConfiguration_filterWithPrefix
=== PAUSE TestAccS3BucketLifecycleConfiguration_filterWithPrefix
=== RUN   TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan
=== PAUSE TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan
=== RUN   TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero
=== PAUSE TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero
=== RUN   TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan
=== PAUSE TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan
=== RUN   TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange
=== PAUSE TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange
=== RUN   TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix
=== PAUSE TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix
=== RUN   TestAccS3BucketLifecycleConfiguration_disableRule
=== PAUSE TestAccS3BucketLifecycleConfiguration_disableRule
=== RUN   TestAccS3BucketLifecycleConfiguration_multipleRules
=== PAUSE TestAccS3BucketLifecycleConfiguration_multipleRules
=== RUN   TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix
=== PAUSE TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix
=== RUN   TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration
=== PAUSE TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration
=== RUN   TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition
=== PAUSE TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition
=== RUN   TestAccS3BucketLifecycleConfiguration_prefix
=== PAUSE TestAccS3BucketLifecycleConfiguration_prefix
=== RUN   TestAccS3BucketLifecycleConfiguration_Filter_Tag
=== PAUSE TestAccS3BucketLifecycleConfiguration_Filter_Tag
=== RUN   TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly
=== PAUSE TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly
=== RUN   TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock
=== PAUSE TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock
=== RUN   TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload
=== PAUSE TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload
=== RUN   TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa
=== PAUSE TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa
=== RUN   TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering
=== PAUSE TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering
=== RUN   TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering
=== PAUSE TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering
=== RUN   TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering
=== PAUSE TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering
=== RUN   TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering
=== PAUSE TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering
=== RUN   TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions
=== PAUSE TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions
=== RUN   TestAccS3BucketLifecycleConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketLifecycleConfiguration_migrate_noChange
=== RUN   TestAccS3BucketLifecycleConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketLifecycleConfiguration_migrate_withChange
=== RUN   TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix
=== PAUSE TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix
=== CONT  TestAccS3BucketLifecycleConfiguration_basic
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_Tag
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (100.03s)
=== CONT  TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (100.03s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (98.96s)
=== CONT  TestAccS3BucketLifecycleConfiguration_migrate_withChange
--- PASS: TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix (170.78s)
=== CONT  TestAccS3BucketLifecycleConfiguration_migrate_noChange
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_withChange (104.33s)
=== CONT  TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_noChange (103.99s)
=== CONT  TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering
--- PASS: TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions (108.34s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix (97.36s)
=== CONT  TestAccS3BucketLifecycleConfiguration_prefix
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (97.10s)
=== CONT  TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (243.17s)
=== CONT  TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (82.27s)
=== CONT  TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (108.64s)
=== CONT  TestAccS3BucketLifecycleConfiguration_multipleRules
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix (98.28s)
=== CONT  TestAccS3BucketLifecycleConfiguration_disableRule
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (97.97s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero (98.44s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange (97.36s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (263.79s)
=== CONT  TestAccS3BucketLifecycleConfiguration_filterWithPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan (98.05s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan (98.76s)
=== CONT  TestAccS3BucketLifecycleConfiguration_disappears
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (195.06s)
=== CONT  TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (61.97s)
=== CONT  TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (98.48s)
=== CONT  TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (98.31s)
=== CONT  TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (98.26s)
=== CONT  TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (97.84s)
=== CONT  TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (186.10s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (208.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	1667.621s
% make testacc TESTARGS='-run=TestAccS3BucketReplicationConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketReplicationConfiguration_ -timeout 360m
=== RUN   TestAccS3BucketReplicationConfiguration_basic
=== PAUSE TestAccS3BucketReplicationConfiguration_basic
=== RUN   TestAccS3BucketReplicationConfiguration_disappears
=== PAUSE TestAccS3BucketReplicationConfiguration_disappears
=== RUN   TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== RUN   TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter
=== RUN   TestAccS3BucketReplicationConfiguration_twoDestination
=== PAUSE TestAccS3BucketReplicationConfiguration_twoDestination
=== RUN   TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation
=== PAUSE TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation
=== RUN   TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation
=== PAUSE TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation
=== RUN   TestAccS3BucketReplicationConfiguration_replicationTimeControl
=== PAUSE TestAccS3BucketReplicationConfiguration_replicationTimeControl
=== RUN   TestAccS3BucketReplicationConfiguration_replicaModifications
=== PAUSE TestAccS3BucketReplicationConfiguration_replicaModifications
=== RUN   TestAccS3BucketReplicationConfiguration_withoutId
=== PAUSE TestAccS3BucketReplicationConfiguration_withoutId
=== RUN   TestAccS3BucketReplicationConfiguration_withoutStorageClass
=== PAUSE TestAccS3BucketReplicationConfiguration_withoutStorageClass
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
=== RUN   TestAccS3BucketReplicationConfiguration_existingObjectReplication
    bucket_replication_configuration_test.go:767: skipping test: AWS Technical Support request required to allow ExistingObjectReplication
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
=== RUN   TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock
=== RUN   TestAccS3BucketReplicationConfiguration_filter_emptyPrefix
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_emptyPrefix
=== RUN   TestAccS3BucketReplicationConfiguration_filter_tagFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_tagFilter
=== RUN   TestAccS3BucketReplicationConfiguration_filter_andOperator
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_andOperator
=== RUN   TestAccS3BucketReplicationConfiguration_filter_withoutId
=== PAUSE TestAccS3BucketReplicationConfiguration_filter_withoutId
=== RUN   TestAccS3BucketReplicationConfiguration_withoutPrefix
=== PAUSE TestAccS3BucketReplicationConfiguration_withoutPrefix
=== RUN   TestAccS3BucketReplicationConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketReplicationConfiguration_migrate_noChange
=== RUN   TestAccS3BucketReplicationConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketReplicationConfiguration_migrate_withChange
=== CONT  TestAccS3BucketReplicationConfiguration_basic
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (54.31s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_andOperator
--- PASS: TestAccS3BucketReplicationConfiguration_basic (107.95s)
=== CONT  TestAccS3BucketReplicationConfiguration_migrate_withChange
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (74.21s)
=== CONT  TestAccS3BucketReplicationConfiguration_migrate_noChange
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_withChange (60.17s)
=== CONT  TestAccS3BucketReplicationConfiguration_withoutPrefix
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_noChange (60.91s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_withoutId
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (40.23s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock
--- PASS: TestAccS3BucketReplicationConfiguration_filter_withoutId (39.61s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_tagFilter
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock (39.36s)
=== CONT  TestAccS3BucketReplicationConfiguration_filter_emptyPrefix
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (40.14s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyPrefix (39.26s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (39.95s)
=== CONT  TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (49.95s)
=== CONT  TestAccS3BucketReplicationConfiguration_withoutStorageClass
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (39.88s)
=== CONT  TestAccS3BucketReplicationConfiguration_withoutId
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (70.91s)
=== CONT  TestAccS3BucketReplicationConfiguration_replicaModifications
--- PASS: TestAccS3BucketReplicationConfiguration_withoutId (39.80s)
=== CONT  TestAccS3BucketReplicationConfiguration_replicationTimeControl
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (39.85s)
=== CONT  TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (39.68s)
=== CONT  TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (40.13s)
=== CONT  TestAccS3BucketReplicationConfiguration_twoDestination
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (39.47s)
=== CONT  TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (72.31s)
=== CONT  TestAccS3BucketReplicationConfiguration_disappears
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (41.04s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (53.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	588.544s
% make testacc TESTARGS='-run=TestAccS3BucketLogging_' PKG=s3 ACCTEST_PARALLELISM=2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketLogging_ -timeout 360m
=== RUN   TestAccS3BucketLogging_basic
=== PAUSE TestAccS3BucketLogging_basic
=== RUN   TestAccS3BucketLogging_disappears
=== PAUSE TestAccS3BucketLogging_disappears
=== RUN   TestAccS3BucketLogging_update
=== PAUSE TestAccS3BucketLogging_update
=== RUN   TestAccS3BucketLogging_TargetGrantByID
=== PAUSE TestAccS3BucketLogging_TargetGrantByID
=== RUN   TestAccS3BucketLogging_TargetGrantByEmail
    acctest.go:2480: Environment variable AWS_S3_BUCKET_LOGGING_AMAZON_CUSTOMER_BY_EMAIL is not set, skipping test
--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
=== RUN   TestAccS3BucketLogging_TargetGrantByGroup
=== PAUSE TestAccS3BucketLogging_TargetGrantByGroup
=== RUN   TestAccS3BucketLogging_migrate_loggingNoChange
=== PAUSE TestAccS3BucketLogging_migrate_loggingNoChange
=== RUN   TestAccS3BucketLogging_migrate_loggingWithChange
=== PAUSE TestAccS3BucketLogging_migrate_loggingWithChange
=== RUN   TestAccS3BucketLogging_withExpectedBucketOwner
=== PAUSE TestAccS3BucketLogging_withExpectedBucketOwner
=== RUN   TestAccS3BucketLogging_withTargetObjectKeyFormat
=== PAUSE TestAccS3BucketLogging_withTargetObjectKeyFormat
=== CONT  TestAccS3BucketLogging_basic
=== CONT  TestAccS3BucketLogging_migrate_loggingNoChange
--- PASS: TestAccS3BucketLogging_basic (69.71s)
=== CONT  TestAccS3BucketLogging_withExpectedBucketOwner
--- PASS: TestAccS3BucketLogging_migrate_loggingNoChange (88.95s)
=== CONT  TestAccS3BucketLogging_withTargetObjectKeyFormat
--- PASS: TestAccS3BucketLogging_withExpectedBucketOwner (68.87s)
=== CONT  TestAccS3BucketLogging_TargetGrantByID
--- PASS: TestAccS3BucketLogging_withTargetObjectKeyFormat (144.29s)
=== CONT  TestAccS3BucketLogging_TargetGrantByGroup
--- PASS: TestAccS3BucketLogging_TargetGrantByID (125.72s)
=== CONT  TestAccS3BucketLogging_migrate_loggingWithChange
--- PASS: TestAccS3BucketLogging_migrate_loggingWithChange (90.31s)
=== CONT  TestAccS3BucketLogging_update
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (122.03s)
=== CONT  TestAccS3BucketLogging_disappears
--- PASS: TestAccS3BucketLogging_disappears (49.74s)
--- PASS: TestAccS3BucketLogging_update (95.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	455.609s

…replication_configuration` and `aws_s3_bucket_lifecycle_configuration`"

This reverts commit 47f1924.
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Nov 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2023
@ewbankkit ewbankkit changed the title [WIP] Migrate aws_s3_bucket_lifecycle_configuration and aws_s3_bucket_replication_configuration to AWS SDK for Go v2 Migrate aws_s3_bucket_lifecycle_configuration and aws_s3_bucket_replication_configuration to AWS SDK for Go v2 Nov 21, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccS3BucketReplicationConfiguration_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketReplicationConfiguration_ -timeout 360m

--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (1017.72s)
=== CONT  TestAccS3BucketReplicationConfiguration_disappears
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock (1181.45s)
=== CONT  TestAccS3BucketReplicationConfiguration_replicationTimeControl
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyPrefix (1210.01s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (1229.03s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (1244.99s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (1245.49s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (1249.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (1253.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (1253.23s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_withoutId (1262.12s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutId (1279.97s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (1421.04s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (1601.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (1603.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_withChange (1624.25s)
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_noChange (1630.56s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (1799.47s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (829.70s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (715.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (1897.95s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (1938.58s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (2084.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 2088.232s
% make testacc TESTARGS='-run=TestAccS3BucketLifecycleConfiguration_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketLifecycleConfiguration_ -timeout 360m

--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (235.86s)
=== CONT  TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (243.55s)
=== CONT  TestAccS3BucketLifecycleConfiguration_disappears
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (260.88s)
=== CONT  TestAccS3BucketLifecycleConfiguration_filterWithPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_noChange (262.77s)
=== CONT  TestAccS3BucketLifecycleConfiguration_disableRule
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_withChange (262.82s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan
--- PASS: TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions (264.47s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (266.72s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (275.71s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan (284.13s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix (284.35s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (290.34s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (290.46s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix (292.51s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (293.91s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (294.55s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (295.06s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (295.07s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix (387.38s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (156.71s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (417.68s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero (163.85s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange (166.24s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan (168.17s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (507.79s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (291.30s)
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (273.63s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (358.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 624.580s

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 22, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Nov 22, 2023
@ewbankkit ewbankkit merged commit 5e7d6fe into main Nov 22, 2023
92 checks passed
@ewbankkit ewbankkit deleted the td-s3-more-aws-sdk-go-v2 branch November 22, 2023 20:02
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 22, 2023
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon S3 server access logging automatic date-based partitioning
3 participants