-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Data Source]: aws_emr_supported_instance_types
#34481
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
ca2a223
to
25d6709
Compare
Needs a CHANGELOG entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEMRSupportedInstanceTypesDataSource_' PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run=TestAccEMRSupportedInstanceTypesDataSource_ -timeout 360m
=== RUN TestAccEMRSupportedInstanceTypesDataSource_basic
=== PAUSE TestAccEMRSupportedInstanceTypesDataSource_basic
=== CONT TestAccEMRSupportedInstanceTypesDataSource_basic
--- PASS: TestAccEMRSupportedInstanceTypesDataSource_basic (24.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 30.780s
25d6709
to
ec8c6be
Compare
After rebasing with recent dependency upgrades: % make testacc PKG=emr TESTS=TestAccEMRSupportedInstanceTypesDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRSupportedInstanceTypesDataSource_' -timeout 360m
=== RUN TestAccEMRSupportedInstanceTypesDataSource_basic
=== PAUSE TestAccEMRSupportedInstanceTypesDataSource_basic
=== CONT TestAccEMRSupportedInstanceTypesDataSource_basic
--- PASS: TestAccEMRSupportedInstanceTypesDataSource_basic (31.99s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 35.404s |
This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Returns a list of supported instance types for the provided release label (ie.
emr-6.15.0
).Also adds a V2 EMR service client and
flex
flatteners to supportfloat32
builtin type conversions to frameworkFloat64
types.Relations
Closes #34438
Relates #33998
References
Output from Acceptance Testing