Remove readonly properties within replication_settings for aws_dms_replication_config resource

[DanielRieske]

Description

If the replication_settings is set and not computed there will be a perpetual change because certain properties that are returned by the API within this JSON blob cannot be set on creation or modification.

This issue was raised for the same property in the aws_dms_replication_task resource, of which the fix was to remove these properties from the JSON blob.

Relations

Closes #34348.
Closes #31917.
Closes #19801.
Closes #30721.
Closes #30709.
Closes #29765.
Closes #32194.
Closes #31136.

Output from Acceptance Testing

make testacc TESTS=TestAccDMSReplicationConfig_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationConfig_'  -timeout 360m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN   TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_update
=== CONT  TestAccDMSReplicationConfig_tags
=== CONT  TestAccDMSReplicationConfig_disappears
--- PASS: TestAccDMSReplicationConfig_disappears (1610.38s)
--- PASS: TestAccDMSReplicationConfig_update (1616.40s)
--- PASS: TestAccDMSReplicationConfig_basic (1676.35s)
--- PASS: TestAccDMSReplicationConfig_tags (1721.42s)
--- PASS: TestAccDMSReplicationConfig_startReplication (2460.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        2462.915s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_\|TestAccDMSReplicationTaskDataSource_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_\|TestAccDMSReplicationTaskDataSource_ -timeout 720m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN   TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== RUN   TestAccDMSReplicationTaskDataSource_basic
=== PAUSE TestAccDMSReplicationTaskDataSource_basic
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_update
=== PAUSE TestAccDMSReplicationTask_update
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== RUN   TestAccDMSReplicationTask_s3ToRDS
=== PAUSE TestAccDMSReplicationTask_s3ToRDS
=== RUN   TestAccDMSReplicationTask_disappears
=== PAUSE TestAccDMSReplicationTask_disappears
=== RUN   TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== RUN   TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== RUN   TestAccDMSReplicationTask_move
=== PAUSE TestAccDMSReplicationTask_move
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
=== CONT  TestAccDMSReplicationTask_update
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (976.10s)
=== CONT  TestAccDMSReplicationTask_basic
--- PASS: TestAccDMSReplicationConfig_basic (1492.66s)
=== CONT  TestAccDMSReplicationTaskDataSource_basic
--- PASS: TestAccDMSReplicationTask_update (1558.74s)
=== CONT  TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationTask_basic (1005.02s)
=== CONT  TestAccDMSReplicationConfig_update
--- PASS: TestAccDMSReplicationTaskDataSource_basic (1251.08s)
=== CONT  TestAccDMSReplicationConfig_tags
--- PASS: TestAccDMSReplicationConfig_update (1497.88s)
=== CONT  TestAccDMSReplicationConfig_disappears
--- PASS: TestAccDMSReplicationConfig_tags (1600.72s)
=== CONT  TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
--- PASS: TestAccDMSReplicationConfig_startReplication (3122.58s)
=== CONT  TestAccDMSReplicationTask_move
--- PASS: TestAccDMSReplicationConfig_disappears (1528.89s)
=== CONT  TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (982.45s)
=== CONT  TestAccDMSReplicationTask_s3ToRDS
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (950.45s)
=== CONT  TestAccDMSReplicationTask_disappears
--- PASS: TestAccDMSReplicationTask_move (1617.20s)
=== CONT  TestAccDMSReplicationTask_startReplicationTask
--- PASS: TestAccDMSReplicationTask_disappears (937.26s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1651.91s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1945.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	8249.323s

[ewbankkit]

@DanielRieske @misterjacko @jeremychauvet Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.