-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aws_bedrock_model_invocation_logging_configuration resource #34303
add aws_bedrock_model_invocation_logging_configuration resource #34303
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…lock definitions, tidy
…er region settings
…t, refactor flex functions autoflex does not currently support SingleNestedBlock types, but once support is added this is potentially a candidate to be migrated
…ig, use AttrPair checks
Thanks for the tidy up. That use of flex is useful to understand. |
No problem! Working on a couple more testing additions which might not be wrapped today, but should have this merged by Monday at the latest and ready for next weeks release. |
…dle empty result on read
…s, destroy checks
…pears test, serialize
I might need to update my newer PR for the custom_model resource with these fixes. Will take a look once you're done with this. Thanks for the effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=bedrock TESTS=TestAccBedrock_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrock_serial' -timeout 360m
=== RUN TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT TestAccBedrock_serial
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears
--- PASS: TestAccBedrock_serial (428.06s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration (428.06s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic (218.23s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears (209.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrock 431.392s
Thanks for your contribution, @skyscrapr! 👍 |
This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding new Amazon Bedrock resource: "aws_bedrock_model_invocation_logging_configuration"
Relations
closes #33737
References
https://docs.aws.amazon.com/bedrock/latest/APIReference/API_PutModelInvocationLoggingConfiguration.html
Output from Acceptance Testing