r/aws_redshift_cluster: support managed master passwords

[jar-b]

Description

This change adds the manage_master_password and master_password_secret_kms_key_id arguments allowing the configuration of AWS managed credentials via SecretsManager. The manage_master_password argument conflicts with the master_password argument, and at least one must be set when creating a new cluster not restored from a snapshot. The master_password_secret_arn attribute was added to track the ARN of the SecretsManager secret which stores cluster credentials.

Relations

Closes #34169

References

• https://docs.aws.amazon.com/redshift/latest/APIReference/API_Cluster.html
• https://docs.aws.amazon.com/redshift/latest/APIReference/API_CreateCluster.html

Output from Acceptance Testing

%  make testacc PKG=redshift TESTS="TestAccRedshiftCluster_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_'  -timeout 360m

--- PASS: TestAccRedshiftCluster_disappears (368.71s)
=== CONT  TestAccRedshiftCluster_aqua
--- PASS: TestAccRedshiftCluster_manageMasterPassword (387.65s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccRedshiftCluster_basic (391.55s)
=== CONT  TestAccRedshiftCluster_forceNewUsername
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (499.37s)
--- PASS: TestAccRedshiftCluster_snapshotCopy (506.43s)
--- PASS: TestAccRedshiftCluster_iamRoles (515.61s)
--- PASS: TestAccRedshiftCluster_tags (516.56s)
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (552.05s)
--- PASS: TestAccRedshiftCluster_kmsKey (556.19s)
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (556.92s)
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (574.15s)
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (581.81s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (723.83s)
--- PASS: TestAccRedshiftCluster_loggingEnabled (766.36s)
--- PASS: TestAccRedshiftCluster_aqua (415.38s)
--- PASS: TestAccRedshiftCluster_publiclyAccessible (833.06s)
--- PASS: TestAccRedshiftCluster_forceNewUsername (602.32s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (642.96s)
--- PASS: TestAccRedshiftCluster_updateNodeType (1091.19s)
--- PASS: TestAccRedshiftCluster_changeEncryption1 (1115.82s)
--- PASS: TestAccRedshiftCluster_updateNodeCount (1162.75s)
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (1194.38s)
--- PASS: TestAccRedshiftCluster_changeEncryption2 (1346.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   1349.395s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftCluster_manageMasterPassword\|TestAccRedshiftCluster_basic' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftCluster_manageMasterPassword\|TestAccRedshiftCluster_basic -timeout 360m
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== RUN   TestAccRedshiftCluster_manageMasterPassword
=== PAUSE TestAccRedshiftCluster_manageMasterPassword
=== CONT  TestAccRedshiftCluster_basic
=== CONT  TestAccRedshiftCluster_manageMasterPassword
--- PASS: TestAccRedshiftCluster_manageMasterPassword (239.27s)
--- PASS: TestAccRedshiftCluster_basic (253.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   260.471s

[github-actions]

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.