Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/datasource api gateway v2 vpc link #33974

Conversation

hunttom
Copy link
Contributor

@hunttom hunttom commented Oct 17, 2023

Description

Feature request: New data source for API Gateway V2 VPC Link

Relations

Closes #12958

References

AWS API Gateway V2 API Documentation

Output from Acceptance Testing

 % make testacc TESTS=TestAccAPIGatewayV2VPCLinkDataSource PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2VPCLinkDataSource'  -timeout 360m
=== RUN   TestAccAPIGatewayV2VPCLinkDat### Description
Feature request: New data source for API Gateway V2 VPC Link

### Relations
Closes #12958

### References
[AWS API Gateway V2 API Documentation](https://docs.aws.amazon.com/apigatewayv2/latest/api-reference/vpclinks-vpclinkid.html)

### Output from Acceptance Testing
```console
 % make testacc TESTS=TestAccAPIGatewayV2VPCLinkDataSource PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2VPCLinkDataSource'  -timeout 360m
=== RUN   TestAccAPIGatewayV2VPCLinkDataSource
=== PAUSE TestAccAPIGatewayV2VPCLinkDataSource
=== CONT  TestAccAPIGatewayV2VPCLinkDataSource
--- PASS: TestAccAPIGatewayV2VPCLinkDataSource (323.91s)
PASS
...

Source
=== PAUSE TestAccAPIGatewayV2VPCLinkDataSource
=== CONT TestAccAPIGatewayV2VPCLinkDataSource
--- PASS: TestAccAPIGatewayV2VPCLinkDataSource (323.91s)
PASS
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. generators Relates to code generators. labels Oct 17, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 17, 2023
@hunttom hunttom closed this Oct 17, 2023
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label Oct 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @hunttom 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

hunttom pushed a commit to hunttom/terraform-provider-aws that referenced this pull request Oct 17, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New data source: aws_apigatewayv2_vpc_link
2 participants