Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_transfer_server support for increased length login banners #33889

Closed
Alex-Vol-Amz opened this issue Oct 11, 2023 · 4 comments · Fixed by #33937
Closed

[Enhancement]: aws_transfer_server support for increased length login banners #33889

Alex-Vol-Amz opened this issue Oct 11, 2023 · 4 comments · Fixed by #33937
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Milestone

Comments

@Alex-Vol-Amz
Copy link
Contributor

Description

AWS Transfer Family recently increased the length limits for pre_authentication_login_banner and post_authentication_login_banner to support a maximum of 4096 characters instead of the previous limit of 512 characters.

Enhance the current support for login banner to allow 4096 character limit for both pre/post login banner.

Affected Resource(s) and/or Data Source(s)

  • aws_transfer_server

Potential Terraform Configuration

resource "aws_transfer_server" "foo" {
  pre_authentication_login_banner = "This system is for the use of authorized users only."
  ...
}

References

Would you like to implement a fix?

Yes

@Alex-Vol-Amz Alex-Vol-Amz added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 11, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/transfer Issues and PRs that pertain to the transfer service. label Oct 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 11, 2023
@Alex-Vol-Amz
Copy link
Contributor Author

The current documentation still has the 512 value but the API is already published and supporting 4096. Documentation updates lag a couple of days.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 15, 2023
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 16, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Projects
None yet
2 participants