Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set dns_record_type as computed #33743

Merged
merged 4 commits into from
Oct 6, 2023
Merged

fix: set dns_record_type as computed #33743

merged 4 commits into from
Oct 6, 2023

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Oct 3, 2023 •
edited
Loading

Description

Fixes an issue by which not populating dns_record_type causes a diff on future plans/applys.

Relations

Closes #33449

Output from Acceptance Testing

make testacc TESTS=TestAccVPCEndpoint PKG=ec2 ACCTEST_PARALLELISM=5     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccVPCEndpoint'  -timeout 360m
=== RUN   TestAccVPCEndpointConnectionAccepter_crossAccount
    acctest.go:807: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCEndpointConnectionAccepter_crossAccount (0.13s)
=== RUN   TestAccVPCEndpointConnectionNotification_basic
=== PAUSE TestAccVPCEndpointConnectionNotification_basic
=== RUN   TestAccVPCEndpointDataSource_gatewayBasic
=== PAUSE TestAccVPCEndpointDataSource_gatewayBasic
=== RUN   TestAccVPCEndpointDataSource_byID
=== PAUSE TestAccVPCEndpointDataSource_byID
=== RUN   TestAccVPCEndpointDataSource_byFilter
=== PAUSE TestAccVPCEndpointDataSource_byFilter
=== RUN   TestAccVPCEndpointDataSource_byTags
=== PAUSE TestAccVPCEndpointDataSource_byTags
=== RUN   TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== PAUSE TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== RUN   TestAccVPCEndpointDataSource_interface
=== PAUSE TestAccVPCEndpointDataSource_interface
=== RUN   TestAccVPCEndpointPolicy_basic
=== PAUSE TestAccVPCEndpointPolicy_basic
=== RUN   TestAccVPCEndpointPolicy_disappears
=== PAUSE TestAccVPCEndpointPolicy_disappears
=== RUN   TestAccVPCEndpointPolicy_disappears_endpoint
=== PAUSE TestAccVPCEndpointPolicy_disappears_endpoint
=== RUN   TestAccVPCEndpointRouteTableAssociation_basic
=== PAUSE TestAccVPCEndpointRouteTableAssociation_basic
=== RUN   TestAccVPCEndpointRouteTableAssociation_disappears
=== PAUSE TestAccVPCEndpointRouteTableAssociation_disappears
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_basic
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_basic
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_basic
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_multiple
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_multiple
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_tags
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_tags
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_migrateID
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_migrateID
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag
=== RUN   TestAccVPCEndpointServiceDataSource_gateway
=== PAUSE TestAccVPCEndpointServiceDataSource_gateway
=== RUN   TestAccVPCEndpointServiceDataSource_interface
=== PAUSE TestAccVPCEndpointServiceDataSource_interface
=== RUN   TestAccVPCEndpointServiceDataSource_custom
=== PAUSE TestAccVPCEndpointServiceDataSource_custom
=== RUN   TestAccVPCEndpointServiceDataSource_Custom_filter
=== PAUSE TestAccVPCEndpointServiceDataSource_Custom_filter
=== RUN   TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== PAUSE TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== RUN   TestAccVPCEndpointServiceDataSource_ServiceType_gateway
=== PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_gateway
=== RUN   TestAccVPCEndpointServiceDataSource_ServiceType_interface
=== PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_interface
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN   TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN   TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN   TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN   TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN   TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN   TestAccVPCEndpointSubnetAssociation_basic
=== PAUSE TestAccVPCEndpointSubnetAssociation_basic
=== RUN   TestAccVPCEndpointSubnetAssociation_disappears
=== PAUSE TestAccVPCEndpointSubnetAssociation_disappears
=== RUN   TestAccVPCEndpointSubnetAssociation_multiple
=== PAUSE TestAccVPCEndpointSubnetAssociation_multiple
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpointConnectionNotification_basic
=== CONT  TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_multiple
=== CONT  TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_multiple (112.67s)
=== CONT  TestAccVPCEndpoint_interfaceBasic
=== NAME  TestAccVPCEndpointConnectionNotification_basic
    vpc_endpoint_connection_notification_test.go:26: Step 1/3 error: Error running apply: exit status 1
        
        Error: modifying EC2 VPC Endpoint Service (vpce-svc-028fcd207e20885d3) permissions: InvalidPrincipal: Invalid Principal: 'arn:aws:sts::xxxxxxxxxxxxx:assumed-role/Admin/xxxxxxxxxxx'
                status code: 400, request id: 6e0082db-57b4-4ec9-9a4f-539a8a5e22d8
        
          with aws_vpc_endpoint_service.test,
          on terraform_plugin_test.tf line 47, in resource "aws_vpc_endpoint_service" "test":
          47: resource "aws_vpc_endpoint_service" "test" {
        
--- PASS: TestAccVPCEndpoint_interfaceBasic (66.38s)
=== CONT  TestAccVPCEndpoint_gatewayBasic
--- PASS: TestAccVPCEndpoint_gatewayBasic (27.13s)
=== CONT  TestAccVPCEndpointSubnetAssociation_multiple
--- FAIL: TestAccVPCEndpointConnectionNotification_basic (220.45s)
=== CONT  TestAccVPCEndpointSubnetAssociation_disappears
--- PASS: TestAccVPCEndpointService_basic (255.66s)
=== CONT  TestAccVPCEndpointSubnetAssociation_basic
--- PASS: TestAccVPCEndpointService_privateDNSName (256.31s)
=== CONT  TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (413.92s)
=== CONT  TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointSubnetAssociation_disappears (196.85s)
=== CONT  TestAccVPCEndpointService_allowedPrincipals
--- PASS: TestAccVPCEndpointSubnetAssociation_basic (178.93s)
=== CONT  TestAccVPCEndpointPolicy_basic
--- PASS: TestAccVPCEndpointPolicy_basic (53.93s)
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (264.30s)
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_basic
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_disappears (42.98s)
=== CONT  TestAccVPCEndpointRouteTableAssociation_disappears
--- PASS: TestAccVPCEndpointRouteTableAssociation_disappears (25.89s)
=== CONT  TestAccVPCEndpointRouteTableAssociation_basic
--- PASS: TestAccVPCEndpointRouteTableAssociation_basic (26.38s)
=== CONT  TestAccVPCEndpointPolicy_disappears_endpoint
--- PASS: TestAccVPCEndpointPolicy_disappears_endpoint (29.68s)
=== CONT  TestAccVPCEndpointPolicy_disappears
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_basic (95.08s)
=== CONT  TestAccVPCEndpointDataSource_byID
--- PASS: TestAccVPCEndpointDataSource_byID (25.30s)
=== CONT  TestAccVPCEndpointDataSource_byFilter
--- PASS: TestAccVPCEndpointPolicy_disappears (40.41s)
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
--- PASS: TestAccVPCEndpointService_allowedPrincipals (239.76s)
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
--- PASS: TestAccVPCEndpointDataSource_byFilter (25.89s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (31.93s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccVPCEndpointSubnetAssociation_multiple (505.34s)
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (375.34s)
=== CONT  TestAccVPCEndpoint_ipAddressType
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (257.82s)
=== CONT  TestAccVPCEndpointDataSource_byTags
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (279.10s)
=== CONT  TestAccVPCEndpointDataSource_interface
--- PASS: TestAccVPCEndpointDataSource_byTags (25.59s)
=== CONT  TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (26.76s)
=== CONT  TestAccVPCEndpointDataSource_gatewayBasic
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (292.78s)
=== CONT  TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (25.58s)
=== CONT  TestAccVPCEndpointServiceDataSource_gateway
--- PASS: TestAccVPCEndpointServiceDataSource_gateway (9.59s)
=== CONT  TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpointDataSource_interface (129.08s)
=== CONT  TestAccVPCEndpointServiceDataSource_ServiceType_interface
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_interface (9.65s)
=== CONT  TestAccVPCEndpoint_tags
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (431.97s)
=== CONT  TestAccVPCEndpointServiceDataSource_ServiceType_gateway
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_gateway (9.60s)
=== CONT  TestAccVPCEndpoint_gatewayPolicy
--- PASS: TestAccVPCEndpoint_ipAddressType (339.91s)
=== CONT  TestAccVPCEndpointServiceDataSource_CustomFilter_tags
--- PASS: TestAccVPCEndpoint_tags (47.22s)
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccVPCEndpoint_gatewayPolicy (42.94s)
=== CONT  TestAccVPCEndpointServiceDataSource_Custom_filter
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (43.05s)
=== CONT  TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_tags (237.17s)
=== CONT  TestAccVPCEndpointServiceDataSource_custom
--- PASS: TestAccVPCEndpointServiceDataSource_CustomFilter_tags (222.21s)
=== CONT  TestAccVPCEndpoint_disappears
--- PASS: TestAccVPCEndpointServiceDataSource_Custom_filter (211.86s)
=== CONT  TestAccVPCEndpointServiceDataSource_interface
--- PASS: TestAccVPCEndpointServiceDataSource_interface (9.39s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_tags
--- PASS: TestAccVPCEndpoint_disappears (23.66s)
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
--- PASS: TestAccVPCEndpointService_disappears (234.51s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (423.60s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_basic
--- PASS: TestAccVPCEndpointServiceDataSource_custom (233.92s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_migrateID
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_tags (215.46s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_multiple
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag (249.63s)
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_basic (224.43s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateID (227.24s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (75.44s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (367.71s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_multiple (224.70s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1806.610s
FAIL
make: *** [testacc] Error 1

...

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/vpc Issues and PRs that pertain to the vpc service. labels Oct 3, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 3, 2023
@silvaalbert silvaalbert marked this pull request as ready for review October 3, 2023 18:12
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Oct 5, 2023
@ewbankkit
Copy link
Contributor

Before the fix:

% make testacc TESTARGS='-run=TestAccVPCEndpoint_interfacePrivateDNS' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpoint_interfacePrivateDNS -timeout 360m
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== NAME  TestAccVPCEndpoint_interfacePrivateDNS
    vpc_endpoint_test.go:116: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_vpc_endpoint.test will be updated in-place
          ~ resource "aws_vpc_endpoint" "test" {
                id                    = "vpce-041ae40640f6672f6"
                tags                  = {
                    "Name" = "tf-acc-test-2880937972856114453"
                }
                # (18 unchanged attributes hidden)
        
              ~ dns_options {
                  - dns_record_ip_type                             = "ipv4" -> null
                    # (1 unchanged attribute hidden)
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccVPCEndpoint_interfacePrivateDNS (352.10s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (417.54s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	423.506s
FAIL
make: *** [testacc] Error 1

ewbankkit
ewbankkit approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpoint_interfacePrivateDNS' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpoint_interfacePrivateDNS -timeout 360m
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (428.07s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (566.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	571.499s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a9878c3 into hashicorp:main Oct 6, 2023
34 checks passed
@github-actions github-actions bot added this to the v5.20.0 milestone Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.20.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_vpc_endpoint dns_options.dns_record_ip_type shows diff when default value is used
2 participants
@silvaalbert @ewbankkit