Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add json attribute to patch baseline resource #33565

Closed
sbkg0002 opened this issue Sep 21, 2023 · 3 comments · Fixed by #33402
Closed

[Enhancement]: Add json attribute to patch baseline resource #33565

sbkg0002 opened this issue Sep 21, 2023 · 3 comments · Fixed by #33402
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@sbkg0002
Copy link

Description

We would like to use custom SSM patching baselines. Since this needs to be references as a json object on S3, having the aws_ssm_patch_baseline resource outputting it in this format makes development much easier.

Affected Resource(s) and/or Data Source(s)

  • aws_ssm_patch_baseline

Potential Terraform Configuration

resource "aws_ssm_patch_baseline" "production" {
  name             = "patch-baseline"
  approved_patches = ["KB123456"]
}

resource "aws_s3_object" "object" {
  bucket  = "test_bucket_name"
  content = aws_ssm_patch_baseline.production.json
  key     = "baseline_policy_as.json"
}

References

This PR seems to add this functionality #33402

Would you like to implement a fix?

Yes

@sbkg0002 sbkg0002 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 21, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. service/ssm Issues and PRs that pertain to the ssm service. labels Sep 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 21, 2023
@ewbankkit ewbankkit removed service/s3 Issues and PRs that pertain to the s3 service. needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2023
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 20, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants