-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecs/account_setting_default: Remove validation on value
value
#33393
ecs/account_setting_default: Remove validation on value
value
#33393
Conversation
Community NoteVoting for Prioritization
For Submitters
|
This is likely to become a big deal for many customers because AWS has been proactively sending emails notifying customers about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSAccountSettingDefault_serial' PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSAccountSettingDefault_serial -timeout 360m
=== RUN TestAccECSAccountSettingDefault_serial
=== PAUSE TestAccECSAccountSettingDefault_serial
=== CONT TestAccECSAccountSettingDefault_serial
=== RUN TestAccECSAccountSettingDefault_serial/serviceLongARNFormat
=== RUN TestAccECSAccountSettingDefault_serial/taskLongARNFormat
=== RUN TestAccECSAccountSettingDefault_serial/vpcTrunking
=== RUN TestAccECSAccountSettingDefault_serial/containerInsights
=== RUN TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat
--- PASS: TestAccECSAccountSettingDefault_serial (92.10s)
--- PASS: TestAccECSAccountSettingDefault_serial/serviceLongARNFormat (19.12s)
--- PASS: TestAccECSAccountSettingDefault_serial/taskLongARNFormat (18.23s)
--- PASS: TestAccECSAccountSettingDefault_serial/vpcTrunking (18.21s)
--- PASS: TestAccECSAccountSettingDefault_serial/containerInsights (17.88s)
--- PASS: TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat (18.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 103.417s
@eagletmt Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
ECS account settings can have values other than
enabled
/disabled
.tagResourceAuthorization
can haveon
/off
, and recently-introducedfargateTaskRetirementWaitPeriod
can have0
/7
/14
.So this pull-request removes valudation on
value
value ofaws_ecs_account_setting_default
.Relations
Closes #32114
References
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-account-settings.html
Output from Acceptance Testing