Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs/account_setting_default: Remove validation on value value #33393

Merged

Conversation

eagletmt
Copy link
Contributor

Description

ECS account settings can have values other than enabled / disabled . tagResourceAuthorization can have on / off, and recently-introduced fargateTaskRetirementWaitPeriod can have 0 / 7 / 14.
So this pull-request removes valudation on value value of aws_ecs_account_setting_default.

Relations

Closes #32114

References

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-account-settings.html

Output from Acceptance Testing

% make testacc TESTS=TestAccECSAccountSettingDefault PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSAccountSettingDefault'  -timeout 180m
=== RUN   TestAccECSAccountSettingDefault_containerInstanceLongARNFormat
=== PAUSE TestAccECSAccountSettingDefault_containerInstanceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serviceLongARNFormat
=== PAUSE TestAccECSAccountSettingDefault_serviceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_taskLongARNFormat
=== PAUSE TestAccECSAccountSettingDefault_taskLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_vpcTrunking
=== PAUSE TestAccECSAccountSettingDefault_vpcTrunking
=== RUN   TestAccECSAccountSettingDefault_containerInsights
=== PAUSE TestAccECSAccountSettingDefault_containerInsights
=== CONT  TestAccECSAccountSettingDefault_containerInstanceLongARNFormat
=== CONT  TestAccECSAccountSettingDefault_vpcTrunking
=== CONT  TestAccECSAccountSettingDefault_containerInsights
=== CONT  TestAccECSAccountSettingDefault_taskLongARNFormat
=== CONT  TestAccECSAccountSettingDefault_serviceLongARNFormat
--- PASS: TestAccECSAccountSettingDefault_containerInsights (34.25s)
--- PASS: TestAccECSAccountSettingDefault_serviceLongARNFormat (34.25s)
--- PASS: TestAccECSAccountSettingDefault_containerInstanceLongARNFormat (34.26s)
--- PASS: TestAccECSAccountSettingDefault_vpcTrunking (34.26s)
--- PASS: TestAccECSAccountSettingDefault_taskLongARNFormat (34.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        34.342s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. labels Sep 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 11, 2023
@acdha
Copy link
Contributor

acdha commented Sep 11, 2023

This is likely to become a big deal for many customers because AWS has been proactively sending emails notifying customers about the fargateTaskRetirementWaitPeriod setting and suggesting changing it.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 11, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSAccountSettingDefault_serial' PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSAccountSettingDefault_serial -timeout 360m
=== RUN   TestAccECSAccountSettingDefault_serial
=== PAUSE TestAccECSAccountSettingDefault_serial
=== CONT  TestAccECSAccountSettingDefault_serial
=== RUN   TestAccECSAccountSettingDefault_serial/serviceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/taskLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/vpcTrunking
=== RUN   TestAccECSAccountSettingDefault_serial/containerInsights
=== RUN   TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat
--- PASS: TestAccECSAccountSettingDefault_serial (92.10s)
    --- PASS: TestAccECSAccountSettingDefault_serial/serviceLongARNFormat (19.12s)
    --- PASS: TestAccECSAccountSettingDefault_serial/taskLongARNFormat (18.23s)
    --- PASS: TestAccECSAccountSettingDefault_serial/vpcTrunking (18.21s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInsights (17.88s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat (18.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	103.417s

@ewbankkit
Copy link
Contributor

@eagletmt Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 34fb0e8 into hashicorp:main Feb 12, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 12, 2024
@eagletmt eagletmt deleted the b-ecs-account-setting-value-no-validation branch February 13, 2024 05:28
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_ecs_account_setting_default: InvalidParameterException: Invalid setting 'value'
4 participants