r/aws_s3_object: Migrate to AWS SDK for Go v2 #33358

ewbankkit · 2023-09-07T19:43:32Z

Description

Migrates the aws_s3_object resource and data source to AWS SDK for Go v2.
Migrates the aws_s3_object_copy resource's Delete functionality to AWS SDK for Go v2.

Relations

Closes #28541.
Closes #27370.
Closes #23901.
Relates #33330.
Relates #33304.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3ObjectCopy_ -timeout 180m
=== RUN   TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== RUN   TestAccS3ObjectCopy_disappears
=== PAUSE TestAccS3ObjectCopy_disappears
=== RUN   TestAccS3ObjectCopy_tags
=== PAUSE TestAccS3ObjectCopy_tags
=== RUN   TestAccS3ObjectCopy_metadata
=== PAUSE TestAccS3ObjectCopy_metadata
=== RUN   TestAccS3ObjectCopy_grant
=== PAUSE TestAccS3ObjectCopy_grant
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_object
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object
=== RUN   TestAccS3ObjectCopy_sourceWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceWithSlashes
=== RUN   TestAccS3ObjectCopy_checksumAlgorithm
=== PAUSE TestAccS3ObjectCopy_checksumAlgorithm
=== RUN   TestAccS3ObjectCopy_objectLockLegalHold
=== PAUSE TestAccS3ObjectCopy_objectLockLegalHold
=== RUN   TestAccS3ObjectCopy_targetWithMultipleSlashes
=== PAUSE TestAccS3ObjectCopy_targetWithMultipleSlashes
=== RUN   TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
=== PAUSE TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
=== CONT  TestAccS3ObjectCopy_basic
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_object
=== CONT  TestAccS3ObjectCopy_metadata
--- PASS: TestAccS3ObjectCopy_basic (35.69s)
=== CONT  TestAccS3ObjectCopy_objectLockLegalHold
--- PASS: TestAccS3ObjectCopy_metadata (36.18s)
=== CONT  TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (36.27s)
=== CONT  TestAccS3ObjectCopy_targetWithMultipleSlashes
--- PASS: TestAccS3ObjectCopy_targetWithMultipleSlashes (31.51s)
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_bucket
--- PASS: TestAccS3ObjectCopy_objectLockLegalHold (62.17s)
=== CONT  TestAccS3ObjectCopy_checksumAlgorithm
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (32.30s)
=== CONT  TestAccS3ObjectCopy_grant
--- PASS: TestAccS3ObjectCopy_grant (30.83s)
=== CONT  TestAccS3ObjectCopy_tags
--- PASS: TestAccS3ObjectCopy_checksumAlgorithm (54.27s)
=== CONT  TestAccS3ObjectCopy_sourceWithSlashes
--- PASS: TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated (122.31s)
=== CONT  TestAccS3ObjectCopy_disappears
--- PASS: TestAccS3ObjectCopy_disappears (35.41s)
--- PASS: TestAccS3ObjectCopy_sourceWithSlashes (57.83s)
--- PASS: TestAccS3ObjectCopy_tags (83.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	219.296s

% make testacc TESTARGS='-run=TestAccS3Object_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3Object_ -timeout 180m
=== RUN   TestAccS3Object_basic
=== PAUSE TestAccS3Object_basic
=== RUN   TestAccS3Object_upgradeFromV4
=== PAUSE TestAccS3Object_upgradeFromV4
=== RUN   TestAccS3Object_source
=== PAUSE TestAccS3Object_source
=== RUN   TestAccS3Object_content
=== PAUSE TestAccS3Object_content
=== RUN   TestAccS3Object_etagEncryption
=== PAUSE TestAccS3Object_etagEncryption
=== RUN   TestAccS3Object_contentBase64
=== PAUSE TestAccS3Object_contentBase64
=== RUN   TestAccS3Object_sourceHashTrigger
=== PAUSE TestAccS3Object_sourceHashTrigger
=== RUN   TestAccS3Object_withContentCharacteristics
=== PAUSE TestAccS3Object_withContentCharacteristics
=== RUN   TestAccS3Object_nonVersioned
=== PAUSE TestAccS3Object_nonVersioned
=== RUN   TestAccS3Object_updates
=== PAUSE TestAccS3Object_updates
=== RUN   TestAccS3Object_updateSameFile
=== PAUSE TestAccS3Object_updateSameFile
=== RUN   TestAccS3Object_updatesWithVersioning
=== PAUSE TestAccS3Object_updatesWithVersioning
=== RUN   TestAccS3Object_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccS3Object_updatesWithVersioningViaAccessPoint
=== RUN   TestAccS3Object_kms
=== PAUSE TestAccS3Object_kms
=== RUN   TestAccS3Object_sse
=== PAUSE TestAccS3Object_sse
=== RUN   TestAccS3Object_acl
=== PAUSE TestAccS3Object_acl
=== RUN   TestAccS3Object_metadata
=== PAUSE TestAccS3Object_metadata
=== RUN   TestAccS3Object_storageClass
=== PAUSE TestAccS3Object_storageClass
=== RUN   TestAccS3Object_tags
=== PAUSE TestAccS3Object_tags
=== RUN   TestAccS3Object_tagsLeadingSingleSlash
=== PAUSE TestAccS3Object_tagsLeadingSingleSlash
=== RUN   TestAccS3Object_tagsLeadingMultipleSlashes
=== PAUSE TestAccS3Object_tagsLeadingMultipleSlashes
=== RUN   TestAccS3Object_tagsMultipleSlashes
=== PAUSE TestAccS3Object_tagsMultipleSlashes
=== RUN   TestAccS3Object_objectLockLegalHoldStartWithNone
=== PAUSE TestAccS3Object_objectLockLegalHoldStartWithNone
=== RUN   TestAccS3Object_objectLockLegalHoldStartWithOn
=== PAUSE TestAccS3Object_objectLockLegalHoldStartWithOn
=== RUN   TestAccS3Object_objectLockRetentionStartWithNone
=== PAUSE TestAccS3Object_objectLockRetentionStartWithNone
=== RUN   TestAccS3Object_objectLockRetentionStartWithSet
=== PAUSE TestAccS3Object_objectLockRetentionStartWithSet
=== RUN   TestAccS3Object_objectBucketKeyEnabled
=== PAUSE TestAccS3Object_objectBucketKeyEnabled
=== RUN   TestAccS3Object_bucketBucketKeyEnabled
=== PAUSE TestAccS3Object_bucketBucketKeyEnabled
=== RUN   TestAccS3Object_defaultBucketSSE
=== PAUSE TestAccS3Object_defaultBucketSSE
=== RUN   TestAccS3Object_ignoreTags
=== PAUSE TestAccS3Object_ignoreTags
=== RUN   TestAccS3Object_checksumAlgorithm
=== PAUSE TestAccS3Object_checksumAlgorithm
=== RUN   TestAccS3Object_keyWithSlashesMigrated
=== PAUSE TestAccS3Object_keyWithSlashesMigrated
=== CONT  TestAccS3Object_basic
=== CONT  TestAccS3Object_metadata
=== CONT  TestAccS3Object_objectLockRetentionStartWithNone
--- PASS: TestAccS3Object_basic (33.76s)
=== CONT  TestAccS3Object_keyWithSlashesMigrated
--- PASS: TestAccS3Object_metadata (77.59s)
=== CONT  TestAccS3Object_checksumAlgorithm
--- PASS: TestAccS3Object_objectLockRetentionStartWithNone (84.78s)
=== CONT  TestAccS3Object_ignoreTags
--- PASS: TestAccS3Object_keyWithSlashesMigrated (88.10s)
=== CONT  TestAccS3Object_defaultBucketSSE
--- PASS: TestAccS3Object_checksumAlgorithm (55.77s)
=== CONT  TestAccS3Object_bucketBucketKeyEnabled
--- PASS: TestAccS3Object_ignoreTags (60.84s)
=== CONT  TestAccS3Object_objectBucketKeyEnabled
--- PASS: TestAccS3Object_defaultBucketSSE (31.46s)
=== CONT  TestAccS3Object_objectLockRetentionStartWithSet
--- PASS: TestAccS3Object_bucketBucketKeyEnabled (30.85s)
=== CONT  TestAccS3Object_tagsLeadingMultipleSlashes
--- PASS: TestAccS3Object_objectBucketKeyEnabled (29.55s)
=== CONT  TestAccS3Object_objectLockLegalHoldStartWithOn
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithOn (57.64s)
=== CONT  TestAccS3Object_objectLockLegalHoldStartWithNone
--- PASS: TestAccS3Object_objectLockRetentionStartWithSet (111.16s)
=== CONT  TestAccS3Object_tagsMultipleSlashes
--- PASS: TestAccS3Object_tagsLeadingMultipleSlashes (111.68s)
=== CONT  TestAccS3Object_tags
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithNone (86.24s)
=== CONT  TestAccS3Object_tagsLeadingSingleSlash
--- PASS: TestAccS3Object_tagsMultipleSlashes (114.27s)
=== CONT  TestAccS3Object_updatesWithVersioningViaAccessPoint
--- PASS: TestAccS3Object_tags (118.60s)
=== CONT  TestAccS3Object_acl
--- PASS: TestAccS3Object_tagsLeadingSingleSlash (115.49s)
=== CONT  TestAccS3Object_sse
--- PASS: TestAccS3Object_updatesWithVersioningViaAccessPoint (60.27s)
=== CONT  TestAccS3Object_kms
--- PASS: TestAccS3Object_sse (35.29s)
=== CONT  TestAccS3Object_etagEncryption
--- PASS: TestAccS3Object_kms (35.48s)
=== CONT  TestAccS3Object_withContentCharacteristics
--- PASS: TestAccS3Object_acl (93.05s)
=== CONT  TestAccS3Object_sourceHashTrigger
--- PASS: TestAccS3Object_etagEncryption (35.19s)
=== CONT  TestAccS3Object_contentBase64
--- PASS: TestAccS3Object_withContentCharacteristics (30.58s)
=== CONT  TestAccS3Object_source
--- PASS: TestAccS3Object_contentBase64 (30.87s)
=== CONT  TestAccS3Object_nonVersioned
    acctest.go:1604: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccS3Object_nonVersioned (0.00s)
=== CONT  TestAccS3Object_updatesWithVersioning
--- PASS: TestAccS3Object_source (35.54s)
=== CONT  TestAccS3Object_updateSameFile
--- PASS: TestAccS3Object_sourceHashTrigger (60.89s)
=== CONT  TestAccS3Object_updates
--- PASS: TestAccS3Object_updatesWithVersioning (61.58s)
=== CONT  TestAccS3Object_content
--- PASS: TestAccS3Object_updateSameFile (59.03s)
=== CONT  TestAccS3Object_storageClass
--- PASS: TestAccS3Object_updates (62.77s)
=== CONT  TestAccS3Object_upgradeFromV4
--- PASS: TestAccS3Object_content (33.20s)
--- PASS: TestAccS3Object_upgradeFromV4 (83.10s)
--- PASS: TestAccS3Object_storageClass (117.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	722.434s

% make testacc TESTARGS='-run=TestAccS3ObjectDataSource_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3ObjectDataSource_ -timeout 180m
=== RUN   TestAccS3ObjectDataSource_basic
=== PAUSE TestAccS3ObjectDataSource_basic
=== RUN   TestAccS3ObjectDataSource_basicViaAccessPoint
=== PAUSE TestAccS3ObjectDataSource_basicViaAccessPoint
=== RUN   TestAccS3ObjectDataSource_readableBody
=== PAUSE TestAccS3ObjectDataSource_readableBody
=== RUN   TestAccS3ObjectDataSource_kmsEncrypted
=== PAUSE TestAccS3ObjectDataSource_kmsEncrypted
=== RUN   TestAccS3ObjectDataSource_bucketKeyEnabled
=== PAUSE TestAccS3ObjectDataSource_bucketKeyEnabled
=== RUN   TestAccS3ObjectDataSource_allParams
=== PAUSE TestAccS3ObjectDataSource_allParams
=== RUN   TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== RUN   TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== RUN   TestAccS3ObjectDataSource_leadingSlash
=== PAUSE TestAccS3ObjectDataSource_leadingSlash
=== RUN   TestAccS3ObjectDataSource_multipleSlashes
=== PAUSE TestAccS3ObjectDataSource_multipleSlashes
=== RUN   TestAccS3ObjectDataSource_singleSlashAsKey
=== PAUSE TestAccS3ObjectDataSource_singleSlashAsKey
=== RUN   TestAccS3ObjectDataSource_checksumMode
=== PAUSE TestAccS3ObjectDataSource_checksumMode
=== CONT  TestAccS3ObjectDataSource_basic
=== CONT  TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== CONT  TestAccS3ObjectDataSource_kmsEncrypted
--- PASS: TestAccS3ObjectDataSource_basic (29.02s)
=== CONT  TestAccS3ObjectDataSource_readableBody
--- PASS: TestAccS3ObjectDataSource_kmsEncrypted (29.71s)
=== CONT  TestAccS3ObjectDataSource_allParams
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOff (32.95s)
=== CONT  TestAccS3ObjectDataSource_bucketKeyEnabled
--- PASS: TestAccS3ObjectDataSource_readableBody (28.65s)
=== CONT  TestAccS3ObjectDataSource_basicViaAccessPoint
--- PASS: TestAccS3ObjectDataSource_bucketKeyEnabled (29.35s)
=== CONT  TestAccS3ObjectDataSource_multipleSlashes
--- PASS: TestAccS3ObjectDataSource_allParams (33.10s)
=== CONT  TestAccS3ObjectDataSource_checksumMode
--- PASS: TestAccS3ObjectDataSource_basicViaAccessPoint (29.29s)
=== CONT  TestAccS3ObjectDataSource_singleSlashAsKey
--- PASS: TestAccS3ObjectDataSource_checksumMode (28.50s)
=== CONT  TestAccS3ObjectDataSource_leadingSlash
--- PASS: TestAccS3ObjectDataSource_singleSlashAsKey (14.84s)
=== CONT  TestAccS3ObjectDataSource_objectLockLegalHoldOn
--- PASS: TestAccS3ObjectDataSource_multipleSlashes (49.07s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOn (31.20s)
--- PASS: TestAccS3ObjectDataSource_leadingSlash (47.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	143.605s

% make sweep SWEEPARGS=-sweep-run=aws_s3_bucket
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2,us-west-1 -sweep-run=aws_s3_bucket -timeout 60m
2023/09/12 11:05:20 [DEBUG] Running Sweepers for region (us-west-2):
2023/09/12 11:05:20 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:20 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-2)
2023/09/12 11:05:21 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-2) in 964.060204ms
2023/09/12 11:05:21 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-west-2)
2023/09/12 11:05:21 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-west-2) in 99.81154ms
2023/09/12 11:05:21 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-west-2)
2023/09/12 11:05:21 [DEBUG] Running Sweeper (aws_s3_object) in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] No S3 Objects to sweep
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3_object) in region (us-west-2) in 447.669378ms
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-west-2) in 196.377697ms
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_access_point), running..
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_access_point) already ran in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_object), running..
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_object) already ran in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3control_multi_region_access_point), running..
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3control_multi_region_access_point) already ran in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3_bucket) in region (us-west-2)
2023/09/12 11:05:22 [DEBUG] No S3 Buckets to sweep
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3_bucket) in region (us-west-2) in 98.965934ms
2023/09/12 11:05:22 Completed Sweepers for region (us-west-2) in 1.807360143s
2023/09/12 11:05:22 Sweeper Tests for region (us-west-2) ran successfully:
2023/09/12 11:05:22 	- aws_s3control_object_lambda_access_point
2023/09/12 11:05:22 	- aws_s3_access_point
2023/09/12 11:05:22 	- aws_s3_object
2023/09/12 11:05:22 	- aws_s3control_multi_region_access_point
2023/09/12 11:05:22 	- aws_s3_bucket
2023/09/12 11:05:22 [DEBUG] Running Sweepers for region (us-east-1):
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_access_point), running..
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-1) in 290.412389ms
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-east-1) in 30.549945ms
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_object), running..
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3_object) in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] No S3 Objects to sweep
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3_object) in region (us-east-1) in 135.111209ms
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3control_multi_region_access_point), running..
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-east-1)
2023/09/12 11:05:22 [WARN] Skipping S3 Multi-Region Access Point sweep for region: us-east-1
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-east-1) in 29.453µs
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3_bucket) in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] No S3 Buckets to sweep
2023/09/12 11:05:22 [DEBUG] Completed Sweeper (aws_s3_bucket) in region (us-east-1) in 28.983795ms
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_access_point) already ran in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_object) already ran in region (us-east-1)
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3control_multi_region_access_point) already ran in region (us-east-1)
2023/09/12 11:05:22 Completed Sweepers for region (us-east-1) in 485.456418ms
2023/09/12 11:05:22 Sweeper Tests for region (us-east-1) ran successfully:
2023/09/12 11:05:22 	- aws_s3control_object_lambda_access_point
2023/09/12 11:05:22 	- aws_s3_access_point
2023/09/12 11:05:22 	- aws_s3_object
2023/09/12 11:05:22 	- aws_s3control_multi_region_access_point
2023/09/12 11:05:22 	- aws_s3_bucket
2023/09/12 11:05:22 [DEBUG] Running Sweepers for region (us-east-2):
2023/09/12 11:05:22 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:22 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-2) in 414.305844ms
2023/09/12 11:05:23 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-east-2) in 43.872924ms
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Running Sweeper (aws_s3_object) in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] No S3 Objects to sweep
2023/09/12 11:05:23 [DEBUG] Completed Sweeper (aws_s3_object) in region (us-east-2) in 175.541349ms
2023/09/12 11:05:23 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-east-2)
2023/09/12 11:05:23 [WARN] Skipping S3 Multi-Region Access Point sweep for region: us-east-2
2023/09/12 11:05:23 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-east-2) in 7.5µs
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_access_point), running..
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_access_point) already ran in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_object), running..
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_object) already ran in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3control_multi_region_access_point), running..
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3control_multi_region_access_point) already ran in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] Running Sweeper (aws_s3_bucket) in region (us-east-2)
2023/09/12 11:05:23 [DEBUG] No S3 Buckets to sweep
2023/09/12 11:05:23 [DEBUG] Completed Sweeper (aws_s3_bucket) in region (us-east-2) in 61.125898ms
2023/09/12 11:05:23 Completed Sweepers for region (us-east-2) in 695.27701ms
2023/09/12 11:05:23 Sweeper Tests for region (us-east-2) ran successfully:
2023/09/12 11:05:23 	- aws_s3_access_point
2023/09/12 11:05:23 	- aws_s3_object
2023/09/12 11:05:23 	- aws_s3control_multi_region_access_point
2023/09/12 11:05:23 	- aws_s3_bucket
2023/09/12 11:05:23 	- aws_s3control_object_lambda_access_point
2023/09/12 11:05:23 [DEBUG] Running Sweepers for region (us-west-1):
2023/09/12 11:05:23 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-west-1)
2023/09/12 11:05:23 [WARN] Skipping S3 Multi-Region Access Point sweep for region: us-west-1
2023/09/12 11:05:23 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-west-1) in 8.274µs
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_access_point), running..
2023/09/12 11:05:23 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:23 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-1)
2023/09/12 11:05:24 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-1) in 905.161319ms
2023/09/12 11:05:24 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-west-1)
2023/09/12 11:05:24 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-west-1) in 100.683155ms
2023/09/12 11:05:24 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_object), running..
2023/09/12 11:05:24 [DEBUG] Running Sweeper (aws_s3_object) in region (us-west-1)
2023/09/12 11:05:24 [DEBUG] No S3 Objects to sweep
2023/09/12 11:05:24 [DEBUG] Completed Sweeper (aws_s3_object) in region (us-west-1) in 408.866187ms
2023/09/12 11:05:24 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3control_multi_region_access_point), running..
2023/09/12 11:05:24 [DEBUG] Sweeper (aws_s3control_multi_region_access_point) already ran in region (us-west-1)
2023/09/12 11:05:24 [DEBUG] Running Sweeper (aws_s3_bucket) in region (us-west-1)
2023/09/12 11:05:25 [DEBUG] No S3 Buckets to sweep
2023/09/12 11:05:25 [DEBUG] Completed Sweeper (aws_s3_bucket) in region (us-west-1) in 83.777499ms
2023/09/12 11:05:25 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 11:05:25 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-west-1)
2023/09/12 11:05:25 [DEBUG] Sweeper (aws_s3_access_point) already ran in region (us-west-1)
2023/09/12 11:05:25 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-west-1)
2023/09/12 11:05:25 [DEBUG] Sweeper (aws_s3_object) already ran in region (us-west-1)
2023/09/12 11:05:25 Completed Sweepers for region (us-west-1) in 1.498835526s
2023/09/12 11:05:25 Sweeper Tests for region (us-west-1) ran successfully:
2023/09/12 11:05:25 	- aws_s3_access_point
2023/09/12 11:05:25 	- aws_s3_object
2023/09/12 11:05:25 	- aws_s3_bucket
2023/09/12 11:05:25 	- aws_s3control_multi_region_access_point
2023/09/12 11:05:25 	- aws_s3control_object_lambda_access_point
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	9.899s

…&& go mod tidy'.

…ead operations on Amazon S3 Object Tags.

… aren't exposed as nested.

…ite consistency for PUT and DELETE requests of objects.

github-actions · 2023-09-07T19:43:49Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…2`, `checksum_crc32c`, `checksum_sha1` and `checksum_sha256` attributes.

% make testacc TESTARGS='-run=TestAccS3Object_basic' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3Object_basic -timeout 180m === RUN TestAccS3Object_basic === PAUSE TestAccS3Object_basic === CONT TestAccS3Object_basic --- PASS: TestAccS3Object_basic (29.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 35.537s

% make testacc TESTARGS='-run=TestAccS3Object_checksumAlgorithm' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3Object_checksumAlgorithm -timeout 180m === RUN TestAccS3Object_checksumAlgorithm === PAUSE TestAccS3Object_checksumAlgorithm === CONT TestAccS3Object_checksumAlgorithm --- PASS: TestAccS3Object_checksumAlgorithm (47.84s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 53.042s

…_crc32`, `checksum_crc32c`, `checksum_sha1` and `checksum_sha256` attributes.

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_checksumAlgorithm' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3ObjectCopy_checksumAlgorithm -timeout 180m === RUN TestAccS3ObjectCopy_checksumAlgorithm === PAUSE TestAccS3ObjectCopy_checksumAlgorithm === CONT TestAccS3ObjectCopy_checksumAlgorithm --- PASS: TestAccS3ObjectCopy_checksumAlgorithm (48.57s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 53.907s

…on error" This reverts commit e2177f1.

% make testacc TESTARGS='-run=TestAccS3Object_' PKG=s3 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3Object_ -timeout 180m === RUN TestAccS3Object_basic === PAUSE TestAccS3Object_basic === RUN TestAccS3Object_upgradeFromV4 === PAUSE TestAccS3Object_upgradeFromV4 === RUN TestAccS3Object_source === PAUSE TestAccS3Object_source === RUN TestAccS3Object_content === PAUSE TestAccS3Object_content === RUN TestAccS3Object_etagEncryption === PAUSE TestAccS3Object_etagEncryption === RUN TestAccS3Object_contentBase64 === PAUSE TestAccS3Object_contentBase64 === RUN TestAccS3Object_sourceHashTrigger === PAUSE TestAccS3Object_sourceHashTrigger === RUN TestAccS3Object_withContentCharacteristics === PAUSE TestAccS3Object_withContentCharacteristics === RUN TestAccS3Object_nonVersioned === PAUSE TestAccS3Object_nonVersioned === RUN TestAccS3Object_updates === PAUSE TestAccS3Object_updates === RUN TestAccS3Object_updateSameFile === PAUSE TestAccS3Object_updateSameFile === RUN TestAccS3Object_updatesWithVersioning === PAUSE TestAccS3Object_updatesWithVersioning === RUN TestAccS3Object_updatesWithVersioningViaAccessPoint === PAUSE TestAccS3Object_updatesWithVersioningViaAccessPoint === RUN TestAccS3Object_kms === PAUSE TestAccS3Object_kms === RUN TestAccS3Object_sse === PAUSE TestAccS3Object_sse === RUN TestAccS3Object_acl === PAUSE TestAccS3Object_acl === RUN TestAccS3Object_metadata === PAUSE TestAccS3Object_metadata === RUN TestAccS3Object_storageClass === PAUSE TestAccS3Object_storageClass === RUN TestAccS3Object_tags === PAUSE TestAccS3Object_tags === RUN TestAccS3Object_tagsLeadingSingleSlash === PAUSE TestAccS3Object_tagsLeadingSingleSlash === RUN TestAccS3Object_tagsLeadingMultipleSlashes === PAUSE TestAccS3Object_tagsLeadingMultipleSlashes === RUN TestAccS3Object_tagsMultipleSlashes === PAUSE TestAccS3Object_tagsMultipleSlashes === RUN TestAccS3Object_objectLockLegalHoldStartWithNone === PAUSE TestAccS3Object_objectLockLegalHoldStartWithNone === RUN TestAccS3Object_objectLockLegalHoldStartWithOn === PAUSE TestAccS3Object_objectLockLegalHoldStartWithOn === RUN TestAccS3Object_objectLockRetentionStartWithNone === PAUSE TestAccS3Object_objectLockRetentionStartWithNone === RUN TestAccS3Object_objectLockRetentionStartWithSet === PAUSE TestAccS3Object_objectLockRetentionStartWithSet === RUN TestAccS3Object_objectBucketKeyEnabled === PAUSE TestAccS3Object_objectBucketKeyEnabled === RUN TestAccS3Object_bucketBucketKeyEnabled === PAUSE TestAccS3Object_bucketBucketKeyEnabled === RUN TestAccS3Object_defaultBucketSSE === PAUSE TestAccS3Object_defaultBucketSSE === RUN TestAccS3Object_ignoreTags === PAUSE TestAccS3Object_ignoreTags === RUN TestAccS3Object_checksumAlgorithm === PAUSE TestAccS3Object_checksumAlgorithm === RUN TestAccS3Object_keyWithSlashesMigrated === PAUSE TestAccS3Object_keyWithSlashesMigrated === CONT TestAccS3Object_basic === CONT TestAccS3Object_metadata === CONT TestAccS3Object_objectLockRetentionStartWithNone --- PASS: TestAccS3Object_basic (33.76s) === CONT TestAccS3Object_keyWithSlashesMigrated --- PASS: TestAccS3Object_metadata (77.59s) === CONT TestAccS3Object_checksumAlgorithm --- PASS: TestAccS3Object_objectLockRetentionStartWithNone (84.78s) === CONT TestAccS3Object_ignoreTags --- PASS: TestAccS3Object_keyWithSlashesMigrated (88.10s) === CONT TestAccS3Object_defaultBucketSSE --- PASS: TestAccS3Object_checksumAlgorithm (55.77s) === CONT TestAccS3Object_bucketBucketKeyEnabled --- PASS: TestAccS3Object_ignoreTags (60.84s) === CONT TestAccS3Object_objectBucketKeyEnabled --- PASS: TestAccS3Object_defaultBucketSSE (31.46s) === CONT TestAccS3Object_objectLockRetentionStartWithSet --- PASS: TestAccS3Object_bucketBucketKeyEnabled (30.85s) === CONT TestAccS3Object_tagsLeadingMultipleSlashes --- PASS: TestAccS3Object_objectBucketKeyEnabled (29.55s) === CONT TestAccS3Object_objectLockLegalHoldStartWithOn --- PASS: TestAccS3Object_objectLockLegalHoldStartWithOn (57.64s) === CONT TestAccS3Object_objectLockLegalHoldStartWithNone --- PASS: TestAccS3Object_objectLockRetentionStartWithSet (111.16s) === CONT TestAccS3Object_tagsMultipleSlashes --- PASS: TestAccS3Object_tagsLeadingMultipleSlashes (111.68s) === CONT TestAccS3Object_tags --- PASS: TestAccS3Object_objectLockLegalHoldStartWithNone (86.24s) === CONT TestAccS3Object_tagsLeadingSingleSlash --- PASS: TestAccS3Object_tagsMultipleSlashes (114.27s) === CONT TestAccS3Object_updatesWithVersioningViaAccessPoint --- PASS: TestAccS3Object_tags (118.60s) === CONT TestAccS3Object_acl --- PASS: TestAccS3Object_tagsLeadingSingleSlash (115.49s) === CONT TestAccS3Object_sse --- PASS: TestAccS3Object_updatesWithVersioningViaAccessPoint (60.27s) === CONT TestAccS3Object_kms --- PASS: TestAccS3Object_sse (35.29s) === CONT TestAccS3Object_etagEncryption --- PASS: TestAccS3Object_kms (35.48s) === CONT TestAccS3Object_withContentCharacteristics --- PASS: TestAccS3Object_acl (93.05s) === CONT TestAccS3Object_sourceHashTrigger --- PASS: TestAccS3Object_etagEncryption (35.19s) === CONT TestAccS3Object_contentBase64 --- PASS: TestAccS3Object_withContentCharacteristics (30.58s) === CONT TestAccS3Object_source --- PASS: TestAccS3Object_contentBase64 (30.87s) === CONT TestAccS3Object_nonVersioned acctest.go:1604: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions --- SKIP: TestAccS3Object_nonVersioned (0.00s) === CONT TestAccS3Object_updatesWithVersioning --- PASS: TestAccS3Object_source (35.54s) === CONT TestAccS3Object_updateSameFile --- PASS: TestAccS3Object_sourceHashTrigger (60.89s) === CONT TestAccS3Object_updates --- PASS: TestAccS3Object_updatesWithVersioning (61.58s) === CONT TestAccS3Object_content --- PASS: TestAccS3Object_updateSameFile (59.03s) === CONT TestAccS3Object_storageClass --- PASS: TestAccS3Object_updates (62.77s) === CONT TestAccS3Object_upgradeFromV4 --- PASS: TestAccS3Object_content (33.20s) --- PASS: TestAccS3Object_upgradeFromV4 (83.10s) --- PASS: TestAccS3Object_storageClass (117.16s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 722.434s

…EST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3ObjectDataSource_ -timeout 180m === RUN TestAccS3ObjectDataSource_basic === PAUSE TestAccS3ObjectDataSource_basic === RUN TestAccS3ObjectDataSource_basicViaAccessPoint === PAUSE TestAccS3ObjectDataSource_basicViaAccessPoint === RUN TestAccS3ObjectDataSource_readableBody === PAUSE TestAccS3ObjectDataSource_readableBody === RUN TestAccS3ObjectDataSource_kmsEncrypted === PAUSE TestAccS3ObjectDataSource_kmsEncrypted === RUN TestAccS3ObjectDataSource_bucketKeyEnabled === PAUSE TestAccS3ObjectDataSource_bucketKeyEnabled === RUN TestAccS3ObjectDataSource_allParams === PAUSE TestAccS3ObjectDataSource_allParams === RUN TestAccS3ObjectDataSource_objectLockLegalHoldOff === PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOff === RUN TestAccS3ObjectDataSource_objectLockLegalHoldOn === PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOn === RUN TestAccS3ObjectDataSource_leadingSlash === PAUSE TestAccS3ObjectDataSource_leadingSlash === RUN TestAccS3ObjectDataSource_multipleSlashes === PAUSE TestAccS3ObjectDataSource_multipleSlashes === RUN TestAccS3ObjectDataSource_singleSlashAsKey === PAUSE TestAccS3ObjectDataSource_singleSlashAsKey === RUN TestAccS3ObjectDataSource_checksumMode === PAUSE TestAccS3ObjectDataSource_checksumMode === CONT TestAccS3ObjectDataSource_basic === CONT TestAccS3ObjectDataSource_objectLockLegalHoldOff === CONT TestAccS3ObjectDataSource_kmsEncrypted --- PASS: TestAccS3ObjectDataSource_basic (29.02s) === CONT TestAccS3ObjectDataSource_readableBody --- PASS: TestAccS3ObjectDataSource_kmsEncrypted (29.71s) === CONT TestAccS3ObjectDataSource_allParams --- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOff (32.95s) === CONT TestAccS3ObjectDataSource_bucketKeyEnabled --- PASS: TestAccS3ObjectDataSource_readableBody (28.65s) === CONT TestAccS3ObjectDataSource_basicViaAccessPoint --- PASS: TestAccS3ObjectDataSource_bucketKeyEnabled (29.35s) === CONT TestAccS3ObjectDataSource_multipleSlashes --- PASS: TestAccS3ObjectDataSource_allParams (33.10s) === CONT TestAccS3ObjectDataSource_checksumMode --- PASS: TestAccS3ObjectDataSource_basicViaAccessPoint (29.29s) === CONT TestAccS3ObjectDataSource_singleSlashAsKey --- PASS: TestAccS3ObjectDataSource_checksumMode (28.50s) === CONT TestAccS3ObjectDataSource_leadingSlash --- PASS: TestAccS3ObjectDataSource_singleSlashAsKey (14.84s) === CONT TestAccS3ObjectDataSource_objectLockLegalHoldOn --- PASS: TestAccS3ObjectDataSource_multipleSlashes (49.07s) --- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOn (31.20s) --- PASS: TestAccS3ObjectDataSource_leadingSlash (47.08s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 143.605s

# Conflicts: # go.sum

github-actions · 2023-09-14T23:21:19Z

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-10-15T02:04:24Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit added 12 commits September 7, 2023 11:46

s3: 'ObjectUpdateTags' -> 'ObjectUpdateTagsV1'.

6164986

s3: Add 'ObjectUpdateTags'.

64a82e6

Run 'go get github.com/aws/aws-sdk-go-v2/feature/s3/[email protected] …

df86185

…&& go mod tidy'.

r/aws_s3_object_copy: Tweak error message.

8b08857

Fixup 'ObjectUpdateTags'.

591a9d9

r/aws_s3_object: Migrate to AWS SDK for Go v2.

438ce49

TestDeleteAllObjectVersions: Migrate to AWS SDK for Go v2.

8ecd1b9

ObjectListTags: Remove retry as there is now string consistency for r…

845af9a

…ead operations on Amazon S3 Object Tags.

s3: 'errs.IsA' doesn't work as expected because the errors in 'types'…

e57f697

… aren't exposed as nested.

resourceObjectRead: Remove retry as there is now strong read-after-wr…

457bda2

…ite consistency for PUT and DELETE requests of objects.

r/aws_s3_object: Migrate acceptance tests to AWS SDK for Go v2.

a2c8dbb

Use 'cmp.Diff', not 'reflect.DeppEqual'.

702161d

github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Sep 7, 2023

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 7, 2023

ewbankkit added 4 commits September 7, 2023 16:33

s3: Fix sweepers.

74955e1

Fix golangci-lint 'ineffassign'.

8fd99e9

s3: 'DeleteAllObjectVersions' -> 'deleteAllObjectVersions'.

c702171

s3: 'FindObjectByThreePartKey' -> 'findObjectByThreePartKey'.

5428ce0

github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Sep 8, 2023

ewbankkit added 8 commits September 8, 2023 11:00

Add 'findObject'.

1e9cd4a

r/aws_s3_object: Add checksum_algorithm argument and `checksum_crc3…

452c073

…2`, `checksum_crc32c`, `checksum_sha1` and `checksum_sha256` attributes.

Enhance 'TestAccS3Object_basic'.

d6a1f93

Add 'TestAccS3Object_checksumAlgorithm'.

6f41bd4

r/aws_s3_object_copy: Add checksum_algorithm argument and `checksum…

b87f312

…_crc32`, `checksum_crc32c`, `checksum_sha1` and `checksum_sha256` attributes.

teamterraform mentioned this pull request Sep 12, 2023

Backport of backend/s3: prevent keys containing double slashes into v1.6 hashicorp/terraform#33877

Merged

ewbankkit added 9 commits September 12, 2023 10:21

Tweak comment.

53d08ef

Add AWSClient.S3UsePathStyle -- used by S3 sweepers.

31cdf17

s3: Migrate sweepers to AWS SDK for Go v2.

62f2c2b

Revert "r/aws_s3_object(test): fixed _tags post destroy bucket deleti…

56fc1af

…on error" This reverts commit e2177f1.

d/aws_s3_object: Use 'sdkv1CompatibleCleanKey'.

c54bf83

d/aws_s3_object: 'key = "/"' is no longer supported.

6c2d115

Merge branch 'main' into f-aws_s3_object-aws-sdk-v2

a1fb178

# Conflicts: # go.sum

ewbankkit changed the title ~~[WIP] r/aws_s3_object: Migrate to AWS SDK for Go v2~~ r/aws_s3_object: Migrate to AWS SDK for Go v2 Sep 12, 2023

ewbankkit added 2 commits September 12, 2023 13:11

Fix terrafmt errors.

c541b6f

Fix terrafmt errors.

26b1cd8

ewbankkit merged commit cf5075a into main Sep 12, 2023
47 checks passed

ewbankkit deleted the f-aws_s3_object-aws-sdk-v2 branch September 12, 2023 18:15

github-actions bot added this to the v5.17.0 milestone Sep 12, 2023

github-actions bot pushed a commit that referenced this pull request Sep 12, 2023

Update CHANGELOG.md for #33358

fcf11a7

This was referenced Sep 12, 2023

r/aws_s3_bucket_policy at al.: Migrate to AWS SDK for Go v2 #33431

Merged

r/aws_s3_bucket: Migrate FindBucket to AWS SDK for Go v2 #33452

Merged

andremachado94 mentioned this pull request Sep 27, 2023

[Bug]: Data Source aws_s3_object - Unable to retrieve User Defined metadata #33648

Closed

This was referenced Sep 27, 2023

s3(control): Complete migration to AWS SDK for Go v2 #33654

Closed

S3 Object metadata keys are returned in lowercase #33660

Merged

r/aws_s3_object: Test access through a multi-region access point #33677

Merged

github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023

justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_s3_object: Migrate to AWS SDK for Go v2 #33358

r/aws_s3_object: Migrate to AWS SDK for Go v2 #33358

ewbankkit commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Oct 15, 2023

r/aws_s3_object: Migrate to AWS SDK for Go v2 #33358

r/aws_s3_object: Migrate to AWS SDK for Go v2 #33358

Conversation

ewbankkit commented Sep 7, 2023 • edited Loading

Description

Relations

Output from Acceptance Testing

github-actions bot commented Sep 7, 2023

Community Note

github-actions bot commented Sep 14, 2023

github-actions bot commented Oct 15, 2023

ewbankkit commented Sep 7, 2023 •

edited

Loading