-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inspector2_enabler fails to create due to incorrect resource type #33348
fix: inspector2_enabler fails to create due to incorrect resource type #33348
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hey @0xfabio 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
89ca099
to
b6ea639
Compare
Is there any estimation when this fix could be merged? It works and would help us to integrate AWS Inspector without having to do some hacky workarounds. |
@ewbankkit Thanks for getting this merged 👍 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This is the PR for the fix implemented by @irth in this comment
Relations
Closes #32334
Output from Acceptance Testing
We have tested this locally and without the fix creating the following resource failed.
This is a similar terraform resource also used in the
testAccEnablerConfig_basic
acceptance test, but unfortunately we can currently not run the acceptance test with our current setup.Output with version 5.15.0:
Output with this fix: