Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new version of regexache #33317

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Use new version of regexache #33317

merged 1 commit into from
Sep 5, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 5, 2023 •
edited
Loading

Description

In my testing, the new version of regexache is performing the same as without (or slightly better), while saving ~20% memory. The new version includes cache preloading and an improved approach to read locks.

Relations

Closes #33218
Relates #32289

References

Output from Acceptance Testing

% REGEXACHE_OFF=1 make t T=TestAccSSMParameter_ K=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMParameter_'  -timeout 180m
=== RUN   TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN   TestAccSSMParameter_updateValue
=== PAUSE TestAccSSMParameter_updateValue
=== RUN   TestAccSSMParameter_updateDescription
=== PAUSE TestAccSSMParameter_updateDescription
=== RUN   TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN   TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN   TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN   TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN   TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN   TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN   TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN   TestAccSSMParameter_Overwrite_removeAttribute
=== PAUSE TestAccSSMParameter_Overwrite_removeAttribute
=== RUN   TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN   TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN   TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN   TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN   TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN   TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN   TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN   TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN   TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN   TestAccSSMParameter_DataType_ssmIntegration
=== PAUSE TestAccSSMParameter_DataType_ssmIntegration
=== RUN   TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN   TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== CONT  TestAccSSMParameter_basic
=== CONT  TestAccSSMParameter_Overwrite_removeAttribute
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== CONT  TestAccSSMParameter_Overwrite_tags
=== CONT  TestAccSSMParameter_Overwrite_basic
=== CONT  TestAccSSMParameter_Secure_basic
=== CONT  TestAccSSMParameter_Overwrite_noOverwriteTags
=== CONT  TestAccSSMParameter_Overwrite_updateDescription
=== CONT  TestAccSSMParameter_Secure_insecureChangeSecure
=== CONT  TestAccSSMParameter_Overwrite_updateToTags
=== CONT  TestAccSSMParameter_Secure_insecure
=== CONT  TestAccSSMParameter_fullPath
=== CONT  TestAccSSMParameter_Secure_keyUpdate
=== CONT  TestAccSSMParameter_changeNameForcesNew
=== CONT  TestAccSSMParameter_Secure_key
=== CONT  TestAccSSMParameter_DataType_ssmIntegration
=== CONT  TestAccSSMParameter_DataType_ec2Image
=== CONT  TestAccSSMParameter_Overwrite_cascade
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToStandard
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnCreation
--- PASS: TestAccSSMParameter_Secure_basic (92.39s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToAdvanced
--- PASS: TestAccSSMParameter_basic (92.46s)
=== CONT  TestAccSSMParameter_tags
--- PASS: TestAccSSMParameter_fullPath (92.53s)
=== CONT  TestAccSSMParameter_updateType
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (92.54s)
=== CONT  TestAccSSMParameter_updateDescription
--- PASS: TestAccSSMParameter_Overwrite_tags (92.58s)
=== CONT  TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (92.83s)
=== CONT  TestAccSSMParameter_updateValue
--- PASS: TestAccSSMParameter_DataType_ssmIntegration (93.51s)
=== CONT  TestAccSSMParameter_disappears
--- PASS: TestAccSSMParameter_DataType_ec2Image (95.44s)
--- PASS: TestAccSSMParameter_Secure_key (96.00s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (141.22s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (150.52s)
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (150.63s)
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (151.63s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (154.18s)
--- PASS: TestAccSSMParameter_disappears (64.52s)
--- PASS: TestAccSSMParameter_Overwrite_removeAttribute (158.99s)
--- PASS: TestAccSSMParameter_Overwrite_cascade (170.68s)
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (181.80s)
--- PASS: TestAccSSMParameter_Secure_insecure (186.62s)
--- PASS: TestAccSSMParameter_Overwrite_basic (188.14s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (190.53s)
--- PASS: TestAccSSMParameter_updateType (110.58s)
--- PASS: TestAccSSMParameter_updateDescription (114.60s)
--- PASS: TestAccSSMParameter_updateValue (115.24s)
--- PASS: TestAccSSMParameter_tags (132.22s)
--- PASS: TestAccSSMParameter_tier (132.13s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (133.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	227.568s
% make t T=TestAccSSMParameter_ K=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMParameter_'  -timeout 180m
=== RUN   TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN   TestAccSSMParameter_updateValue
=== PAUSE TestAccSSMParameter_updateValue
=== RUN   TestAccSSMParameter_updateDescription
=== PAUSE TestAccSSMParameter_updateDescription
=== RUN   TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN   TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN   TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN   TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN   TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN   TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN   TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN   TestAccSSMParameter_Overwrite_removeAttribute
=== PAUSE TestAccSSMParameter_Overwrite_removeAttribute
=== RUN   TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN   TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN   TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN   TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN   TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN   TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN   TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN   TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN   TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN   TestAccSSMParameter_DataType_ssmIntegration
=== PAUSE TestAccSSMParameter_DataType_ssmIntegration
=== RUN   TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN   TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== CONT  TestAccSSMParameter_basic
=== CONT  TestAccSSMParameter_Overwrite_removeAttribute
=== CONT  TestAccSSMParameter_Secure_insecure
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== CONT  TestAccSSMParameter_Secure_basic
=== CONT  TestAccSSMParameter_Overwrite_cascade
=== CONT  TestAccSSMParameter_tags
=== CONT  TestAccSSMParameter_Overwrite_tags
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== CONT  TestAccSSMParameter_DataType_ssmIntegration
=== CONT  TestAccSSMParameter_updateDescription
=== CONT  TestAccSSMParameter_Overwrite_basic
=== CONT  TestAccSSMParameter_changeNameForcesNew
=== CONT  TestAccSSMParameter_fullPath
=== CONT  TestAccSSMParameter_updateType
=== CONT  TestAccSSMParameter_Overwrite_updateDescription
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToStandard
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== CONT  TestAccSSMParameter_Secure_keyUpdate
=== CONT  TestAccSSMParameter_Secure_key
--- PASS: TestAccSSMParameter_Secure_basic (97.20s)
=== CONT  TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_fullPath (97.32s)
=== CONT  TestAccSSMParameter_updateValue
--- PASS: TestAccSSMParameter_Overwrite_tags (97.32s)
=== CONT  TestAccSSMParameter_Overwrite_updateToTags
--- PASS: TestAccSSMParameter_basic (97.38s)
=== CONT  TestAccSSMParameter_Overwrite_noOverwriteTags
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (97.43s)
=== CONT  TestAccSSMParameter_disappears
--- PASS: TestAccSSMParameter_DataType_ssmIntegration (99.77s)
=== CONT  TestAccSSMParameter_DataType_ec2Image
--- PASS: TestAccSSMParameter_Secure_key (103.92s)
=== CONT  TestAccSSMParameter_Secure_insecureChangeSecure
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (148.13s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (162.15s)
--- PASS: TestAccSSMParameter_updateType (162.22s)
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (162.28s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (162.76s)
--- PASS: TestAccSSMParameter_disappears (68.82s)
--- PASS: TestAccSSMParameter_updateDescription (172.28s)
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (84.85s)
--- PASS: TestAccSSMParameter_Overwrite_cascade (182.75s)
--- PASS: TestAccSSMParameter_Overwrite_removeAttribute (183.24s)
--- PASS: TestAccSSMParameter_DataType_ec2Image (87.19s)
--- PASS: TestAccSSMParameter_Overwrite_basic (199.23s)
--- PASS: TestAccSSMParameter_Secure_insecure (199.23s)
--- PASS: TestAccSSMParameter_tags (200.07s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (200.12s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (202.33s)
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (112.76s)
--- PASS: TestAccSSMParameter_updateValue (116.73s)
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (121.49s)
--- PASS: TestAccSSMParameter_tier (130.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	229.908s

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Sep 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2023
@YakDriver YakDriver merged commit 78baa8f into main Sep 5, 2023
60 checks passed
@YakDriver YakDriver deleted the f-update-regexache branch September 5, 2023 22:56
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 5, 2023
This was referenced Sep 6, 2023
Closed
Merged
Merged
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@FernandoMiguel
Copy link
Contributor

I'm a tad concern this PR was merged to main without a single reviewer approval, and originated a release.
Terraform is used by millions of clients, and its impact is of thousands millions of end users.
One would expect a better management of releases.

Food for thought

@YakDriver YakDriver mentioned this pull request Sep 20, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.16.0
Development

Successfully merging this pull request may close these issues.

[Bug]: new version 5.14.0 causes terraform operations to run 4x slower than 5.13.1
3 participants
@YakDriver @FernandoMiguel @justinretzolk