Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS custom engine version (CEV) #33285

Merged
merged 23 commits into from
Sep 26, 2023
Merged

RDS custom engine version (CEV) #33285

merged 23 commits into from
Sep 26, 2023

Conversation

AdamTylerLynch
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch commented Sep 1, 2023 •
edited
Loading

Description

RDS Custom engine version (CEV) support for RDS Custom for SQL Server and RDS Custom for Oracle.

*** Requires prerequisite AMIs/installation media! ****
Requires the following Environment Variables
RDS_CUSTOM_WINDOWS_SQLSERVER_AMI (AMI name like "ami-123bbb333444nn")
RDS_CUSTOM_ORACLE_S3_BUCKET (bucket name like "mybucket")

Relations

Closes #0000

References

Output from Acceptance Testing

make testacc PKG=rds TESTS=TestAccRDSCustomDBEngineVersion_ ACCTEST_PARALLELISM=5 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 5 -run='TestAccRDSCustomDBEngineVersion_'  -timeout 180m
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServer
=== PAUSE TestAccRDSCustomDBEngineVersion_sqlServer
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServerUpdate
=== PAUSE TestAccRDSCustomDBEngineVersion_sqlServerUpdate
=== RUN   TestAccRDSCustomDBEngineVersion_oracle
=== PAUSE TestAccRDSCustomDBEngineVersion_oracle
=== RUN   TestAccRDSCustomDBEngineVersion_manifestFile
=== PAUSE TestAccRDSCustomDBEngineVersion_manifestFile
=== RUN   TestAccRDSCustomDBEngineVersion_disappears
=== PAUSE TestAccRDSCustomDBEngineVersion_disappears
=== CONT  TestAccRDSCustomDBEngineVersion_sqlServer
=== CONT  TestAccRDSCustomDBEngineVersion_manifestFile
=== CONT  TestAccRDSCustomDBEngineVersion_disappears
=== CONT  TestAccRDSCustomDBEngineVersion_oracle
=== CONT  TestAccRDSCustomDBEngineVersion_sqlServerUpdate
--- PASS: TestAccRDSCustomDBEngineVersion_sqlServer (292.13s)
--- PASS: TestAccRDSCustomDBEngineVersion_sqlServerUpdate (298.21s)
--- PASS: TestAccRDSCustomDBEngineVersion_disappears (322.95s)
--- PASS: TestAccRDSCustomDBEngineVersion_oracle (5916.96s)
--- PASS: TestAccRDSCustomDBEngineVersion_manifestFile (6219.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	6225.743s

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. generators Relates to code generators. labels Sep 1, 2023
@AdamTylerLynch
Copy link
Collaborator Author

Need to add Tags on create test. Does not support Tags update.

@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 1, 2023
@AdamTylerLynch
Copy link
Collaborator Author 

 make testacc PKG=rds TESTS=TestAccRDSCustomDBEngineVersion_tags ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 5 -run='TestAccRDSCustomDBEngineVersion_tags'  -timeout 180m
=== RUN   TestAccRDSCustomDBEngineVersion_tags
=== PAUSE TestAccRDSCustomDBEngineVersion_tags
=== CONT  TestAccRDSCustomDBEngineVersion_tags
--- PASS: TestAccRDSCustomDBEngineVersion_tags (180.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	186.731s

@AdamTylerLynch AdamTylerLynch changed the title [WIP] RDS custom engine version (CEV) RDS custom engine version (CEV) Sep 5, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2023
ddericco
ddericco reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ddericco ddericco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments/suggestions for review, and fixes to documentation.

internal/service/rds/custom_db_engine_version.go Show resolved Hide resolved
internal/service/rds/custom_db_engine_version.go Show resolved Hide resolved
internal/service/rds/custom_db_engine_version.go Show resolved Hide resolved
internal/service/rds/custom_db_engine_version.go Show resolved Hide resolved
website/docs/r/rds_custom_db_engine_version.markdown Outdated Show resolved Hide resolved
website/docs/r/rds_custom_db_engine_version.markdown Outdated Show resolved Hide resolved
website/docs/r/rds_custom_db_engine_version.markdown Show resolved Hide resolved
ewbankkit
ewbankkit previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCustomDBEngineVersion_' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCustomDBEngineVersion_ -timeout 180m
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServer
    custom_db_engine_version_test.go:37: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServer (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServerUpdate
    custom_db_engine_version_test.go:83: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServerUpdate (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_oracle
    custom_db_engine_version_test.go:139: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_oracle (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_manifestFile
    custom_db_engine_version_test.go:185: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_manifestFile (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_tags
    custom_db_engine_version_test.go:231: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_tags (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_disappears
    custom_db_engine_version_test.go:269: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	7.644s

@ewbankkit ewbankkit self-requested a review September 6, 2023 15:12
@ewbankkit ewbankkit dismissed their stale review September 6, 2023 15:13

Waiting for response to @ddericco's review

@ewbankkit ewbankkit self-assigned this Sep 26, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2023
ewbankkit
ewbankkit approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCustomDBEngineVersion_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCustomDBEngineVersion_ -timeout 360m
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServer
    custom_db_engine_version_test.go:37: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServer (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServerUpdate
    custom_db_engine_version_test.go:83: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServerUpdate (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_oracle
    custom_db_engine_version_test.go:139: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_oracle (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_manifestFile
    custom_db_engine_version_test.go:185: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_manifestFile (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_tags
    custom_db_engine_version_test.go:231: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_tags (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_disappears
    custom_db_engine_version_test.go:269: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	5.437s

@ewbankkit
Copy link
Contributor

@AdamTylerLynch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a425ad0 into hashicorp:main Sep 26, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.19.0 milestone Sep 26, 2023
@AdamTylerLynch AdamTylerLynch mentioned this pull request Sep 27, 2023
Merged
@github-actions
Copy link

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddericco ddericco ddericco left review comments

@jar-b jar-b jar-b left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AdamTylerLynch @ewbankkit @jar-b @ddericco