-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/api_gateway_api_key - add customer key and make name updateable #33281
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAPIGatewayAPIKey_\|TestAccAPIGatewayAPIKeyDataSource_' PKG=apigateway ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 2 -run=TestAccAPIGatewayAPIKey_\|TestAccAPIGatewayAPIKeyDataSource_ -timeout 180m
=== RUN TestAccAPIGatewayAPIKeyDataSource_basic
=== PAUSE TestAccAPIGatewayAPIKeyDataSource_basic
=== RUN TestAccAPIGatewayAPIKey_basic
=== PAUSE TestAccAPIGatewayAPIKey_basic
=== RUN TestAccAPIGatewayAPIKey_tags
=== PAUSE TestAccAPIGatewayAPIKey_tags
=== RUN TestAccAPIGatewayAPIKey_customerID
=== PAUSE TestAccAPIGatewayAPIKey_customerID
=== RUN TestAccAPIGatewayAPIKey_description
=== PAUSE TestAccAPIGatewayAPIKey_description
=== RUN TestAccAPIGatewayAPIKey_enabled
=== PAUSE TestAccAPIGatewayAPIKey_enabled
=== RUN TestAccAPIGatewayAPIKey_value
=== PAUSE TestAccAPIGatewayAPIKey_value
=== RUN TestAccAPIGatewayAPIKey_disappears
=== PAUSE TestAccAPIGatewayAPIKey_disappears
=== CONT TestAccAPIGatewayAPIKeyDataSource_basic
=== CONT TestAccAPIGatewayAPIKey_description
--- PASS: TestAccAPIGatewayAPIKeyDataSource_basic (48.97s)
=== CONT TestAccAPIGatewayAPIKey_disappears
--- PASS: TestAccAPIGatewayAPIKey_disappears (36.24s)
=== CONT TestAccAPIGatewayAPIKey_value
--- PASS: TestAccAPIGatewayAPIKey_description (89.37s)
=== CONT TestAccAPIGatewayAPIKey_enabled
--- PASS: TestAccAPIGatewayAPIKey_value (45.08s)
=== CONT TestAccAPIGatewayAPIKey_tags
--- PASS: TestAccAPIGatewayAPIKey_enabled (75.78s)
=== CONT TestAccAPIGatewayAPIKey_customerID
--- PASS: TestAccAPIGatewayAPIKey_tags (110.33s)
=== CONT TestAccAPIGatewayAPIKey_basic
--- PASS: TestAccAPIGatewayAPIKey_customerID (79.19s)
--- PASS: TestAccAPIGatewayAPIKey_basic (75.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 321.990s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
References
Output from Acceptance Testing