Added the opensearch with standby functionality

[mikekinlock]

Change

• Added the opensearch with standby functionality

Description

• Added the option to configure an opensearch cluster with standby

Relations

Closes #31373

References

As a reference to this change I've used the AWS-CLI documentations and followed their setup structure. Meaning other than requested in the issue, I've added the MultiAZWithStandbyEnabled configuration under cluster-config and not under vpc_options

Output from Acceptance Testing

The following test is currently failing and I'm not sure how to solve it yet, point is that the created resource is already deleted once the test is trying to verify its configuration. Here I would kindly ask for support. In this case I'm leaning on the best effort clause in your contributor guide

% make testacc TESTS=TestAccDomainConfig_multiAzWithStandby PKG=opensearch

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Welcome @mikekinlock 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_advanced\|TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_Cluster_' PKG=opensearch ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 3  -run=TestAccOpenSearchDomainDataSource_Data_advanced\|TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_Cluster_ -timeout 720m
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_Cluster_zoneAwareness
=== PAUSE TestAccOpenSearchDomain_Cluster_zoneAwareness
=== RUN   TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== RUN   TestAccOpenSearchDomain_Cluster_warm
=== PAUSE TestAccOpenSearchDomain_Cluster_warm
=== RUN   TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== RUN   TestAccOpenSearchDomain_Cluster_update
=== PAUSE TestAccOpenSearchDomain_Cluster_update
=== RUN   TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== PAUSE TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomain_Cluster_warm
=== CONT  TestAccOpenSearchDomain_Cluster_zoneAwareness
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2493.19s)
=== CONT  TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_basic (1923.63s)
=== CONT  TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomain_Cluster_warm (5251.12s)
=== CONT  TestAccOpenSearchDomain_Cluster_update
--- PASS: TestAccOpenSearchDomain_Cluster_zoneAwareness (7575.42s)
=== CONT  TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (3621.94s)
=== CONT  TestAccOpenSearchDomain_Cluster_dedicatedMaster
--- PASS: TestAccOpenSearchDomain_Cluster_update (4570.21s)
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (2958.39s)
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedMaster (6241.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	14285.490s

[ewbankkit]

@mikekinlock Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[amiryoni]

This bug might have been fixed but the latest documentations are not updated, so I am at a loss here how to use it.
Thanks,

[mikekinlock]

@amiryoni thanks for the info, I'll ask in slack If I should update the documentations or if that is done by someone else but in the meanwhile you can use it just like the AWS CLI Command Reference

See here

resource "aws_opensearch_domain" "your_resource_name" {
  ...
  cluster_config {
    ...
    multi_az_with_standby_enabled = true
  }
}

[AnanyaBanerjee01]

I think documentation is not updated yet ewbankkit mikekinlock

[jasonwbarnett]

Thanks @mikekinlock. I really appreciate the contribution. ❤️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.