ressource/aws_budgets_budget_action : No longer waits for action to have completed running or be pending

[gdavison]

Description

The current behaviour of aws_budgets_budget_action waits for the action to have completed or be in a pending state for manual approval. If a budget action is not triggered, none of these states will be valid, and the action will be in standby status.

No longer waits for any status, since creation of an action is a synchronous operation. Adds guard to deletion, since an action cannot be deleted while in progress.

Relations

Closes #31236

Output from Acceptance Testing

% make testacc PKG=budgets TESTS=TestAccBudgetsBudgetAction_

--- PASS: TestAccBudgetsBudgetAction_disappears (27.60s)
--- PASS: TestAccBudgetsBudgetAction_triggeredAutomatic (30.49s)
--- PASS: TestAccBudgetsBudgetAction_basic (30.62s)
--- PASS: TestAccBudgetsBudgetAction_triggeredManual (30.62s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=budgets TESTS=TestAccBudgetsBudgetAction_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20 -run='TestAccBudgetsBudgetAction_'  -timeout 180m

--- PASS: TestAccBudgetsBudgetAction_basic (28.81s)
--- PASS: TestAccBudgetsBudgetAction_triggeredAutomatic (29.32s)
--- PASS: TestAccBudgetsBudgetAction_triggeredManual (29.32s)
--- PASS: TestAccBudgetsBudgetAction_disappears (30.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    33.584s

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.