Fix perpetual diff on aws_s3_bucket_logging resource when expected_bucket_owner contains a value

[bakeemawaytoys]

Fixed the value of the aws_s3_bucket_logging resource's bucket attribute when the expected_bucket_owner argument is set. It was incorrectly set to the resource ID instead of the bucket's name. The bug only occurred when the expected_bucket_owner is set because its value is included in the ID. Otherwise, the bucket name and the ID are equal.
I didn't add a test for this because I'm not sure how to test cross-account behavior. The other S3 resources that have the expected_bucket_owner argument don't include tests for it.

Description

Relations

Closes #26627

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @bakeemawaytoys 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3BucketLogging_' PKG=s3 ACCTEST_PARALLELISM=2         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketLogging_ -timeout 180m
=== RUN   TestAccS3BucketLogging_basic
=== PAUSE TestAccS3BucketLogging_basic
=== RUN   TestAccS3BucketLogging_disappears
=== PAUSE TestAccS3BucketLogging_disappears
=== RUN   TestAccS3BucketLogging_update
=== PAUSE TestAccS3BucketLogging_update
=== RUN   TestAccS3BucketLogging_TargetGrantByID
=== PAUSE TestAccS3BucketLogging_TargetGrantByID
=== RUN   TestAccS3BucketLogging_TargetGrantByEmail
    acctest.go:83: 'AWS_S3_BUCKET_LOGGING_AMAZON_CUSTOMER_BY_EMAIL' not set, skipping test.
--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
=== RUN   TestAccS3BucketLogging_TargetGrantByGroup
=== PAUSE TestAccS3BucketLogging_TargetGrantByGroup
=== RUN   TestAccS3BucketLogging_migrate_loggingNoChange
=== PAUSE TestAccS3BucketLogging_migrate_loggingNoChange
=== RUN   TestAccS3BucketLogging_migrate_loggingWithChange
=== PAUSE TestAccS3BucketLogging_migrate_loggingWithChange
=== RUN   TestAccS3BucketLogging_withExpectedBucketOwner
=== PAUSE TestAccS3BucketLogging_withExpectedBucketOwner
=== CONT  TestAccS3BucketLogging_basic
=== CONT  TestAccS3BucketLogging_TargetGrantByGroup
--- PASS: TestAccS3BucketLogging_basic (36.93s)
=== CONT  TestAccS3BucketLogging_update
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (87.47s)
=== CONT  TestAccS3BucketLogging_TargetGrantByID
--- PASS: TestAccS3BucketLogging_update (58.92s)
=== CONT  TestAccS3BucketLogging_migrate_loggingWithChange
--- PASS: TestAccS3BucketLogging_migrate_loggingWithChange (54.51s)
=== CONT  TestAccS3BucketLogging_withExpectedBucketOwner
--- PASS: TestAccS3BucketLogging_TargetGrantByID (89.95s)
=== CONT  TestAccS3BucketLogging_migrate_loggingNoChange
--- PASS: TestAccS3BucketLogging_withExpectedBucketOwner (36.66s)
=== CONT  TestAccS3BucketLogging_disappears
--- PASS: TestAccS3BucketLogging_disappears (32.98s)
--- PASS: TestAccS3BucketLogging_migrate_loggingNoChange (55.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	238.199s

[ewbankkit]

@bakeemawaytoys Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.