b-32645: Updated attribue type for permissions from TypeList to TypeSet

[nrajb]

Description

Updated attribue type for permissions from TypeList to TypeSet

Relations

Closes #32645

Output from Acceptance Testing

Without the fix in provider code locally:

 terraform plan                                                                                                                                                [13/08/23|11:47AM]
data.aws_quicksight_user.qs_data_set_users[0]: Reading...
data.aws_quicksight_user.qs_data_set_users[1]: Reading...
aws_quicksight_data_source.rdspg: Refreshing state... [id=****************/example_id]
data.aws_quicksight_user.qs_data_set_users[0]: Read complete after 0s [id=****************/default/Admin/usrname1]
data.aws_quicksight_user.qs_data_set_users[1]: Read complete after 0s [id=****************/default/tf-qs-bug/usrname2]
aws_quicksight_data_set.test_dataset: Refreshing state... [id=****************,test]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_quicksight_data_set.test_dataset will be updated in-place
  ~ resource "aws_quicksight_data_set" "test_dataset" {
        id             = "****************,test"
        name           = "test"
        tags           = {}
        # (6 unchanged attributes hidden)

      ~ permissions {
          ~ principal = "arn:aws:quicksight:us-east-1:****************:user/default/tf-qs-bug/usrname" -> "arn:aws:quicksight:us-east-1:****************:user/default/Admin/usrname"
            # (1 unchanged attribute hidden)
        }
      ~ permissions {
          ~ principal = "arn:aws:quicksight:us-east-1:****************:user/default/Admin/username1" -> "arn:aws:quicksight:us-east-1:****************:user/default/tf-qs-bug/username2"
            # (1 unchanged attribute hidden)
        }

        # (3 unchanged blocks hidden)
    }

  # aws_quicksight_data_source.rdspg will be updated in-place
  ~ resource "aws_quicksight_data_source" "rdspg" {
        id             = "****************/example_id"
        name           = "1234"
        tags           = {}
        # (5 unchanged attributes hidden)

      - ssl_properties {
          - disable_ssl = false -> null
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now.

...

With the fix in locally built provider:

└> terraform plan                                                                                                                                                [13/08/23|11:48AM]
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - hashicorp/aws in /Users/nrajb/go/1.20.5/bin
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.
╵
data.aws_quicksight_user.qs_data_set_users[0]: Reading...
data.aws_quicksight_user.qs_data_set_users[1]: Reading...
aws_quicksight_data_source.rdspg: Refreshing state... [id=****************//example_id]
data.aws_quicksight_user.qs_data_set_users[1]: Read complete after 0s [id=****************/default/tf-qs-bug/usrname1]
data.aws_quicksight_user.qs_data_set_users[0]: Read complete after 0s [id=****************/default/Admin/username2]
aws_quicksight_data_set.test_dataset: Refreshing state... [id=****************,test]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_quicksight_data_source.rdspg will be updated in-place
  ~ resource "aws_quicksight_data_source" "rdspg" {
        id             = "****************/example_id"
        name           = "1234"
        tags           = {}
        # (5 unchanged attributes hidden)

      - ssl_properties {
          - disable_ssl = false -> null
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=quicksight TESTS=TestAccQuickSightDataSet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDataSet_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightDataSet_disappears (47.39s)
--- PASS: TestAccQuickSightDataSet_dataSetUsageConfiguration (55.48s)
--- PASS: TestAccQuickSightDataSet_basic (55.58s)
--- PASS: TestAccQuickSightDataSet_columnGroups (55.65s)
--- PASS: TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration (55.91s)
--- PASS: TestAccQuickSightDataSet_fieldFolders (55.99s)
--- PASS: TestAccQuickSightDataSet_permissionsMultiple (56.17s)
--- PASS: TestAccQuickSightDataSet_columnLevelPermissionRules (56.33s)
--- PASS: TestAccQuickSightDataSet_noPhysicalTableMap (58.53s)
--- PASS: TestAccQuickSightDataSet_logicalTableMap (81.69s)
--- PASS: TestAccQuickSightDataSet_tags (103.85s)
--- PASS: TestAccQuickSightDataSet_permissions (110.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 113.210s

[jar-b]

Thanks for your contribution, @nrajb! 👏

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.