[Bug]: Failure to update aws_quicksight_data_source.name

[ss49919201]

Terraform Core Version

1.5.5

AWS Provider Version

5.12.0

Affected Resource(s)

aws_quicksight_data_source

Expected Behavior

If apply is executed with a difference in aws_quicksight_data_source.name, the UpdateDataSource API should be executed and succeed.

Actual Behavior

Error occurs due to incorrect DataSourceParameters.

Relevant Error/Panic Output Snippet

Error: updating QuickSight Data Source (xxxxxxxxx/example-id): InvalidParameterValueException: DataSourceParameters field is incorrectly set

Terraform Configuration Files

resource "aws_quicksight_data_source" "default" {
  data_source_id = "example-id"
  name           = "New DataSource"

  parameters {
    s3 {
      manifest_file_location {
        bucket = var.my_bucket
        key    = "example.json"
      }
    }
  }

  type = "S3"
}

Steps to Reproduce

Run terraform apply.
Then replace name with any string and run terraform apply again.

e.g.

resource "aws_quicksight_data_source" "default" {
  data_source_id = "example-id"
  name           = "Updated DataSource"

  parameters {
    s3 {
      manifest_file_location {
        bucket = var.my_bucket
        key    = "example.json"
      }
    }
  }

  type = "S3"
}

Debug Output

No response

Panic Output

No response

Important Factoids

cf. https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/quicksight/data_source.go#L742-L756
I don't think HasChange should be called.
I feel like I need to add a parameter to the Input even if there is no value update.

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.