Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudfront_distribution: Speed up tags-only updates #32865

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 4, 2023

Description

Speeds up tags-only updates by adding the if d.HasChangesExcept("tags", "tags_all") guard.

Relations

Closes #12138.

Output from Acceptance Testing

Before

% make testacc TESTARGS='-run=^TestAccCloudFrontDistribution_tags$$' PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=^TestAccCloudFrontDistribution_tags$ -timeout 180m
=== RUN   TestAccCloudFrontDistribution_tags
=== PAUSE TestAccCloudFrontDistribution_tags
=== CONT  TestAccCloudFrontDistribution_tags
--- PASS: TestAccCloudFrontDistribution_tags (775.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	780.967s

After

% make testacc TESTARGS='-run=^TestAccCloudFrontDistribution_tags$$' PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=^TestAccCloudFrontDistribution_tags$ -timeout 180m
=== RUN   TestAccCloudFrontDistribution_tags
=== PAUSE TestAccCloudFrontDistribution_tags
=== CONT  TestAccCloudFrontDistribution_tags
--- PASS: TestAccCloudFrontDistribution_tags (242.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	248.262s

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/cloudfront Issues and PRs that pertain to the cloudfront service. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 4, 2023
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 4, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. tags Pertains to resource tagging. labels Aug 4, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed tags Pertains to resource tagging. labels Aug 4, 2023
@ewbankkit ewbankkit merged commit 1bd51ad into main Aug 4, 2023
31 checks passed
@ewbankkit ewbankkit deleted the b-aws_cloudfront_distribution-tags-only-update branch August 4, 2023 16:56
@github-actions github-actions bot added this to the v5.12.0 milestone Aug 4, 2023
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Aug 10, 2023
@github-actions
Copy link

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudfront_distribution takes 10 mins for updating tags instead of 10 seconds
2 participants