Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new AWS Israel (Tel Aviv) Region il-central-1 in data sources #32840

Merged
merged 8 commits into from
Aug 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 3, 2023

Description

Adds data source support for the new AWS Region il-central-1.

Relations

Relates #32795.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloudTrailServiceAccountDataSource_' PKG=cloudtrail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudtrail/... -v -count 1 -parallel 2  -run=TestAccCloudTrailServiceAccountDataSource_ -timeout 180m
=== RUN   TestAccCloudTrailServiceAccountDataSource_basic
=== PAUSE TestAccCloudTrailServiceAccountDataSource_basic
=== RUN   TestAccCloudTrailServiceAccountDataSource_region
=== PAUSE TestAccCloudTrailServiceAccountDataSource_region
=== CONT  TestAccCloudTrailServiceAccountDataSource_basic
=== CONT  TestAccCloudTrailServiceAccountDataSource_region
--- PASS: TestAccCloudTrailServiceAccountDataSource_basic (20.04s)
--- PASS: TestAccCloudTrailServiceAccountDataSource_region (20.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	25.609s
% make testacc TESTARGS='-run=TestAccELBV2HostedZoneIDDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2HostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccELBV2HostedZoneIDDataSource_basic
=== PAUSE TestAccELBV2HostedZoneIDDataSource_basic
=== CONT  TestAccELBV2HostedZoneIDDataSource_basic
--- PASS: TestAccELBV2HostedZoneIDDataSource_basic (57.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	62.604s
% make testacc TESTARGS='-run=TestAccELBHostedZoneIDDataSource_' PKG=elb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 2  -run=TestAccELBHostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (32.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	38.394s
% make testacc TESTARGS='-run=TestAccS3BucketDataSource_basic' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketDataSource_basic -timeout 180m
=== RUN   TestAccS3BucketDataSource_basic
=== PAUSE TestAccS3BucketDataSource_basic
=== CONT  TestAccS3BucketDataSource_basic
--- PASS: TestAccS3BucketDataSource_basic (27.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	33.408s

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 3, 2023
@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/S Managed by automation to categorize the size of a PR. labels Aug 3, 2023
@ewbankkit ewbankkit merged commit c4ea5a2 into main Aug 3, 2023
@ewbankkit ewbankkit deleted the f-il-central-1 branch August 3, 2023 14:23
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 3, 2023
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/s3 Issues and PRs that pertain to the s3 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant