enhancement: add support of tags to filter RDS instances (#2988)

[jeremychauvet]

Description

This MR allow users to filter RDS instances with tags. Usage is the following:

data "aws_db_instances" "this" {
  tag {
    key   = "Team"
    value = "Blue"
  }

 tag {
    key   = "AnotherKey"
    value = "AnotherValue"
  }
}

It output instances ARNs and identifiers, like the current filter.

Relations

Closes #2988

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstancesDataSource_'  -timeout 180m
=== RUN   TestAccRDSInstancesDataSource_filter
=== PAUSE TestAccRDSInstancesDataSource_filter
=== RUN   TestAccRDSInstancesDataSource_tags
=== PAUSE TestAccRDSInstancesDataSource_tags
=== CONT  TestAccRDSInstancesDataSource_filter
=== CONT  TestAccRDSInstancesDataSource_tags
--- PASS: TestAccRDSInstancesDataSource_filter (523.76s)
--- PASS: TestAccRDSInstancesDataSource_tags (523.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        525.859s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jeremychauvet]

Added documentation update, MR is now ready to be reviewed ✅

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_newIdentifier\|TestAccRDSInstance_basic\|TestAccRDSInstance_disappears' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_newIdentifier\|TestAccRDSInstance_basic\|TestAccRDSInstance_disappears -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_disappears
=== PAUSE TestAccRDSInstance_disappears
=== RUN   TestAccRDSInstance_newIdentifier
=== PAUSE TestAccRDSInstance_newIdentifier
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_newIdentifier
--- PASS: TestAccRDSInstance_basic (503.17s)
=== CONT  TestAccRDSInstance_disappears
--- PASS: TestAccRDSInstance_newIdentifier (721.69s)
--- PASS: TestAccRDSInstance_disappears (541.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1049.578s

% make testacc TESTARGS='-run=TestAccRDSInstancesDataSource_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstancesDataSource_ -timeout 180m
=== RUN   TestAccRDSInstancesDataSource_filter
=== PAUSE TestAccRDSInstancesDataSource_filter
=== RUN   TestAccRDSInstancesDataSource_tags
=== PAUSE TestAccRDSInstancesDataSource_tags
=== CONT  TestAccRDSInstancesDataSource_filter
=== CONT  TestAccRDSInstancesDataSource_tags
--- PASS: TestAccRDSInstancesDataSource_filter (483.79s)
--- PASS: TestAccRDSInstancesDataSource_tags (493.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	499.165s

% make testacc TESTARGS='-run=TestAccRDSInstanceDataSource_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstanceDataSource_ -timeout 180m
=== RUN   TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN   TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== RUN   TestAccRDSInstanceDataSource_tags
=== PAUSE TestAccRDSInstanceDataSource_tags
=== CONT  TestAccRDSInstanceDataSource_basic
=== CONT  TestAccRDSInstanceDataSource_tags
--- PASS: TestAccRDSInstanceDataSource_tags (655.55s)
=== CONT  TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSInstanceDataSource_basic (666.92s)
--- PASS: TestAccRDSInstanceDataSource_ManagedMasterPassword_managed (591.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1252.608s

[ewbankkit]

@jeremychauvet Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.