Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional attribute to aws_vpc_endpoint data source #32517

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

justinretzolk
Copy link
Member

Description

This PR adds the private_dns_only_for_inbound_resolver_endpoint attribute to data.aws_vpc_endpoint.dns_options, and documents the data.aws_vpc_endpoint.dns_options block, which was missing from the documentation.

Relations

Closes #32508

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccVPCEndpointDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointDataSource'  -timeout 180m
=== RUN   TestAccVPCEndpointDataSource_gatewayBasic
=== PAUSE TestAccVPCEndpointDataSource_gatewayBasic
=== RUN   TestAccVPCEndpointDataSource_byID
=== PAUSE TestAccVPCEndpointDataSource_byID
=== RUN   TestAccVPCEndpointDataSource_byFilter
=== PAUSE TestAccVPCEndpointDataSource_byFilter
=== RUN   TestAccVPCEndpointDataSource_byTags
=== PAUSE TestAccVPCEndpointDataSource_byTags
=== RUN   TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== PAUSE TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== RUN   TestAccVPCEndpointDataSource_interface
=== PAUSE TestAccVPCEndpointDataSource_interface
=== CONT  TestAccVPCEndpointDataSource_gatewayBasic
=== CONT  TestAccVPCEndpointDataSource_byTags
=== CONT  TestAccVPCEndpointDataSource_byFilter
=== CONT  TestAccVPCEndpointDataSource_interface
=== CONT  TestAccVPCEndpointDataSource_byID
=== CONT  TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
--- PASS: TestAccVPCEndpointDataSource_byID (37.64s)
--- PASS: TestAccVPCEndpointDataSource_byTags (38.11s)
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (38.15s)
--- PASS: TestAccVPCEndpointDataSource_byFilter (38.43s)
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (44.43s)
--- PASS: TestAccVPCEndpointDataSource_interface (203.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        206.810s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@justinretzolk justinretzolk marked this pull request as ready for review July 14, 2023 17:35
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. labels Jul 14, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTS=TestAccVPCEndpointDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointDataSource'  -timeout 180m

--- PASS: TestAccVPCEndpointDataSource_byTags (37.27s)
--- PASS: TestAccVPCEndpointDataSource_byID (37.29s)
--- PASS: TestAccVPCEndpointDataSource_byFilter (37.32s)
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (39.01s)
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (40.96s)
--- PASS: TestAccVPCEndpointDataSource_interface (177.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        180.440s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. labels Jul 14, 2023
@justinretzolk justinretzolk merged commit cfc9826 into main Jul 17, 2023
@justinretzolk justinretzolk deleted the b-vpc_endpoint-private_dns_options branch July 17, 2023 16:32
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 17, 2023
github-actions bot pushed a commit that referenced this pull request Jul 17, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataSource aws_vpc_endpoint errors with private_dns_only_for_inbound_resolver_endpoint
2 participants