update: new data source aws_msk_bootstrap_brokers #32484

kaykhan · 2023-07-12T18:39:19Z

Description

Attempting to add a datasource to fetch the boostrap broker url BootstrapBrokerStringPublicSaslIam for a serverless msk cluster.

Existing datasources do not work with msk serverless cluster.

New command GetBootstrapBrokers works for both serverless and original msk cluster

https://docs.aws.amazon.com/sdk-for-go/api/service/kafka/#Kafka.GetBootstrapBrokers
https://docs.aws.amazon.com/cli/latest/reference/kafka/get-bootstrap-brokers.html

Relations

Closes #32472
Closes #28005

References

https://docs.aws.amazon.com/sdk-for-go/api/service/kafka/#Kafka.GetBootstrapBrokers

aws kafka get-bootstrap-brokers --cluster-arn <ARN> --region <REGION>

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

github-actions · 2023-07-12T18:39:31Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

joaocc · 2023-08-10T23:54:02Z

Hi
Any updates on merging this branch?
We would love to have this deployed, as it seems we don't have any other way to use terraform to connect to a serverless cluster.
Thanks

apd-bscally · 2023-10-09T13:46:37Z

Hi, echoing the previous comment, looking for this functionality

kaykhan · 2023-10-20T09:18:31Z

ewbankkit justinretzolk any chance i could get help with this one

NexRX · 2023-11-17T15:02:10Z

Hi all, is this still being developed? Would be awesome to get this and its great to see the effort. 🤩

% make testacc TESTARGS='-run=TestAccKafkaBootstrapBrokersDataSource_' PKG=kafka ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 20 -run=TestAccKafkaBootstrapBrokersDataSource_ -timeout 360m === RUN TestAccKafkaBootstrapBrokersDataSource_basic === PAUSE TestAccKafkaBootstrapBrokersDataSource_basic === CONT TestAccKafkaBootstrapBrokersDataSource_basic --- PASS: TestAccKafkaBootstrapBrokersDataSource_basic (2010.35s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 2016.099s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaBootstrapBrokersDataSource_\|TestAccKafkaBrokerNodesDataSource_\|TestAccKafkaClusterDataSource_\|TestAccKafkaClusterPolicy_\|TestAccKafkaConfigurationDataSource_\|TestAccKafkaKafkaVersionDataSource_\|TestAccKafkaVPCConnectionDataSource_' PKG=kafka ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 3 -run=TestAccKafkaBootstrapBrokersDataSource_\|TestAccKafkaBrokerNodesDataSource_\|TestAccKafkaClusterDataSource_\|TestAccKafkaClusterPolicy_\|TestAccKafkaConfigurationDataSource_\|TestAccKafkaKafkaVersionDataSource_\|TestAccKafkaVPCConnectionDataSource_ -timeout 720m === RUN TestAccKafkaBootstrapBrokersDataSource_basic === PAUSE TestAccKafkaBootstrapBrokersDataSource_basic === RUN TestAccKafkaBrokerNodesDataSource_basic === PAUSE TestAccKafkaBrokerNodesDataSource_basic === RUN TestAccKafkaClusterDataSource_basic === PAUSE TestAccKafkaClusterDataSource_basic === RUN TestAccKafkaClusterPolicy_basic === PAUSE TestAccKafkaClusterPolicy_basic === RUN TestAccKafkaClusterPolicy_disappears === PAUSE TestAccKafkaClusterPolicy_disappears === RUN TestAccKafkaClusterPolicy_update === PAUSE TestAccKafkaClusterPolicy_update === RUN TestAccKafkaConfigurationDataSource_name === PAUSE TestAccKafkaConfigurationDataSource_name === RUN TestAccKafkaKafkaVersionDataSource_basic === PAUSE TestAccKafkaKafkaVersionDataSource_basic === RUN TestAccKafkaKafkaVersionDataSource_preferred === PAUSE TestAccKafkaKafkaVersionDataSource_preferred === RUN TestAccKafkaVPCConnectionDataSource_basic === PAUSE TestAccKafkaVPCConnectionDataSource_basic === CONT TestAccKafkaBootstrapBrokersDataSource_basic === CONT TestAccKafkaVPCConnectionDataSource_basic === CONT TestAccKafkaKafkaVersionDataSource_preferred --- PASS: TestAccKafkaKafkaVersionDataSource_preferred (13.84s) === CONT TestAccKafkaClusterPolicy_basic --- PASS: TestAccKafkaBootstrapBrokersDataSource_basic (1995.28s) === CONT TestAccKafkaKafkaVersionDataSource_basic --- PASS: TestAccKafkaKafkaVersionDataSource_basic (11.02s) === CONT TestAccKafkaConfigurationDataSource_name --- PASS: TestAccKafkaConfigurationDataSource_name (45.21s) === CONT TestAccKafkaClusterPolicy_update --- PASS: TestAccKafkaClusterPolicy_basic (6209.08s) === CONT TestAccKafkaClusterPolicy_disappears --- PASS: TestAccKafkaVPCConnectionDataSource_basic (6225.98s) === CONT TestAccKafkaBrokerNodesDataSource_basic --- PASS: TestAccKafkaBrokerNodesDataSource_basic (2253.03s) === CONT TestAccKafkaClusterDataSource_basic --- PASS: TestAccKafkaClusterPolicy_update (6474.94s) --- PASS: TestAccKafkaClusterDataSource_basic (1987.09s) --- PASS: TestAccKafkaClusterPolicy_disappears (6714.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 12938.119s

…on: Configuration ARN does not exist' errors on Delete.

…Delete.

ewbankkit

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaBootstrapBrokersDataSource_\|TestAccKafkaBrokerNodesDataSource_\|TestAccKafkaClusterDataSource_\|TestAccKafkaClusterPolicy_\|TestAccKafkaConfigurationDataSource_\|TestAccKafkaKafkaVersionDataSource_\|TestAccKafkaVPCConnectionDataSource_' PKG=kafka ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 3  -run=TestAccKafkaBootstrapBrokersDataSource_\|TestAccKafkaBrokerNodesDataSource_\|TestAccKafkaClusterDataSource_\|TestAccKafkaClusterPolicy_\|TestAccKafkaConfigurationDataSource_\|TestAccKafkaKafkaVersionDataSource_\|TestAccKafkaVPCConnectionDataSource_ -timeout 720m
=== RUN   TestAccKafkaBootstrapBrokersDataSource_basic
=== PAUSE TestAccKafkaBootstrapBrokersDataSource_basic
=== RUN   TestAccKafkaBrokerNodesDataSource_basic
=== PAUSE TestAccKafkaBrokerNodesDataSource_basic
=== RUN   TestAccKafkaClusterDataSource_basic
=== PAUSE TestAccKafkaClusterDataSource_basic
=== RUN   TestAccKafkaClusterPolicy_basic
=== PAUSE TestAccKafkaClusterPolicy_basic
=== RUN   TestAccKafkaClusterPolicy_disappears
=== PAUSE TestAccKafkaClusterPolicy_disappears
=== RUN   TestAccKafkaClusterPolicy_update
=== PAUSE TestAccKafkaClusterPolicy_update
=== RUN   TestAccKafkaConfigurationDataSource_name
=== PAUSE TestAccKafkaConfigurationDataSource_name
=== RUN   TestAccKafkaKafkaVersionDataSource_basic
=== PAUSE TestAccKafkaKafkaVersionDataSource_basic
=== RUN   TestAccKafkaKafkaVersionDataSource_preferred
=== PAUSE TestAccKafkaKafkaVersionDataSource_preferred
=== RUN   TestAccKafkaVPCConnectionDataSource_basic
=== PAUSE TestAccKafkaVPCConnectionDataSource_basic
=== CONT  TestAccKafkaBootstrapBrokersDataSource_basic
=== CONT  TestAccKafkaVPCConnectionDataSource_basic
=== CONT  TestAccKafkaKafkaVersionDataSource_preferred
--- PASS: TestAccKafkaKafkaVersionDataSource_preferred (13.84s)
=== CONT  TestAccKafkaClusterPolicy_basic
--- PASS: TestAccKafkaBootstrapBrokersDataSource_basic (1995.28s)
=== CONT  TestAccKafkaKafkaVersionDataSource_basic
--- PASS: TestAccKafkaKafkaVersionDataSource_basic (11.02s)
=== CONT  TestAccKafkaConfigurationDataSource_name
--- PASS: TestAccKafkaConfigurationDataSource_name (45.21s)
=== CONT  TestAccKafkaClusterPolicy_update
--- PASS: TestAccKafkaClusterPolicy_basic (6209.08s)
=== CONT  TestAccKafkaClusterPolicy_disappears
--- PASS: TestAccKafkaVPCConnectionDataSource_basic (6225.98s)
=== CONT  TestAccKafkaBrokerNodesDataSource_basic
--- PASS: TestAccKafkaBrokerNodesDataSource_basic (2253.03s)
=== CONT  TestAccKafkaClusterDataSource_basic
--- PASS: TestAccKafkaClusterPolicy_update (6474.94s)
--- PASS: TestAccKafkaClusterDataSource_basic (1987.09s)
--- PASS: TestAccKafkaClusterPolicy_disappears (6714.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	12938.119s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaServerlessCluster_\|TestAccKafkaVPCConnection_\|TestAccKafkaScramSecretAssociation_\|TestAccKafkaConfiguration_' PKG=kafka ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 3  -run=TestAccKafkaServerlessCluster_\|TestAccKafkaVPCConnection_\|TestAccKafkaScramSecretAssociation_\|TestAccKafkaConfiguration_ -timeout 720m
=== RUN   TestAccKafkaConfiguration_basic
=== PAUSE TestAccKafkaConfiguration_basic
=== RUN   TestAccKafkaConfiguration_disappears
=== PAUSE TestAccKafkaConfiguration_disappears
=== RUN   TestAccKafkaConfiguration_description
=== PAUSE TestAccKafkaConfiguration_description
=== RUN   TestAccKafkaConfiguration_kafkaVersions
=== PAUSE TestAccKafkaConfiguration_kafkaVersions
=== RUN   TestAccKafkaConfiguration_serverProperties
=== PAUSE TestAccKafkaConfiguration_serverProperties
=== RUN   TestAccKafkaScramSecretAssociation_basic
=== PAUSE TestAccKafkaScramSecretAssociation_basic
=== RUN   TestAccKafkaScramSecretAssociation_update
=== PAUSE TestAccKafkaScramSecretAssociation_update
=== RUN   TestAccKafkaScramSecretAssociation_disappears
=== PAUSE TestAccKafkaScramSecretAssociation_disappears
=== RUN   TestAccKafkaScramSecretAssociation_Disappears_cluster
=== PAUSE TestAccKafkaScramSecretAssociation_Disappears_cluster
=== RUN   TestAccKafkaServerlessCluster_basic
=== PAUSE TestAccKafkaServerlessCluster_basic
=== RUN   TestAccKafkaServerlessCluster_disappears
=== PAUSE TestAccKafkaServerlessCluster_disappears
=== RUN   TestAccKafkaServerlessCluster_tags
=== PAUSE TestAccKafkaServerlessCluster_tags
=== RUN   TestAccKafkaServerlessCluster_securityGroup
=== PAUSE TestAccKafkaServerlessCluster_securityGroup
=== RUN   TestAccKafkaVPCConnection_basic
=== PAUSE TestAccKafkaVPCConnection_basic
=== RUN   TestAccKafkaVPCConnection_tags
=== PAUSE TestAccKafkaVPCConnection_tags
=== RUN   TestAccKafkaVPCConnection_disappears
=== PAUSE TestAccKafkaVPCConnection_disappears
=== CONT  TestAccKafkaConfiguration_basic
=== CONT  TestAccKafkaScramSecretAssociation_Disappears_cluster
=== CONT  TestAccKafkaConfiguration_serverProperties
--- PASS: TestAccKafkaConfiguration_basic (23.35s)
=== CONT  TestAccKafkaServerlessCluster_securityGroup
--- PASS: TestAccKafkaConfiguration_serverProperties (38.68s)
=== CONT  TestAccKafkaVPCConnection_disappears
--- PASS: TestAccKafkaServerlessCluster_securityGroup (181.34s)
=== CONT  TestAccKafkaVPCConnection_tags
--- PASS: TestAccKafkaScramSecretAssociation_Disappears_cluster (2044.31s)
=== CONT  TestAccKafkaVPCConnection_basic
--- PASS: TestAccKafkaVPCConnection_tags (6153.11s)
=== CONT  TestAccKafkaScramSecretAssociation_update
--- PASS: TestAccKafkaVPCConnection_disappears (6326.22s)
=== CONT  TestAccKafkaScramSecretAssociation_disappears
--- PASS: TestAccKafkaScramSecretAssociation_disappears (1784.09s)
=== CONT  TestAccKafkaConfiguration_description
--- PASS: TestAccKafkaConfiguration_description (79.34s)
=== CONT  TestAccKafkaConfiguration_kafkaVersions
--- PASS: TestAccKafkaConfiguration_kafkaVersions (22.31s)
=== CONT  TestAccKafkaScramSecretAssociation_basic
--- PASS: TestAccKafkaScramSecretAssociation_update (2163.80s)
=== CONT  TestAccKafkaConfiguration_disappears
--- PASS: TestAccKafkaConfiguration_disappears (22.86s)
=== CONT  TestAccKafkaServerlessCluster_disappears
--- PASS: TestAccKafkaVPCConnection_basic (6613.02s)
=== CONT  TestAccKafkaServerlessCluster_tags
--- PASS: TestAccKafkaServerlessCluster_disappears (187.21s)
=== CONT  TestAccKafkaServerlessCluster_basic
--- PASS: TestAccKafkaServerlessCluster_tags (218.01s)
--- PASS: TestAccKafkaServerlessCluster_basic (260.81s)
--- PASS: TestAccKafkaScramSecretAssociation_basic (2066.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	10419.727s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaCluster_' PKG=kafka ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 3  -run=TestAccKafkaCluster_ -timeout 720m
=== RUN   TestAccKafkaCluster_basic
=== PAUSE TestAccKafkaCluster_basic
=== RUN   TestAccKafkaCluster_disappears
=== PAUSE TestAccKafkaCluster_disappears
=== RUN   TestAccKafkaCluster_tags
=== PAUSE TestAccKafkaCluster_tags
=== RUN   TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo
=== RUN   TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType
=== RUN   TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM
=== RUN   TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity
=== RUN   TestAccKafkaCluster_ClientAuthenticationSASL_scram
=== PAUSE TestAccKafkaCluster_ClientAuthenticationSASL_scram
=== RUN   TestAccKafkaCluster_ClientAuthenticationSASL_iam
=== PAUSE TestAccKafkaCluster_ClientAuthenticationSASL_iam
=== RUN   TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs
=== PAUSE TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs
=== RUN   TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication
=== PAUSE TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication
=== RUN   TestAccKafkaCluster_Info_revision
=== PAUSE TestAccKafkaCluster_Info_revision
=== RUN   TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN
=== PAUSE TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN
=== RUN   TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker
=== PAUSE TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker
=== RUN   TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster
=== PAUSE TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster
=== RUN   TestAccKafkaCluster_enhancedMonitoring
=== PAUSE TestAccKafkaCluster_enhancedMonitoring
=== RUN   TestAccKafkaCluster_numberOfBrokerNodes
=== PAUSE TestAccKafkaCluster_numberOfBrokerNodes
=== RUN   TestAccKafkaCluster_openMonitoring
=== PAUSE TestAccKafkaCluster_openMonitoring
=== RUN   TestAccKafkaCluster_storageMode
=== PAUSE TestAccKafkaCluster_storageMode
=== RUN   TestAccKafkaCluster_loggingInfo
=== PAUSE TestAccKafkaCluster_loggingInfo
=== RUN   TestAccKafkaCluster_kafkaVersionUpgrade
=== PAUSE TestAccKafkaCluster_kafkaVersionUpgrade
=== RUN   TestAccKafkaCluster_kafkaVersionDowngrade
=== PAUSE TestAccKafkaCluster_kafkaVersionDowngrade
=== RUN   TestAccKafkaCluster_kafkaVersionUpgradeWithInfo
=== PAUSE TestAccKafkaCluster_kafkaVersionUpgradeWithInfo
=== CONT  TestAccKafkaCluster_basic
=== CONT  TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN
=== CONT  TestAccKafkaCluster_storageMode
--- PASS: TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN (2072.83s)
=== CONT  TestAccKafkaCluster_kafkaVersionUpgradeWithInfo
--- PASS: TestAccKafkaCluster_basic (2082.98s)
=== CONT  TestAccKafkaCluster_kafkaVersionDowngrade
--- PASS: TestAccKafkaCluster_storageMode (3072.02s)
=== CONT  TestAccKafkaCluster_kafkaVersionUpgrade
--- PASS: TestAccKafkaCluster_kafkaVersionDowngrade (4551.30s)
=== CONT  TestAccKafkaCluster_loggingInfo
--- PASS: TestAccKafkaCluster_kafkaVersionUpgradeWithInfo (6826.36s)
=== CONT  TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs
--- PASS: TestAccKafkaCluster_loggingInfo (2428.23s)
=== CONT  TestAccKafkaCluster_Info_revision
--- PASS: TestAccKafkaCluster_kafkaVersionUpgrade (7003.90s)
=== CONT  TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication
--- PASS: TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs (2293.01s)
=== CONT  TestAccKafkaCluster_ClientAuthenticationSASL_iam
--- PASS: TestAccKafkaCluster_Info_revision (2690.34s)
=== CONT  TestAccKafkaCluster_ClientAuthenticationSASL_scram
--- PASS: TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication (4381.02s)
=== CONT  TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo
--- PASS: TestAccKafkaCluster_ClientAuthenticationSASL_iam (4402.25s)
=== CONT  TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM
--- PASS: TestAccKafkaCluster_ClientAuthenticationSASL_scram (4011.36s)
=== CONT  TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo (2466.10s)
=== CONT  TestAccKafkaCluster_enhancedMonitoring
--- PASS: TestAccKafkaCluster_enhancedMonitoring (2254.81s)
=== CONT  TestAccKafkaCluster_openMonitoring
--- PASS: TestAccKafkaCluster_openMonitoring (1200.96s)
=== CONT  TestAccKafkaCluster_numberOfBrokerNodes
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM (4821.43s)
=== CONT  TestAccKafkaCluster_tags
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType (5988.85s)
=== CONT  TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster
--- PASS: TestAccKafkaCluster_tags (1962.64s)
=== CONT  TestAccKafkaCluster_disappears
--- PASS: TestAccKafkaCluster_numberOfBrokerNodes (3502.55s)
=== CONT  TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity
--- PASS: TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster (2134.46s)
=== CONT  TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker
--- PASS: TestAccKafkaCluster_disappears (1546.30s)
--- PASS: TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker (2045.99s)
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity (5949.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	27314.439s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaReplicator_update' PKG=kafka
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 20  -run=TestAccKafkaReplicator_update -timeout 720m
=== RUN   TestAccKafkaReplicator_update
=== PAUSE TestAccKafkaReplicator_update
=== CONT  TestAccKafkaReplicator_update
--- PASS: TestAccKafkaReplicator_update (6791.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	6797.636s

ewbankkit · 2024-01-11T12:55:52Z

@kaykhan Thanks for the contribution 🎉 👏.

kaykhan · 2024-01-11T13:01:18Z

@kaykhan Thanks for the contribution 🎉 👏.

appreciate your help, thanks!

yermulnik · 2024-01-11T13:40:03Z

website/docs/d/msk_bootstrap_brokers.html.markdown

+## Example Usage
+
+```terraform
+data "aws_msk_cluster" "example" {


aws_msk_cluster should probably be aws_msk_bootstrap_brokers?

yermulnik · 2024-01-11T13:44:02Z

website/docs/d/msk_bootstrap_brokers.html.markdown

+
+# Data Source: aws_msk_bootstrap_brokers
+
+Get a list of brokers that a client application can use to bootstrap.


May probably make sense to add a note on what's the difference as opposite to aws_msk_broker_nodes data source? 🤔

github-actions · 2024-01-12T12:49:36Z

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-02-12T02:04:59Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

update: aws msk bootstrap brokers

fae3d16

github-actions bot added size/M Managed by automation to categorize the size of a PR. service/kafka Issues and PRs that pertain to the kafka service. needs-triage Waiting for first response or review from a maintainer. labels Jul 12, 2023

kaykhan changed the title ~~update: aws msk bootstrap brokers~~ update: new data source aws_msk_bootstrap_brokers Jul 12, 2023

kaykhan added 2 commits July 12, 2023 19:52

update: aws msk bootstrap brokers

bf1bbfb

update: aws msk bootstrap brokers

7228ac1

kaykhan mentioned this pull request Jul 12, 2023

[Enhancement]: aws_msk_serverless_cluster to return bootstrap server url #28005

Closed

justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 12, 2023

kaykhan added 4 commits October 20, 2023 08:50

update: add test file for aws msk bootstrap brokers

bd4161e

update: msk bootstrap broker fix test

c73f997

update: msk bootstrap broker fix lint

2dc7315

update(docs): msk bootstrap brokers

64e2309

ewbankkit added 11 commits January 8, 2024 17:04

Merge branch 'main' into HEAD

87b4c67

Add CHANGELOG entry.

fc4a4dd

Fix 'TestAccKafkaBootstrapBrokersDataSource_basic'.

2fda7cc

kafka: Add and use 'findBootstrapBrokersByARN'.

b29569f

d/aws_msk_bootstrap_brokers: Attribute names match 'aws_msk_cluster'.

8fcc5a5

testAccBootstrapBrokersDataSourceConfig_basic: Use 'aws_msk_cluster'.

5d3dba4

kafka: AWS SDK for Go v2 exclusively.

78e1ff2

Run 'make gen'.

f66eac6

r/aws_msk_vpc_connection: Migrate to AWS SDK for Go v2.

8c08ba6

d/aws_msk_vpc_connection: Migrate to AWS SDK for Go v2.

3e20ef8

ewbankkit added 19 commits January 9, 2024 10:11

r/aws_msk_configuration: Migrate to AWS SDK for Go v2.

b7af48d

d/aws_msk_configuration: Migrate to AWS SDK for Go v2.

b1be4af

d/aws_msk_kafka_version: Migrate to AWS SDK for Go v2.

cfeddde

r/aws_msk_scram_secret_association: Migrate to AWS SDK for Go v2.

fb2643e

r/aws_msk_replicator: Migrate to AWS SDK for Go v2.

1ff05af

r/aws_msk_cluster: Migrate to AWS SDK for Go v2.

90fc101

d/aws_msk_cluster: Migrate to AWS SDK for Go v2.

0785751

d/aws_msk_broker_nodes: Migrate to AWS SDK for Go v2.

c73db12

d/aws_msk_bootstrap_brokers: Migrate to AWS SDK for Go v2.

a34a2cf

r/aws_msk_serverless_cluster: Migrate to AWS SDK for Go v2.

2a134fc

kafka: Migrate sweepers to AWS SDK for Go v2.

84c5e97

r/aws_msk_cluster_policy: Migrate to AWS SDK for Go v2.

8e26453

kafka: Migrate acceptance tests to AWS SDK for Go v2.

c9ec3a9

Fix semgrep 'ci.kafka-in-func-name'.

f35b174

Fix semgrep 'ci.msk-in-func-name'.

b2465e7

Fix 'findKafkaVersion'.

26aee42

Fix 'operation error Kafka: DeleteConfiguration ... BadRequestExcepti…

662f867

…on: Configuration ARN does not exist' errors on Delete.

Fix 'InvalidSecretArn: The provided secret ARN is invalid' errors on …

a73e318

…Delete.

ewbankkit approved these changes Jan 11, 2024

View reviewed changes

ewbankkit merged commit 1919fbe into hashicorp:main Jan 11, 2024
44 checks passed

github-actions bot added this to the v5.32.0 milestone Jan 11, 2024

yermulnik reviewed Jan 11, 2024

View reviewed changes

github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update: new data source aws_msk_bootstrap_brokers #32484

update: new data source aws_msk_bootstrap_brokers #32484

kaykhan commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 12, 2023

joaocc commented Aug 10, 2023

apd-bscally commented Oct 9, 2023

kaykhan commented Oct 20, 2023

NexRX commented Nov 17, 2023

ewbankkit left a comment

ewbankkit commented Jan 11, 2024

kaykhan commented Jan 11, 2024

yermulnik Jan 11, 2024

yermulnik Jan 11, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Feb 12, 2024


		# Data Source: aws_msk_bootstrap_brokers

		Get a list of brokers that a client application can use to bootstrap.

update: new data source aws_msk_bootstrap_brokers #32484

update: new data source aws_msk_bootstrap_brokers #32484

Conversation

kaykhan commented Jul 12, 2023 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jul 12, 2023

Community Note

joaocc commented Aug 10, 2023

apd-bscally commented Oct 9, 2023

kaykhan commented Oct 20, 2023

NexRX commented Nov 17, 2023

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jan 11, 2024

kaykhan commented Jan 11, 2024

yermulnik Jan 11, 2024

Choose a reason for hiding this comment

yermulnik Jan 11, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2024

github-actions bot commented Feb 12, 2024

kaykhan commented Jul 12, 2023 •

edited

Loading