Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_workspaces_connection_alias #32482

Merged

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Jul 12, 2023

Description

This Pull request adds the aws_workspaces_connection_alias terraform resource.

Relations

Relates #16416

References

Output from Acceptance Testing

$  make testacc TESTARGS='-run=TestAccWorkSpacesConnectionAlias_' PKG=workspaces
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/workspaces/... -v -count 1 -parallel 20  -run=TestAccWorkSpacesConnectionAlias_ -timeout 180m
=== RUN   TestAccWorkSpacesConnectionAlias_basic
=== PAUSE TestAccWorkSpacesConnectionAlias_basic
=== RUN   TestAccWorkSpacesConnectionAlias_disappears
=== PAUSE TestAccWorkSpacesConnectionAlias_disappears
=== RUN   TestAccWorkSpacesConnectionAlias_tags
=== PAUSE TestAccWorkSpacesConnectionAlias_tags
=== CONT  TestAccWorkSpacesConnectionAlias_basic
=== CONT  TestAccWorkSpacesConnectionAlias_tags
=== CONT  TestAccWorkSpacesConnectionAlias_disappears
--- PASS: TestAccWorkSpacesConnectionAlias_disappears (19.41s)
--- PASS: TestAccWorkSpacesConnectionAlias_basic (26.59s)
--- PASS: TestAccWorkSpacesConnectionAlias_tags (50.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspaces 54.113s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/workspaces Issues and PRs that pertain to the workspaces service. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 12, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 12, 2023
@brittandeyoung brittandeyoung changed the title [WIP] New Resource: aws_workspaces_connection_alias New Resource: aws_workspaces_connection_alias Jul 14, 2023
@brittandeyoung
Copy link
Collaborator Author

The failing test is not code that I have modified

@ewbankkit ewbankkit self-assigned this Jul 20, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccWorkSpacesConnectionAlias_' PKG=workspaces ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/workspaces/... -v -count 1 -parallel 2  -run=TestAccWorkSpacesConnectionAlias_ -timeout 180m
=== RUN   TestAccWorkSpacesConnectionAlias_basic
=== PAUSE TestAccWorkSpacesConnectionAlias_basic
=== RUN   TestAccWorkSpacesConnectionAlias_disappears
=== PAUSE TestAccWorkSpacesConnectionAlias_disappears
=== RUN   TestAccWorkSpacesConnectionAlias_tags
=== PAUSE TestAccWorkSpacesConnectionAlias_tags
=== CONT  TestAccWorkSpacesConnectionAlias_basic
=== CONT  TestAccWorkSpacesConnectionAlias_tags
--- PASS: TestAccWorkSpacesConnectionAlias_basic (39.14s)
=== CONT  TestAccWorkSpacesConnectionAlias_disappears
--- PASS: TestAccWorkSpacesConnectionAlias_disappears (27.99s)
--- PASS: TestAccWorkSpacesConnectionAlias_tags (88.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	94.449s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3e5d447 into hashicorp:main Jul 20, 2023
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 20, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants