Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_globalaccelerator_custom_routing_endpoint_group: honor endpoint_group_region attribute #32393

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

djordje-ch
Copy link
Contributor

@djordje-ch djordje-ch commented Jul 6, 2023

Description

Resource aws_globalaccelerator_custom_routing_endpoint_group currently doesn't apply the set endpoint_group_region and it falls back to provider default region.
This PR addresses the issue described in #32375

Relations

Closes #32375

Output from Acceptance Testing

$ make testacc TESTS=TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration PKG=globalaccelerator
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration'  -timeout 180m
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration (644.71s)
PASS

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @djordje-ch 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 6, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 19, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlobalAcceleratorCustomRoutingEndpointGroup_' PKG=globalaccelerator ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2  -run=TestAccGlobalAcceleratorCustomRoutingEndpointGroup_ -timeout 180m
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic (170.62s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion (170.62s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears (154.78s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration (647.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	824.400s

@ewbankkit
Copy link
Contributor

@djordje-ch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 993689b into hashicorp:main Jul 19, 2023
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 19, 2023
@djordje-ch djordje-ch deleted the b-custom-routing-endpoint-region branch July 20, 2023 09:40
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_globalaccelerator_custom_routing_endpoint_group doesn't apply endpoint_group_region attribute
3 participants