-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_globalaccelerator_custom_routing_endpoint_group: honor endpoint_group_region attribute #32393
r/aws_globalaccelerator_custom_routing_endpoint_group: honor endpoint_group_region attribute #32393
Conversation
…_group_region set
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @djordje-ch 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGlobalAcceleratorCustomRoutingEndpointGroup_' PKG=globalaccelerator ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2 -run=TestAccGlobalAcceleratorCustomRoutingEndpointGroup_ -timeout 180m
=== RUN TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== RUN TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
=== RUN TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== RUN TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
=== CONT TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== CONT TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic (170.62s)
=== CONT TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion (170.62s)
=== CONT TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears (154.78s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration (647.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator 824.400s
@djordje-ch Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Resource aws_globalaccelerator_custom_routing_endpoint_group currently doesn't apply the set endpoint_group_region and it falls back to provider default region.
This PR addresses the issue described in #32375
Relations
Closes #32375
Output from Acceptance Testing