F codecatalyst devenv

[markoskandylis]

Description

Adds support for CodeCatalyst Dev Environment

Relations

Closes #31286

References

go reference: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/codecatalyst
sdk reference: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-codecatalyst/

Output from Acceptance Testing

$  make testacc TESTARGS='-run=TestAccCodeCatalystDevenvironment_' PKG=codecatalyst  ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecatalyst/... -v -count 1 -parallel 2  -run=TestAccCodeCatalystDevenvironment_ -timeout 180m
=== RUN   TestAccCodeCatalystDevenvironment_basic
=== PAUSE TestAccCodeCatalystDevenvironment_basic
=== RUN   TestAccCodeCatalystDevenvironment_withRepositories
=== PAUSE TestAccCodeCatalystDevenvironment_withRepositories
=== RUN   TestAccCodeCatalystDevenvironment_disappears
=== PAUSE TestAccCodeCatalystDevenvironment_disappears
=== CONT  TestAccCodeCatalystDevenvironment_basic
=== CONT  TestAccCodeCatalystDevenvironment_disappears
--- PASS: TestAccCodeCatalystDevenvironment_disappears (35.51s)
=== CONT  TestAccCodeCatalystDevenvironment_withRepositories
--- PASS: TestAccCodeCatalystDevenvironment_basic (39.53s)
--- PASS: TestAccCodeCatalystDevenvironment_withRepositories (353.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codecatalyst       392.338s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[markoskandylis]

hi @ewbankkit do you want me to create a new pull request for this new service to fix all those conflics in a cleaner code?

[ewbankkit]

@markoskandylis Thanks for the contribution 🎉 👏.
In general everything looks great.
I think we should rename the resource type to aws_codecatalyst_dev_environment to match the AWS CLI commands (e.g. aws codecatalyst list-dev-environments).

[markoskandylis]

@ewbankkit thanks i will do this change tomorrow there are couple of more resources coming for this service as well :) thanks for the help :)

[markoskandylis]

hi @ewbankkit Here is the new tests with the new name

make testacc TESTARGS='-run=TestAccCodeCatalystDevEnvironment_' PKG=codecatalyst ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecatalyst/... -v -count 1 -parallel 3 -run=TestAccCodeCatalystDevEnvironment_ -timeout 180m
=== RUN TestAccCodeCatalystDevEnvironment_basic
=== PAUSE TestAccCodeCatalystDevEnvironment_basic
=== RUN TestAccCodeCatalystDevEnvironment_withRepositories
=== PAUSE TestAccCodeCatalystDevEnvironment_withRepositories
=== RUN TestAccCodeCatalystDevEnvironment_disappears
=== PAUSE TestAccCodeCatalystDevEnvironment_disappears
=== CONT TestAccCodeCatalystDevEnvironment_basic
=== CONT TestAccCodeCatalystDevEnvironment_disappears
=== CONT TestAccCodeCatalystDevEnvironment_withRepositories
--- PASS: TestAccCodeCatalystDevEnvironment_disappears (38.36s)
--- PASS: TestAccCodeCatalystDevEnvironment_basic (42.48s)
--- PASS: TestAccCodeCatalystDevEnvironment_withRepositories (374.72s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codecatalyst 377.520s

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeCatalystDevEnvironment_' PKG=codecatalyst 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecatalyst/... -v -count 1 -parallel 20  -run=TestAccCodeCatalystDevEnvironment_ -timeout 180m
=== RUN   TestAccCodeCatalystDevEnvironment_basic
=== PAUSE TestAccCodeCatalystDevEnvironment_basic
=== RUN   TestAccCodeCatalystDevEnvironment_withRepositories
=== PAUSE TestAccCodeCatalystDevEnvironment_withRepositories
=== RUN   TestAccCodeCatalystDevEnvironment_disappears
=== PAUSE TestAccCodeCatalystDevEnvironment_disappears
=== CONT  TestAccCodeCatalystDevEnvironment_basic
=== CONT  TestAccCodeCatalystDevEnvironment_disappears
=== CONT  TestAccCodeCatalystDevEnvironment_withRepositories
=== NAME  TestAccCodeCatalystDevEnvironment_disappears
    dev_environment_test.go:190: skipping acceptance testing: runtime error: invalid memory address or nil pointer dereference
=== NAME  TestAccCodeCatalystDevEnvironment_withRepositories
    dev_environment_test.go:190: skipping acceptance testing: runtime error: invalid memory address or nil pointer dereference
--- SKIP: TestAccCodeCatalystDevEnvironment_withRepositories (0.44s)
--- SKIP: TestAccCodeCatalystDevEnvironment_disappears (0.44s)
=== NAME  TestAccCodeCatalystDevEnvironment_basic
    dev_environment_test.go:190: skipping acceptance testing: runtime error: invalid memory address or nil pointer dereference
--- SKIP: TestAccCodeCatalystDevEnvironment_basic (0.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecatalyst	6.013s

[ewbankkit]

@markoskandylis Thanks for the contribution 🎉 👏.
Maintainers don't have the ability to test this.
I modified testAccPreCheck to skip the acceptance tests if no Amazon CodeCatalyst token is available.

[github-actions]

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.