Fix InvalidArgument: Invalid attribute name specified errors listing S3 Bucket objects

[ewbankkit]

Description

Upgrade to AWS SDK for Go v1.44.293, pulling in aws/aws-sdk-go#4898, fixing InvalidArgument: Invalid attribute name specified errors when listing S3 Bucket objects.

Relations

Closes #32307.
Relates #32305.

References

Output from Acceptance Testing

Before

% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_forceDestroy' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3Bucket_Basic_forceDestroy -timeout 180m
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroy
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== NAME  TestAccS3Bucket_Basic_forceDestroy
    testing_new.go:88: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: emptying S3 Bucket (tf-test-bucket-651917069507294545): listing S3 Bucket (tf-test-bucket-651917069507294545) object versions: InvalidArgument: Invalid attribute name specified.
        	status code: 400, request id: G449VFRM31B0KEN5, host id: iVAzEEB0C/FUsr2cTq5O6c+tUHH1Qm18hucAgm1Je2tBTNPXfzdALFcbJ/rIiJWVcjf+Bz3Mo7L6te2ZrZhkBA==
        
--- FAIL: TestAccS3Bucket_Basic_forceDestroy (25.18s)
=== NAME  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
    testing_new.go:88: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: emptying S3 Bucket (tf-test-bucket-1605337867397239643): listing S3 Bucket (tf-test-bucket-1605337867397239643) object versions: InvalidArgument: Invalid attribute name specified.
        	status code: 400, request id: WKNQCAMCD3S31YZ0, host id: sWQfgZSRTjVQdWcYBcieLLDlBFfJZSl5yvTw3WeYXfBtDz9bE8mC+38iYNub36JS+oPQsV31ed5Iv4aR1RQYQg==
        
--- FAIL: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (25.57s)
=== NAME  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
    testing_new.go:88: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: emptying S3 Bucket (tf-test-bucket-1252849445345403731): listing S3 Bucket (tf-test-bucket-1252849445345403731) object versions: InvalidArgument: Invalid attribute name specified.
        	status code: 400, request id: Q34KWPC5BVCHBV6E, host id: sTtHLTw4jiD7ld76frLtyaCxBEBrkRcGeylh6FAWN+0JzEUVsw7sK/FcN5c3M2o0VXoKZ9bTSyPWVeTbwzmIAg==
        
--- FAIL: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (28.52s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/s3	33.600s
FAIL
make: *** [testacc] Error 1

After

% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_forceDestroy' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3Bucket_Basic_forceDestroy -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.293
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroy
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Basic_forceDestroy (28.77s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (28.77s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (32.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	38.175s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

Might be worth a changelog to indicate the fix was made upstream.

$ make testacc PKG=s3 TESTS=TestAccS3Bucket_Basic_forceDestroy
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_Basic_forceDestroy'  -timeout 180m

--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (21.15s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (21.35s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (24.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 28.171s

[ewbankkit]

Blame added: https://github.com/hashicorp/terraform-provider-aws/pull/32317/files#diff-b20551d9ba5cf72c70f83c7a98d8e53a1d08f4a3d4a859b7c4771b4184d9510dR2

[github-actions]

This functionality has been released in v5.6.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.