Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data source]: aws_opensearchserverless_collection #32247

Merged
merged 10 commits into from
Jun 28, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jun 27, 2023

Description

new data source for aws_opensearchserverless_collection

Relations

Closes #28463

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccOpenSearchServerlessCollectionDataSource_' PKG=opensearchserverless

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20  -run=TestAccOpenSearchServerlessCollectionDataSource_ -timeout 180m
--- PASS: TestAccOpenSearchServerlessCollectionDataSource_name (707.76s)
--- PASS: TestAccOpenSearchServerlessCollectionDataSource_basic (707.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	711.213s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 27, 2023
@johnsonaj johnsonaj added the new-data-source Introduces a new data source. label Jun 27, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 27, 2023
@johnsonaj johnsonaj marked this pull request as ready for review June 27, 2023 20:08
@johnsonaj johnsonaj force-pushed the f-opensearchserverless_access_collection_ds branch from e985e29 to 8e2acd8 Compare June 27, 2023 20:47
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccOpenSearchServerlessCollectionDataSource_' PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20  -run=TestAccOpenSearchServerlessCollectionDataSource_ -timeout 180m

--- PASS: TestAccOpenSearchServerlessCollectionDataSource_basic (727.35s)
--- PASS: TestAccOpenSearchServerlessCollectionDataSource_name (737.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless       740.608s

@johnsonaj johnsonaj merged commit 7990b87 into main Jun 28, 2023
@johnsonaj johnsonaj deleted the f-opensearchserverless_access_collection_ds branch June 28, 2023 16:12
@github-actions github-actions bot added this to the v5.6.0 milestone Jun 28, 2023
github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: OpenSearch Serverless Collection
2 participants