Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_vpc_route_read_error #32196

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Conversation

mechaHarry
Copy link

@mechaHarry mechaHarry commented Jun 23, 2023

Description

Implements retry wrapping logic for reading routes in order to fix eventual consistency issues with reading routes during terraform runtime.

TODO:

  • Write Acceptance Test.
  • Update Changelog.

Relations

Relates #30993.
Closes #31679.
Closes #32219.
Relates #32016.
Relates #30999.
Relates #30994.

References

Output from Acceptance Testing

Was not able to identify a corresponding test case.

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. labels Jun 23, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mechaHarry 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added eventual-consistency Pertains to eventual consistency issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 26, 2023
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 26, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCRoute_basic$$\|TestAccVPCRoute_disappears\|TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCRoute_basic$\|TestAccVPCRoute_disappears\|TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway -timeout 180m
=== RUN   TestAccVPCRoute_basic
=== PAUSE TestAccVPCRoute_basic
=== RUN   TestAccVPCRoute_disappears
=== PAUSE TestAccVPCRoute_disappears
=== RUN   TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway
=== PAUSE TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway
=== CONT  TestAccVPCRoute_basic
=== CONT  TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway
=== CONT  TestAccVPCRoute_disappears
--- PASS: TestAccVPCRoute_disappears (31.38s)
--- PASS: TestAccVPCRoute_basic (35.31s)
--- PASS: TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway (58.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	63.929s

@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eventual-consistency Pertains to eventual consistency issues. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2 Issues and PRs that pertain to the ec2 service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants