r/aws_vpclattice_access_log_subscription: Show actionable error message when CloudWatch Logs destination_arn is not suffixed with wildcard

[exoego]

Description

When CloudWatch Logs is the destination, destination_arn should end with :*.
So, if the given destination_arn does not end with :*, actionable error message is shown.

Relations

Closes #31595

References

N/A

Output from Acceptance Testing

BEFORE (without fixes)

❯ make testacc TESTS=TestAccVPCLatticeAccessLogSubscription_ PKG=vpclattice

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeAccessLogSubscription_'  -timeout 180m
=== RUN   TestAccVPCLatticeAccessLogSubscription_basic
=== PAUSE TestAccVPCLatticeAccessLogSubscription_basic
=== RUN   TestAccVPCLatticeAccessLogSubscription_disappears
=== PAUSE TestAccVPCLatticeAccessLogSubscription_disappears
=== RUN   TestAccVPCLatticeAccessLogSubscription_tags
=== PAUSE TestAccVPCLatticeAccessLogSubscription_tags
=== RUN   TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard
=== PAUSE TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard
=== RUN   TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
=== PAUSE TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_basic
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_tags
=== CONT  TestAccVPCLatticeAccessLogSubscription_disappears
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
    access_log_subscription_test.go:168: Step 1/1, expected an error with pattern, no match on: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement
        
        Terraform will perform the following actions:
        
          # aws_vpclattice_access_log_subscription.test must be replaced
        -/+ resource "aws_vpclattice_access_log_subscription" "test" {
              ~ arn                 = "arn:aws:vpc-lattice:us-west-2:523683666290:accesslogsubscription/als-0c23d9c173fc29692" -> (known after apply)
              ~ destination_arn     = "arn:aws:logs:us-west-2:523683666290:log-group:/aws/vpclattice/tf-acc-test-778914506082713889:*" -> "arn:aws:logs:us-west-2:523683666290:log-group:/aws/vpclattice/tf-acc-test-778914506082713889" # forces replacement
              ~ id                  = "als-0c23d9c173fc29692" -> (known after apply)
              ~ resource_arn        = "arn:aws:vpc-lattice:us-west-2:523683666290:servicenetwork/sn-0f21f608d9001de1b" -> (known after apply)
              ~ tags_all            = {} -> (known after apply)
                # (1 unchanged attribute hidden)
            }
        
        Plan: 1 to add, 0 to change, 1 to destroy.
--- FAIL: TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard (27.58s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard (34.42s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_disappears (47.58s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_basic (72.18s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_tags (117.09s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 120.204s
FAIL
make: *** [testacc] Error 1

AFTER (with fixes)

$ make testacc TESTS=TestAccVPCLatticeAccessLogSubscription_ PKG=vpclattice 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeAccessLogSubscription_'  -timeout 180m
=== RUN   TestAccVPCLatticeAccessLogSubscription_basic
=== PAUSE TestAccVPCLatticeAccessLogSubscription_basic
=== RUN   TestAccVPCLatticeAccessLogSubscription_disappears
=== PAUSE TestAccVPCLatticeAccessLogSubscription_disappears
=== RUN   TestAccVPCLatticeAccessLogSubscription_tags
=== PAUSE TestAccVPCLatticeAccessLogSubscription_tags
=== RUN   TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard
=== PAUSE TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard
=== RUN   TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
=== PAUSE TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_basic
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_tags
=== CONT  TestAccVPCLatticeAccessLogSubscription_disappears
--- PASS: TestAccVPCLatticeAccessLogSubscription_cloudwatch_fail_without_wildcard (19.77s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_cloudwatch_wildcard (32.53s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_basic (48.15s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_disappears (61.12s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_tags (111.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 114.658s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeAccessLogSubscription_' PKG=vpclattice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2  -run=TestAccVPCLatticeAccessLogSubscription_ -timeout 180m
=== RUN   TestAccVPCLatticeAccessLogSubscription_basic
=== PAUSE TestAccVPCLatticeAccessLogSubscription_basic
=== RUN   TestAccVPCLatticeAccessLogSubscription_disappears
=== PAUSE TestAccVPCLatticeAccessLogSubscription_disappears
=== RUN   TestAccVPCLatticeAccessLogSubscription_arn
=== PAUSE TestAccVPCLatticeAccessLogSubscription_arn
=== RUN   TestAccVPCLatticeAccessLogSubscription_tags
=== PAUSE TestAccVPCLatticeAccessLogSubscription_tags
=== RUN   TestAccVPCLatticeAccessLogSubscription_cloudwatchNoWildcard
=== PAUSE TestAccVPCLatticeAccessLogSubscription_cloudwatchNoWildcard
=== RUN   TestAccVPCLatticeAccessLogSubscription_cloudwatchWildcard
=== PAUSE TestAccVPCLatticeAccessLogSubscription_cloudwatchWildcard
=== CONT  TestAccVPCLatticeAccessLogSubscription_basic
=== CONT  TestAccVPCLatticeAccessLogSubscription_tags
--- PASS: TestAccVPCLatticeAccessLogSubscription_basic (33.08s)
=== CONT  TestAccVPCLatticeAccessLogSubscription_arn
--- PASS: TestAccVPCLatticeAccessLogSubscription_arn (31.52s)
=== CONT  TestAccVPCLatticeAccessLogSubscription_disappears
--- PASS: TestAccVPCLatticeAccessLogSubscription_tags (74.95s)
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatchWildcard
--- PASS: TestAccVPCLatticeAccessLogSubscription_disappears (28.13s)
=== CONT  TestAccVPCLatticeAccessLogSubscription_cloudwatchNoWildcard
--- PASS: TestAccVPCLatticeAccessLogSubscription_cloudwatchWildcard (27.29s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_cloudwatchNoWildcard (26.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	124.017s

[ewbankkit]

@exoego Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.