r/aws_fis_experiment_template: Add parameters to target blocks

[lawliet89]

Description

r/aws_fis_experiment_template: Add parameters to target blocks

Relations

References

https://docs.aws.amazon.com/fis/latest/APIReference/API_CreateExperimentTemplateTargetInput.html

Output from Acceptance Testing

AWS_PROFILE=default make testacc TESTS=TestAccFISExperimentTemplate_ebs PKG=fis
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 20 -run='TestAccFISExperimentTemplate_ebs'  -timeout 180m
=== RUN   TestAccFISExperimentTemplate_ebs
=== PAUSE TestAccFISExperimentTemplate_ebs
=== RUN   TestAccFISExperimentTemplate_ebsParameters
=== PAUSE TestAccFISExperimentTemplate_ebsParameters
=== CONT  TestAccFISExperimentTemplate_ebs
=== CONT  TestAccFISExperimentTemplate_ebsParameters
--- PASS: TestAccFISExperimentTemplate_ebsParameters (60.66s)
--- PASS: TestAccFISExperimentTemplate_ebs (60.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fis	63.354s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[lawliet89]

On https://docs.aws.amazon.com/fis/latest/userguide/eks-pod-actions.html it says

You can't identify targets of type aws:eks:pod in your experiment template using resource ARNs or resource tags. You must identify targets using the required resource parameters.

Should we remove the validation from the provider and leave the server to validate?

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFISExperimentTemplate_' PKG=fis ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 2  -run=TestAccFISExperimentTemplate_ -timeout 180m
=== RUN   TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== RUN   TestAccFISExperimentTemplate_disappears
=== PAUSE TestAccFISExperimentTemplate_disappears
=== RUN   TestAccFISExperimentTemplate_update
=== PAUSE TestAccFISExperimentTemplate_update
=== RUN   TestAccFISExperimentTemplate_spot
=== PAUSE TestAccFISExperimentTemplate_spot
=== RUN   TestAccFISExperimentTemplate_eks
=== PAUSE TestAccFISExperimentTemplate_eks
=== RUN   TestAccFISExperimentTemplate_ebs
=== PAUSE TestAccFISExperimentTemplate_ebs
=== RUN   TestAccFISExperimentTemplate_ebsParameters
=== PAUSE TestAccFISExperimentTemplate_ebsParameters
=== RUN   TestAccFISExperimentTemplate_loggingConfiguration
=== PAUSE TestAccFISExperimentTemplate_loggingConfiguration
=== CONT  TestAccFISExperimentTemplate_basic
=== CONT  TestAccFISExperimentTemplate_eks
--- PASS: TestAccFISExperimentTemplate_basic (24.52s)
=== CONT  TestAccFISExperimentTemplate_update
--- PASS: TestAccFISExperimentTemplate_update (38.17s)
=== CONT  TestAccFISExperimentTemplate_spot
--- PASS: TestAccFISExperimentTemplate_spot (19.22s)
=== CONT  TestAccFISExperimentTemplate_disappears
--- PASS: TestAccFISExperimentTemplate_disappears (20.65s)
=== CONT  TestAccFISExperimentTemplate_ebsParameters
--- PASS: TestAccFISExperimentTemplate_ebsParameters (55.11s)
=== CONT  TestAccFISExperimentTemplate_loggingConfiguration
--- PASS: TestAccFISExperimentTemplate_loggingConfiguration (136.71s)
=== CONT  TestAccFISExperimentTemplate_ebs
--- PASS: TestAccFISExperimentTemplate_ebs (61.31s)
--- PASS: TestAccFISExperimentTemplate_eks (694.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fis	699.839s

[ewbankkit]

@lawliet89 Thanks for the contribution 🎉 👏.
I'm going to merge leaving validation as-is. If it causes problems please open an Issue/PR.

[github-actions]

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.