-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: aws_finspace_kx_environment
#31802
Conversation
Community NoteVoting for Prioritization
For Submitters
|
_disappears and _tags acceptance test output not shown above since still working through some test issues for those two brought about by switch to transparent tagging, as discussed with @jar-b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @kavan-aws 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
this workaround avoids a confirmed bug in the CreateKxEnvironment API which does not properly apply tags when sent in the create request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=finspace TESTS=TestAccFinSpaceKxEnvironment_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxEnvironment_' -timeout 180m
--- PASS: TestAccFinSpaceKxEnvironment_disappears (1063.94s)
--- PASS: TestAccFinSpaceKxEnvironment_basic (1083.38s)
--- PASS: TestAccFinSpaceKxEnvironment_tags (1098.44s)
--- PASS: TestAccFinSpaceKxEnvironment_updateName (1110.38s)
--- PASS: TestAccFinSpaceKxEnvironment_description (1124.45s)
--- PASS: TestAccFinSpaceKxEnvironment_customDNS (1678.70s)
--- PASS: TestAccFinSpaceKxEnvironment_transitGateway (1762.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/finspace 1765.527s
aws_finspace_kx_environment
Thanks for your contribution, @kavan-aws! 👏 |
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request introduces the
finspace_kx_environment
resource, along with its associated tests and documentation. This is one component of four new resources being introduced to enable terraform support for FinSpace Managed kdb.Relations
Relates #22658
References
Output from Acceptance Testing