Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_connect_security_profile: set correct tags in read #31716

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

johnsonaj
Copy link
Contributor

Description

Set tags_all correctly in state

Relations

Closes #31648

References

Output from Acceptance Testing

$ make testacc PKG=connect TESTS="TestAccConnect_serial/SecurityProfile/tags"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnect_serial/SecurityProfile/tags'  -timeout 180m
--- PASS: TestAccConnect_serial (143.74s)
    --- PASS: TestAccConnect_serial/SecurityProfile (143.74s)
        --- PASS: TestAccConnect_serial/SecurityProfile/tags (143.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	146.858s

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/connect Issues and PRs that pertain to the connect service. labels Jun 1, 2023
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. tags Pertains to resource tagging. labels Jun 1, 2023
@github-actions github-actions bot removed the tags Pertains to resource tagging. label Jun 1, 2023
@johnsonaj johnsonaj added the tags Pertains to resource tagging. label Jun 1, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnect_serial/SecurityProfile/tags' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/SecurityProfile/tags -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/SecurityProfile
=== RUN   TestAccConnect_serial/SecurityProfile/tags
--- PASS: TestAccConnect_serial (162.14s)
    --- PASS: TestAccConnect_serial/SecurityProfile (162.14s)
        --- PASS: TestAccConnect_serial/SecurityProfile/tags (162.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	167.788s

@johnsonaj johnsonaj merged commit e516445 into main Jun 1, 2023
@johnsonaj johnsonaj deleted the b-aws_connect_security_profile-tags branch June 1, 2023 19:09
@github-actions github-actions bot added this to the v5.1.0 milestone Jun 1, 2023
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/connect Issues and PRs that pertain to the connect service. size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_connect_security_profile ignoring default_tags
2 participants