r/aws_glue_data_quality_ruleset

[GlennChia]

Description

Relations

Closes #31598

References

• CreateDataQualityRuleset
• GetDataQualityRuleset
• UpdateDataQualityRuleset
• DeleteDataQualityRuleset

Note: while the DataQualityTargetTable object supports CatalogId, the AWS GO SDK does not: DataQualityTargetTable

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccGlueDataQualityRuleset' PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueDataQualityRuleset -timeout 180m
=== RUN   TestAccGlueDataQualityRuleset_basic
=== PAUSE TestAccGlueDataQualityRuleset_basic
=== RUN   TestAccGlueDataQualityRuleset_updateRuleset
=== PAUSE TestAccGlueDataQualityRuleset_updateRuleset
=== RUN   TestAccGlueDataQualityRuleset_updateDescription
=== PAUSE TestAccGlueDataQualityRuleset_updateDescription
=== RUN   TestAccGlueDataQualityRuleset_targetTable
=== PAUSE TestAccGlueDataQualityRuleset_targetTable
=== RUN   TestAccGlueDataQualityRuleset_tags
=== PAUSE TestAccGlueDataQualityRuleset_tags
=== RUN   TestAccGlueDataQualityRuleset_disappears
=== PAUSE TestAccGlueDataQualityRuleset_disappears
=== CONT  TestAccGlueDataQualityRuleset_basic
=== CONT  TestAccGlueDataQualityRuleset_targetTable
=== CONT  TestAccGlueDataQualityRuleset_disappears
=== CONT  TestAccGlueDataQualityRuleset_tags
=== CONT  TestAccGlueDataQualityRuleset_updateDescription
=== CONT  TestAccGlueDataQualityRuleset_updateRuleset
--- PASS: TestAccGlueDataQualityRuleset_disappears (29.01s)
--- PASS: TestAccGlueDataQualityRuleset_basic (37.60s)
--- PASS: TestAccGlueDataQualityRuleset_targetTable (40.06s)
--- PASS: TestAccGlueDataQualityRuleset_updateRuleset (58.80s)
--- PASS: TestAccGlueDataQualityRuleset_updateDescription (58.86s)
--- PASS: TestAccGlueDataQualityRuleset_tags (75.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       75.990s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlueDataQualityRuleset_' PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2  -run=TestAccGlueDataQualityRuleset_ -timeout 180m
=== RUN   TestAccGlueDataQualityRuleset_basic
=== PAUSE TestAccGlueDataQualityRuleset_basic
=== RUN   TestAccGlueDataQualityRuleset_updateRuleset
=== PAUSE TestAccGlueDataQualityRuleset_updateRuleset
=== RUN   TestAccGlueDataQualityRuleset_updateDescription
=== PAUSE TestAccGlueDataQualityRuleset_updateDescription
=== RUN   TestAccGlueDataQualityRuleset_targetTable
=== PAUSE TestAccGlueDataQualityRuleset_targetTable
=== RUN   TestAccGlueDataQualityRuleset_tags
=== PAUSE TestAccGlueDataQualityRuleset_tags
=== RUN   TestAccGlueDataQualityRuleset_disappears
=== PAUSE TestAccGlueDataQualityRuleset_disappears
=== CONT  TestAccGlueDataQualityRuleset_basic
=== CONT  TestAccGlueDataQualityRuleset_targetTable
--- PASS: TestAccGlueDataQualityRuleset_basic (19.82s)
=== CONT  TestAccGlueDataQualityRuleset_disappears
--- PASS: TestAccGlueDataQualityRuleset_targetTable (22.88s)
=== CONT  TestAccGlueDataQualityRuleset_updateDescription
--- PASS: TestAccGlueDataQualityRuleset_disappears (13.26s)
=== CONT  TestAccGlueDataQualityRuleset_tags
--- PASS: TestAccGlueDataQualityRuleset_updateDescription (31.52s)
=== CONT  TestAccGlueDataQualityRuleset_updateRuleset
--- PASS: TestAccGlueDataQualityRuleset_tags (44.17s)
--- PASS: TestAccGlueDataQualityRuleset_updateRuleset (31.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	91.086s

[ewbankkit]

@GlennChia Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.