Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to filter cluster snapshots by tags #31602

Conversation

rromic
Copy link
Contributor

@rromic rromic commented May 26, 2023

Description

This feature provides support for filtering cluster snapshots by provided tags and not db_cluster_identifier or db_cluster_snapshot_identifier are not required attributes to allow greater flexibility in filter capabilities.

Relations

Relates #10010.

References

Output from Acceptance Testing

export AWS_DEFAULT_REGION=eu-central-1
make testacc TESTS=TestAccRDSClusterSnapshotDataSource PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterSnapshotDataSource'  -timeout 180m
=== RUN   TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== PAUSE TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== RUN   TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
=== PAUSE TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
=== RUN   TestAccRDSClusterSnapshotDataSource_mostRecent
=== PAUSE TestAccRDSClusterSnapshotDataSource_mostRecent
=== RUN   TestAccRDSClusterSnapshotDataSource_tags
=== PAUSE TestAccRDSClusterSnapshotDataSource_tags
=== CONT  TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== CONT  TestAccRDSClusterSnapshotDataSource_mostRecent
=== CONT  TestAccRDSClusterSnapshotDataSource_tags
=== CONT  TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
--- PASS: TestAccRDSClusterSnapshotDataSource_tags (245.80s)
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier (247.21s)
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier (275.88s)
--- PASS: TestAccRDSClusterSnapshotDataSource_mostRecent (388.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        390.497s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 26, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 26, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 26, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSClusterSnapshot' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterSnapshot -timeout 180m
=== RUN   TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== PAUSE TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== RUN   TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
=== PAUSE TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
=== RUN   TestAccRDSClusterSnapshotDataSource_mostRecent
=== PAUSE TestAccRDSClusterSnapshotDataSource_mostRecent
=== RUN   TestAccRDSClusterSnapshotDataSource_tags
=== PAUSE TestAccRDSClusterSnapshotDataSource_tags
=== RUN   TestAccRDSClusterSnapshot_basic
=== PAUSE TestAccRDSClusterSnapshot_basic
=== RUN   TestAccRDSClusterSnapshot_tags
=== PAUSE TestAccRDSClusterSnapshot_tags
=== CONT  TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== CONT  TestAccRDSClusterSnapshotDataSource_tags
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier (243.82s)
=== CONT  TestAccRDSClusterSnapshot_tags
--- PASS: TestAccRDSClusterSnapshotDataSource_tags (368.16s)
=== CONT  TestAccRDSClusterSnapshot_basic
--- PASS: TestAccRDSClusterSnapshot_tags (321.25s)
=== CONT  TestAccRDSClusterSnapshotDataSource_mostRecent
--- PASS: TestAccRDSClusterSnapshot_basic (252.93s)
=== CONT  TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier (299.95s)
--- PASS: TestAccRDSClusterSnapshotDataSource_mostRecent (447.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1024.049s

@ewbankkit
Copy link
Contributor

@rromic Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c236e80 into hashicorp:main Aug 1, 2023
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants