-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to filter cluster snapshots by tags #31602
feat: option to filter cluster snapshots by tags #31602
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSClusterSnapshot' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2 -run=TestAccRDSClusterSnapshot -timeout 180m
=== RUN TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== PAUSE TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== RUN TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
=== PAUSE TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
=== RUN TestAccRDSClusterSnapshotDataSource_mostRecent
=== PAUSE TestAccRDSClusterSnapshotDataSource_mostRecent
=== RUN TestAccRDSClusterSnapshotDataSource_tags
=== PAUSE TestAccRDSClusterSnapshotDataSource_tags
=== RUN TestAccRDSClusterSnapshot_basic
=== PAUSE TestAccRDSClusterSnapshot_basic
=== RUN TestAccRDSClusterSnapshot_tags
=== PAUSE TestAccRDSClusterSnapshot_tags
=== CONT TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier
=== CONT TestAccRDSClusterSnapshotDataSource_tags
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier (243.82s)
=== CONT TestAccRDSClusterSnapshot_tags
--- PASS: TestAccRDSClusterSnapshotDataSource_tags (368.16s)
=== CONT TestAccRDSClusterSnapshot_basic
--- PASS: TestAccRDSClusterSnapshot_tags (321.25s)
=== CONT TestAccRDSClusterSnapshotDataSource_mostRecent
--- PASS: TestAccRDSClusterSnapshot_basic (252.93s)
=== CONT TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier (299.95s)
--- PASS: TestAccRDSClusterSnapshotDataSource_mostRecent (447.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 1024.049s
@rromic Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This feature provides support for filtering cluster snapshots by provided tags and not db_cluster_identifier or db_cluster_snapshot_identifier are not required attributes to allow greater flexibility in filter capabilities.
Relations
Relates #10010.
References
Output from Acceptance Testing