F aws db snapshot data source tags filter

[rromic]

Description

This feature provides support for filtering db snapshots by provided tags and not db_instance_identifier or db_snapshot_identifier are not required attributes to allow greater flexibility in filter capabilities.

Relations

Closes #10010.
Closes #32597.

References

Output from Acceptance Testing

export AWS_DEFAULT_REGION=eu-central-1
make testacc TESTS=TestAccRDSSnapshotDataSource_basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSnapshotDataSource_basic'  -timeout 180m
=== RUN   TestAccRDSSnapshotDataSource_basic
=== PAUSE TestAccRDSSnapshotDataSource_basic
=== CONT  TestAccRDSSnapshotDataSource_basic
--- PASS: TestAccRDSSnapshotDataSource_basic (456.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        458.566s


...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSSnapshot' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSnapshot -timeout 180m
=== RUN   TestAccRDSSnapshotCopy_basic
=== PAUSE TestAccRDSSnapshotCopy_basic
=== RUN   TestAccRDSSnapshotCopy_tags
=== PAUSE TestAccRDSSnapshotCopy_tags
=== RUN   TestAccRDSSnapshotCopy_disappears
=== PAUSE TestAccRDSSnapshotCopy_disappears
=== RUN   TestAccRDSSnapshotDataSource_basic
=== PAUSE TestAccRDSSnapshotDataSource_basic
=== RUN   TestAccRDSSnapshot_basic
=== PAUSE TestAccRDSSnapshot_basic
=== RUN   TestAccRDSSnapshot_share
=== PAUSE TestAccRDSSnapshot_share
=== RUN   TestAccRDSSnapshot_tags
=== PAUSE TestAccRDSSnapshot_tags
=== RUN   TestAccRDSSnapshot_disappears
=== PAUSE TestAccRDSSnapshot_disappears
=== CONT  TestAccRDSSnapshotCopy_basic
=== CONT  TestAccRDSSnapshot_basic
--- PASS: TestAccRDSSnapshotCopy_basic (712.41s)
=== CONT  TestAccRDSSnapshotCopy_disappears
--- PASS: TestAccRDSSnapshot_basic (756.76s)
=== CONT  TestAccRDSSnapshotDataSource_basic
--- PASS: TestAccRDSSnapshotCopy_disappears (688.54s)
=== CONT  TestAccRDSSnapshot_tags
--- PASS: TestAccRDSSnapshotDataSource_basic (678.49s)
=== CONT  TestAccRDSSnapshot_disappears
--- PASS: TestAccRDSSnapshot_disappears (641.28s)
=== CONT  TestAccRDSSnapshot_share
--- PASS: TestAccRDSSnapshot_tags (742.74s)
=== CONT  TestAccRDSSnapshotCopy_tags
--- PASS: TestAccRDSSnapshot_share (731.15s)
--- PASS: TestAccRDSSnapshotCopy_tags (953.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	3102.298s

% make testacc TESTARGS='-run=TestAccRDSInstanceAutomatedBackupsReplication_' PKG=rds ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstanceAutomatedBackupsReplication_ -timeout 180m
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_basic
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_basic
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_basic (1261.14s)
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod (1343.06s)
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_disappears
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_disappears (1413.86s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted (1621.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2887.740s

[rromic]

@ewbankkit Awesome! Thank you!

[github-actions]

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.