Fix : ECR scanning configuration empty rules

[sousmangoosta]

Description

More context

If we only send to the API the scan_type without empty rule when we remove all rules, the API consider that there is no changes needed.
This PR then remove the nil check so an empty list is sent when there is no rules anymore.

Relations

Closes #31423.

Output from Acceptance Testing

before the nil removal

$ make testacc TESTS='TestAccECRScanningConfiguration_serial' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_serial'  -timeout 180m
=== RUN   TestAccECRScanningConfiguration_serial
=== PAUSE TestAccECRScanningConfiguration_serial
=== CONT  TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/update
    registry_scanning_configuration_test.go:60: Step 5/6 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_ecr_registry_scanning_configuration.test will be updated in-place
          ~ resource "aws_ecr_registry_scanning_configuration" "test" {
                id          = "1234567890"
                # (2 unchanged attributes hidden)
        
              - rule {
                  - scan_frequency = "SCAN_ON_PUSH" -> null
        
                  - repository_filter {
                      - filter      = "*" -> null
                      - filter_type = "WILDCARD" -> null
                    }
                }
              - rule {
                  - scan_frequency = "CONTINUOUS_SCAN" -> null
        
                  - repository_filter {
                      - filter      = "example" -> null
                      - filter_type = "WILDCARD" -> null
                    }
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccECRScanningConfiguration_serial (49.95s)
    --- FAIL: TestAccECRScanningConfiguration_serial/update (49.95s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ecr        50.131s
FAIL
make: *** [testacc] Error 1
$

With the nil removal

$ make testacc TESTS='TestAccECRScanningConfiguration_serial' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRScanningConfiguration_serial'  -timeout 180m
=== RUN   TestAccECRScanningConfiguration_serial
=== PAUSE TestAccECRScanningConfiguration_serial
=== CONT  TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
=== RUN   TestAccECRScanningConfiguration_serial/update
--- PASS: TestAccECRScanningConfiguration_serial (71.87s)
    --- PASS: TestAccECRScanningConfiguration_serial/basic (19.38s)
    --- PASS: TestAccECRScanningConfiguration_serial/update (52.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        72.052s
$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRScanningConfiguration_serial' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRScanningConfiguration_serial -timeout 180m
=== RUN   TestAccECRScanningConfiguration_serial
=== PAUSE TestAccECRScanningConfiguration_serial
=== CONT  TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
=== RUN   TestAccECRScanningConfiguration_serial/update
--- PASS: TestAccECRScanningConfiguration_serial (88.60s)
    --- PASS: TestAccECRScanningConfiguration_serial/basic (24.01s)
    --- PASS: TestAccECRScanningConfiguration_serial/update (64.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	93.811s

[ewbankkit]

@sousmangoosta Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.