Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dx_gateway_association: Call out deprecation of vpn_gateway_id #31384

Conversation

ewbankkit
Copy link
Contributor

Description

#12482 deprecated the log_group_name attribute in the resource's Terraform schema but did not call this out in the CHANGELOG (#8528 deprecated the attribute in documentation).
Instead of moving straight to removal in v5.0.0, call out the deprecation and remove in a future (post-v5.0.0) version.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label May 12, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@ewbankkit ewbankkit added the service/directconnect Issues and PRs that pertain to the directconnect service. label May 12, 2023
@ewbankkit ewbankkit added this to the v5.0.0 milestone May 12, 2023
@ewbankkit ewbankkit added the documentation Introduces or discusses updates to documentation. label May 12, 2023
@ewbankkit ewbankkit merged commit c770c24 into main May 12, 2023
@ewbankkit ewbankkit deleted the td-aws_dx_gateway_association.vpn_gateway_id-callout-deprecation branch May 12, 2023 19:03
github-actions bot pushed a commit that referenced this pull request May 12, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant